eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/GiftCard/Model/Giftcard.php

Doc Comments +3 added lines, -2 removed lines

@@ -129,7 +129,7 @@ 
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param  array      $arr
-     * @param  string|int $field Valid array key
+     * @param  string $field Valid array key
      * @param  mixed      $default
      * @return mixed
      */
@@ -370,7 +370,6 @@ 
      * Log the different requests consistently.
      *
      * @param string $type 'balance', 'redeem', 'void'
-     * @param string $body the serialized xml body
      * @param string $direction 'request' or 'response'
      */
     protected function logApiCall($type, $direction)
@@ -665,6 +664,8 @@ 
      * @param IBidirectionalApi
      * @param bool
      * @param string
+     * @param boolean $isRequest
+     * @param string $logMessage
      */
     protected function logStoredValuePayload(IBidirectionalApi $api, $isRequest, $logMessage)
     {

Unused Use Statements +3 added lines, -3 removed lines

@@ -13,14 +13,14 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
+use Psr\Log\LoggerInterface;
+use Psr\Log\NullLogger;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedHttpAction;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedOperation;
+use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Payload;
 use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
-use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 /**
  * Model representing a gift card that has been applied to an order.

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/GiftCard/Model/Mask.php

Doc Comments +2 added lines, -1 removed lines

@@ -46,7 +46,8 @@
      * @param  array
      * @param  string | int $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @param string $field
+     * @return EbayEnterprise_Eb2cCore_Helper_Data
      */
     protected function nullCoalesce(array $arr, $field, $default)
     {

Spacing +1 added lines, -1 removed lines

@@ -119,7 +119,7 @@
      * @param  bool
      * @return self
      */
-    protected function doTheMasking(DOMDocument $doc, DOMXPath $xpath, array $nodes, $hasAttribute=false)
+    protected function doTheMasking(DOMDocument $doc, DOMXPath $xpath, array $nodes, $hasAttribute = false)
     {
         foreach ($nodes as $node => $expression) {
             /** @var DOMElement */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/GiftCard/Model/Observer.php

Doc Comments +2 added lines, -4 removed lines

@@ -74,7 +74,7 @@ 
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param array      $arr
-     * @param string|int $field Valid array key
+     * @param string $field Valid array key
      * @param mixed      $default
      * @return mixed
      */
@@ -147,7 +147,6 @@ 
      * Redeem the gift card and handle any errors encountered while redeeming
      * the gift card. Return the amount redeemed from the card.
      * @param EbayEnterprise_GiftCard_Model_IGiftcard $card
-     * @param string $orderId
      * @return float
      * @throws EbayEnterprise_GiftCard_Exception If card could not be redeemed for for the expected amount
      */
@@ -236,8 +235,7 @@ 
      * Redeem the gift card for the requested amount and return the amount that
      * was actually redeemed for the card.
      * @param EbayEnterprise_GiftCard_Model_IGiftcard $card
-     * @param float $amount
-     * @return self
+     * @return EbayEnterprise_GiftCard_Model_IGiftcard
      */
     protected function _redeemVoidCard(EbayEnterprise_GiftCard_Model_IGiftcard $card)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/GiftCard/Model/Order/Create/Payment.php

Doc Comments +6 added lines, -1 removed lines

@@ -31,7 +31,7 @@ 
     /**
      * ensure correct types
      * @param  EbayEnterprise_GiftCard_Model_IContainer $container
-     * @return array
+     * @return EbayEnterprise_GiftCard_Model_IContainer[]
      */
     protected function _enforceTypes(EbayEnterprise_GiftCard_Model_IContainer $container)
     {
@@ -72,6 +72,11 @@ 
         }
     }
 
+    /**
+     * @param string $key
+     *
+     * @return EbayEnterprise_GiftCard_Model_IContainer
+     */
     protected function _nullCoalesce($key, array $args, $default)
     {
         return isset($args[$key]) ? $args[$key] : $default;

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/GiftCard/Model/Session.php

Doc Comments +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
     /**
      * Get the gift card object currently being applied or checked.
      *
-     * @return EbayEnterprise_GiftCard_Model_IGiftcard|null
+     * @return EbayEnterprise_GiftCard_Model_Giftcard|null
      */
     public function getEbayEnterpriseCurrentGiftCard($clear = false)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/GiftCard/Model/Tendertype/Lookup.php

Doc Comments +6 added lines

@@ -82,6 +82,9 @@ 
         return func_get_args();
     }
 
+    /**
+     * @param string $key
+     */
     protected function nullCoalesce(array $arr, $key, $default)
     {
         return isset($arr[$key]) ? $arr[$key] : $default;
@@ -176,6 +179,8 @@ 
      *
      * @param string
      * @param string
+     * @param string $responseCode
+     * @param string $responseMessage
      * @return EbayEnterprise_GiftCard_Exception_InvalidCardNumber_Exception
      */
     protected function createLookupFailedException($responseCode, $responseMessage)
@@ -221,6 +226,7 @@ 
      *
      * @param ILookupRequest
      * @param string
+     * @param string $logMessage
      * @return self
      */
     protected function logRequest(ILookupRequest $request, $logMessage)

Unused Use Statements +1 added lines, -2 removed lines

@@ -13,14 +13,13 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedHttpAction;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedOperation;
+use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
 use eBayEnterprise\RetailOrderManagement\Payload\Payment\TenderType\ILookupReply;
 use eBayEnterprise\RetailOrderManagement\Payload\Payment\TenderType\ILookupRequest;
-use PSR\Log\NullLogger;
 
 /**
  * performs gift card tender type lookups using the Retail Order Management

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/GiftCard/Model/Total/Quote.php

Doc Comments +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
      *
      * @param EbayEnterprise_GiftCard_Helper_Data
      * @param EbayEnterprise_GiftCard_Model_IContainer
-     * @return array
+     * @return EbayEnterprise_GiftCard_Model_IContainer[]
      */
     protected function _checkTypes(
         EbayEnterprise_GiftCard_Helper_Data $helper,
@@ -57,7 +57,7 @@ 
      * @param  array  $arr
      * @param  string $field
      * @param  mixed  $default
-     * @return mixed
+     * @return EbayEnterprise_GiftCard_Model_IContainer
      */
     protected function _nullCoalesce(array $arr = array(), $field, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Inventory/Helper/Data.php

Doc Comments +2 added lines

@@ -112,6 +112,7 @@ 
      * Determine if the passed in street date string is in the future.
      *
      * @param  string
+     * @param string $streetDate
      * @return bool
      */
     protected function isStreetDateInTheFuture($streetDate)
@@ -125,6 +126,7 @@ 
      * Using configuration setting to determine the to date for street date.
      *
      * @param  string
+     * @param string $streetDate
      * @return DateTime
      */
     protected function getStreetToDate($streetDate)

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
     protected function getStreetToDate($streetDate)
     {
         $toDate = $this->getNewDateTime($streetDate);
-        $intervalSpec = "P{$this->coreConfig->toStreetDateRange}D";
+        $intervalSpec = "p{$this->coreConfig->toStreetDateRange}d";
         return $toDate->add($this->getNewDateInterval($intervalSpec));
     }
 

Braces +1 added lines, -2 removed lines

@@ -59,8 +59,7 @@
         Mage_Sales_Model_Order $order,
         $shipmentId,
         $trackingNumber=null
-    )
-    {
+    ) {
         return func_get_args();
     }
 

src/app/code/community/EbayEnterprise/Inventory/Helper/Details/Item.php

Unused Use Statements +1 added lines, -2 removed lines

@@ -13,10 +13,9 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
+use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IDetailItem;
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IItem;
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IOrderItem;
-use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IDetailItem;
-use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IAddress;
 
 class EbayEnterprise_Inventory_Helper_Details_Item
 {

Doc Comments +1 added lines

@@ -83,6 +83,7 @@
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce(array $arr, $key, $default)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {