eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Tax/Model/Response/Parser/Address.php

Doc Comments +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
      * nearly identical steps from being repeated for each item for each type of
      * tax data.
      *
-     * @return EbayEnterprise_Tax_Model_Record[]
+     * @return EbayEnterprise_Tax_Model_Response_Parser_Address
      */
     protected function _extractTaxData()
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,8 +13,8 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxedShipGroup;
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxedOrderItem;
+use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxedShipGroup;
 
 class EbayEnterprise_Tax_Model_Response_Parser_Address extends EbayEnterprise_Tax_Model_Response_Parser_Abstract
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Model/Response/Parser/Item.php

Doc Comments +1 added lines, -1 removed lines

@@ -244,7 +244,7 @@
     /**
      * Extract tax records from a gifting payload.
      *
-     * @return EbayEnterprise_Tax_Model_Record
+     * @return EbayEnterprise_Tax_Model_Record[]
      */
     protected function _extractGiftingTaxRecords()
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Model/Total/Quote/Address/Tax.php

Doc Comments +1 added lines

@@ -83,6 +83,7 @@
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce(array $arr, $key, $default)

Spacing +3 added lines, -3 removed lines

@@ -143,7 +143,7 @@ 
     {
         return array_reduce(
             $taxRecords,
-            function ($total, $taxRecord) {
+            function($total, $taxRecord) {
                 return $total + $taxRecord->getCalculatedTax();
             },
             0.00
@@ -160,7 +160,7 @@ 
     {
         return array_reduce(
             $duties,
-            function ($total, $duty) {
+            function($total, $duty) {
                 return $total + $duty->getAmount();
             },
             0.00
@@ -177,7 +177,7 @@ 
     {
         return array_reduce(
             $fees,
-            function ($total, $fee) {
+            function($total, $fee) {
                 return $total + $fee->getAmount();
             },
             0.00

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Test/Model/CollectorTest.php

Doc Comments +3 added lines

@@ -121,6 +121,7 @@ 
      * Build a mock tax record with the given quote address id.
      *
      * @param int
+     * @param integer $quoteAddressId
      * @return EbayEnterprise_Tax_Model_Record
      */
     protected function _buildMockTaxRecord($quoteAddressId)
@@ -142,6 +143,7 @@ 
      * Build a mock tax record with the given quote address id.
      *
      * @param int
+     * @param integer $itemId
      * @return EbayEnterprise_Tax_Model_Duty
      */
     protected function _buildMockTaxDuty($itemId)
@@ -163,6 +165,7 @@ 
      * Build a mock tax record with the given quote address id.
      *
      * @param int
+     * @param integer $itemId
      * @return EbayEnterprise_Tax_Model_Record
      */
     protected function _buildMockTaxFee($itemId)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Test/Model/Order/Create/ShipgroupTest.php

Doc Comments +1 added lines

@@ -113,6 +113,7 @@
 
     /**
      * Mock a tax record to return the expected tax source and address id.
+     * @param integer $addressId
      */
     protected function _mockTaxRecord($taxSource, $addressId)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Test/Model/Total/Quote/Address/TaxTest.php

Doc Comments +3 added lines

@@ -91,6 +91,7 @@ 
      * Build a mock tax record scripted to return the provided calculated tax amount.
      *
      * @param float
+     * @param double $calculatedTaxAmount
      * @return EbayEnterprise_Tax_Model_Record
      */
     protected function _buildMockTaxRecord($calculatedTaxAmount)
@@ -111,6 +112,7 @@ 
      * Build a mock tax duty scripted to return the provided amount.
      *
      * @param float
+     * @param double $dutyAmount
      * @return EbayEnterprise_Tax_Model_Duty
      */
     protected function _buildMockTaxDuty($dutyAmount)
@@ -131,6 +133,7 @@ 
      * Build a mock tax fee scripted to return the provided amount.
      *
      * @param float
+     * @param double $feeAmount
      * @return EbayEnterprise_Tax_Model_Fee
      */
     protected function _buildMockTaxFee($feeAmount)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Address/Block/Suggestions.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 class EbayEnterprise_Address_Block_Suggestions extends Mage_Core_Block_Template
 {
     // Name of the input field
-    const SUGGESTION_INPUT_NAME         = 'validation_option';
+    const SUGGESTION_INPUT_NAME = 'validation_option';
     /**
      * Where to find the format template in the config registry
      * @see EbayEnterprise_Address_Model_Config::$_configPaths

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Address/Model/Order/Address/Validation.php

Indentation +13 added lines, -13 removed lines

@@ -1,17 +1,17 @@ 
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Address_Model_Order_Address_Validation
 {
@@ -70,7 +70,7 @@ 
      */
     public function allowAddressValidation(Mage_Customer_Model_Address_Abstract $address)
     {
-       /** @var Mage_Core_Controller_Request_Http */
+        /** @var Mage_Core_Controller_Request_Http */
         $request = $this->app->getRequest();
         /** @var bool */
         $needValidation = $this->validator->shouldValidateAddress($address);

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param array $arr
-     * @param string|int $field Valid array key
+     * @param string $field Valid array key
      * @param mixed $default
      * @return mixed
      */

src/app/code/community/EbayEnterprise/Amqp/Test/Helper/ConfigTest.php

Spacing +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
             ->will($this->returnValue(array_map(
                 // Get just the "store" key from each triple in the $stores array - produces
                 // an array of Mage_Core_Model_Store objects.
-                function ($storeAndConfig) {
+                function($storeAndConfig) {
                     return $storeAndConfig['store'];
                 },
                 $stores
@@ -99,7 +99,7 @@ 
                 // and the Eb2cCore module's config as the second for each triple in
                 // the $stores array - allows the stub to return the correct
                 // configuration for a given store.
-                function ($storeAndConfig) {
+                function($storeAndConfig) {
                     return array($storeAndConfig['store'], $storeAndConfig['core_config']);
                 },
                 $stores
@@ -113,7 +113,7 @@ 
                 // and the EbayEnterprise_Amqp module's config as the second for each
                 // triple in the $stores array - allows the stub to return the correct
                 // configuration for a given store.
-                function ($storeAndConfig) {
+                function($storeAndConfig) {
                     return array($storeAndConfig['store'], $storeAndConfig['amqp_config']);
                 },
                 $stores

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {