eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Address/Block/Suggestions.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 class EbayEnterprise_Address_Block_Suggestions extends Mage_Core_Block_Template
 {
     // Name of the input field
-    const SUGGESTION_INPUT_NAME         = 'validation_option';
+    const SUGGESTION_INPUT_NAME = 'validation_option';
     /**
      * Where to find the format template in the config registry
      * @see EbayEnterprise_Address_Model_Config::$_configPaths

src/app/code/community/EbayEnterprise/Address/Test/Model/ValidatorTest.php

Spacing +4 added lines, -4 removed lines

@@ -917,8 +917,8 @@ 
             ->method('getAddressType')
             ->will($this->returnValue($addressType));
         $addressData = [
-            ['street',    null, '123 Main St'],
-            ['city',      null, 'Fooville'],
+            ['street', null, '123 Main St'],
+            ['city', null, 'Fooville'],
             ['region_id', null, 51],
         ];
         $address->expects($this->any())
@@ -967,8 +967,8 @@ 
         // any one of these being different from the validatedAddressData below
         // will cause the comparison check fail
         $addressData = [
-            ['street',    null, 'Borg'],
-            ['city',      null, 'Barton'],
+            ['street', null, 'Borg'],
+            ['city', null, 'Barton'],
             ['region_id', null, 41],
         ];
         $address->expects($this->any())

src/app/code/community/EbayEnterprise/Amqp/Test/Helper/ConfigTest.php

Spacing +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
             ->will($this->returnValue(array_map(
                 // Get just the "store" key from each triple in the $stores array - produces
                 // an array of Mage_Core_Model_Store objects.
-                function ($storeAndConfig) {
+                function($storeAndConfig) {
                     return $storeAndConfig['store'];
                 },
                 $stores
@@ -99,7 +99,7 @@ 
                 // and the Eb2cCore module's config as the second for each triple in
                 // the $stores array - allows the stub to return the correct
                 // configuration for a given store.
-                function ($storeAndConfig) {
+                function($storeAndConfig) {
                     return array($storeAndConfig['store'], $storeAndConfig['core_config']);
                 },
                 $stores
@@ -113,7 +113,7 @@ 
                 // and the EbayEnterprise_Amqp module's config as the second for each
                 // triple in the $stores array - allows the stub to return the correct
                 // configuration for a given store.
-                function ($storeAndConfig) {
+                function($storeAndConfig) {
                     return array($storeAndConfig['store'], $storeAndConfig['amqp_config']);
                 },
                 $stores

src/app/code/community/EbayEnterprise/Catalog/Helper/Data.php

Spacing +5 added lines, -5 removed lines

@@ -370,8 +370,8 @@ 
      */
     public function mapPattern(array $keyMap, $pattern)
     {
-        return array_reduce(array_keys($keyMap), function ($result, $key) use ($keyMap, $pattern) {
-            $result = (trim($result) === '')? $pattern : $result;
+        return array_reduce(array_keys($keyMap), function($result, $key) use ($keyMap, $pattern) {
+            $result = (trim($result) === '') ? $pattern : $result;
             return str_replace(sprintf('{%s}', $key), $keyMap[$key], $result);
         });
     }
@@ -547,7 +547,7 @@ 
     protected function _loadWebsiteFilter($mageStoreId)
     {
         $config = Mage::helper('eb2ccore')->getConfigModel($mageStoreId);
-        return array (
+        return array(
             'catalog_id'      => $config->catalogId,
             'client_id'       => $config->clientId,
             'store_id'        => $config->storeId,
@@ -641,7 +641,7 @@ 
      */
     public function denormalizeSku($itemId, $catalogId)
     {
-        return (!empty($itemId) && strpos($itemId, $catalogId . '-') === 0)?
+        return (!empty($itemId) && strpos($itemId, $catalogId . '-') === 0) ?
             str_replace($catalogId . '-', '', $itemId) : $itemId;
     }
 
@@ -719,7 +719,7 @@ 
      * @param mixed
      * @return mixed
      */
-    protected function reregister($key, $value=null)
+    protected function reregister($key, $value = null)
     {
         $old = Mage::registry($key);
         Mage::unregister($key);

src/app/code/community/EbayEnterprise/Catalog/Helper/Feed.php

Spacing +2 added lines, -3 removed lines

@@ -165,8 +165,7 @@ 
         // (dates prior to unix epoch time 0 for example). If the two combined
         // functions are unable to produce a valid time, fall back to the unix
         // time `0` so something can be returned.
-        return DateTime::createFromFormat('U', strtotime($messageDateTime)) ?:
-            DateTime::createFromFormat('U', 0);
+        return DateTime::createFromFormat('U', strtotime($messageDateTime)) ?: DateTime::createFromFormat('U', 0);
     }
     /**
      * Ensure the Feed's event type matches.
@@ -224,7 +223,7 @@ 
     {
         $data = array();
         foreach ($mhc as $key => $value) {
-            $data[$key] = (is_array($value))? Mage::helper('eb2ccore')->invokeCallback($value) : $value;
+            $data[$key] = (is_array($value)) ? Mage::helper('eb2ccore')->invokeCallback($value) : $value;
         }
         return $data;
     }

src/app/code/community/EbayEnterprise/Catalog/Helper/Itemmaster.php

Spacing +2 added lines, -3 removed lines

@@ -116,7 +116,7 @@ 
      */
     public function passSubClass($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
     {
-        $value = (int)0;
+        $value = (int) 0;
         if (!empty($attrValue)) {
             $value = $attrValue;
         }
@@ -287,8 +287,7 @@ 
      */
     public function passSalesClass($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
     {
-        $enum = empty($attrValue) ? 'stock' :
-            Mage::getSingleton('eav/entity_attribute')
+        $enum = empty($attrValue) ? 'stock' : Mage::getSingleton('eav/entity_attribute')
                 ->loadByCode($product::ENTITY, $attribute)
                 ->getSource()->getOptionText($attrValue);
         return $this->passString($enum, $attribute, $product, $doc);

src/app/code/community/EbayEnterprise/Catalog/Helper/Map.php

Spacing +11 added lines, -13 removed lines

@@ -99,9 +99,8 @@ 
      */
     public function extractStatusValue(DOMNodeList $nodes)
     {
-        return ($nodes->length && strtolower($nodes->item(0)->nodeValue) === 'active')?
-            Mage_Catalog_Model_Product_Status::STATUS_ENABLED:
-            Mage_Catalog_Model_Product_Status::STATUS_DISABLED;
+        return ($nodes->length && strtolower($nodes->item(0)->nodeValue) === 'active') ?
+            Mage_Catalog_Model_Product_Status::STATUS_ENABLED : Mage_Catalog_Model_Product_Status::STATUS_DISABLED;
     }
     /**
      * extracts visibility from node list, returning an expected integer or translating an expected string
@@ -142,7 +141,7 @@ 
     public function extractProductTypeValue(DOMNodeList $nodes, Mage_Catalog_Model_Product $product)
     {
         $value = strtolower($this->coreHelper->extractNodeVal($nodes));
-        $type = ($this->_isValidProductType($value))? $value : Mage_Catalog_Model_Product_Type::TYPE_SIMPLE;
+        $type = ($this->_isValidProductType($value)) ? $value : Mage_Catalog_Model_Product_Type::TYPE_SIMPLE;
         $product->setTypeId($type)
             ->setTypeInstance(Mage_Catalog_Model_Product_Type::factory($product, true), true);
         return $type;
@@ -232,9 +231,8 @@ 
     public function extractUrlKeyValue(DOMNodeList $nodes, Mage_Catalog_Model_Product $product)
     {
         $urlKey = $this->coreHelper->extractNodeVal($nodes);
-        return ($urlKey !== '')?
-            $urlKey . '-' . $product->getStoreId() :
-            'Incomplete Product: ' . $product->getSku() . '-' . $product->getStoreId();
+        return ($urlKey !== '') ?
+            $urlKey . '-' . $product->getStoreId() : 'Incomplete Product: ' . $product->getSku() . '-' . $product->getStoreId();
     }
     /**
      * given a gift card type return the gift card constant mapped to it
@@ -264,7 +262,7 @@ 
         $value = $this->coreHelper->extractNodeVal($nodes);
         $cfg = Mage::helper('ebayenterprise_catalog')->getConfigModel();
         $mapData = $cfg->getConfigData(EbayEnterprise_Catalog_Helper_Feed::GIFTCARD_TENDER_CONFIG_PATH);
-        return isset($mapData[$value])? $this->_getGiftCardType($mapData[$value]) : null;
+        return isset($mapData[$value]) ? $this->_getGiftCardType($mapData[$value]) : null;
     }
 
     /**
@@ -313,7 +311,7 @@ 
      */
     public function extractStringValue(DOMNodeList $nodes)
     {
-        return ($nodes->length)? $nodes->item(0)->nodeValue : null;
+        return ($nodes->length) ? $nodes->item(0)->nodeValue : null;
     }
     /**
      * extract the first element of a dom node list and return a boolean
@@ -323,7 +321,7 @@ 
      */
     public function extractBoolValue(DOMNodeList $nodes)
     {
-        return $this->coreHelper->parseBool(($nodes->length)? $nodes->item(0)->nodeValue : null);
+        return $this->coreHelper->parseBool(($nodes->length) ? $nodes->item(0)->nodeValue : null);
     }
     /**
      * extract the first element of a dom node list and return the string value cast as integer value
@@ -332,7 +330,7 @@ 
      */
     public function extractIntValue(DOMNodeList $nodes)
     {
-        return ($nodes->length)? (int) $nodes->item(0)->nodeValue : 0;
+        return ($nodes->length) ? (int) $nodes->item(0)->nodeValue : 0;
     }
     /**
      * extract the first element of a dom node list and return the string value cast as float value
@@ -341,7 +339,7 @@ 
      */
     public function extractFloatValue(DOMNodeList $nodes)
     {
-        return ($nodes->length)? (float) $nodes->item(0)->nodeValue : 0;
+        return ($nodes->length) ? (float) $nodes->item(0)->nodeValue : 0;
     }
     /**
      * it return the pass in value parameter
@@ -425,7 +423,7 @@ 
             $product->setUseConfigGiftMessageAvailable(0);
             // Explicitly casting the extracted boolean value as an integer value because
             // Magento only work with integer value 0 or 1 representing boolean value in the database.
-            return (int) $this->coreHelper->parseBool(($nodes->length)? $nodes->item(0)->nodeValue : null);
+            return (int) $this->coreHelper->parseBool(($nodes->length) ? $nodes->item(0)->nodeValue : null);
         }
         return null;
     }

src/app/code/community/EbayEnterprise/Catalog/Helper/Map/Attribute.php

Spacing +2 added lines, -2 removed lines

@@ -65,7 +65,7 @@ 
     protected function _getAttributeIdByName($name)
     {
         $attribute = $this->_getAttributeCollection()->getItemByColumnValue('attribute_code', $name);
-        return ($attribute)? $attribute->getId() : null;
+        return ($attribute) ? $attribute->getId() : null;
     }
 
     /**
@@ -140,7 +140,7 @@ 
     {
         /** @var Mage_Eav_Model_Entity_Attribute_Option */
         $option = $this->_getAttributeOptionModel($attributeCode, $optionValue);
-        return (!is_null($option))? (int) $option->getOptionId() : 0;
+        return (!is_null($option)) ? (int) $option->getOptionId() : 0;
     }
 
     /**

src/app/code/community/EbayEnterprise/Catalog/Helper/Map/Category.php

Spacing +2 added lines, -2 removed lines

@@ -72,7 +72,7 @@ 
     {
         return array_filter(
             array_map(array($this, '_mapNamePathToId'), $this->_convertNodesToDashNames($nodes)),
-            function ($id) {
+            function($id) {
                 // Strip elements where the path was not found.
                 // @see _mapNamePathToId
                 return $id !== -1;
@@ -115,7 +115,7 @@ 
             $ids = array_reverse($catColl->getAllIds());
             $names = array_reverse($catColl->getColumnValues('name'));
             $this->_namePathToIdMap = array_combine(
-                array_map(function ($path) use ($ids, $names) {
+                array_map(function($path) use ($ids, $names) {
                     // replace each id in a path with the category name for that
                     // category id, and replace slashes with dashes.
                     return strtr(str_replace($ids, $names, $path), '/', '-');