eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Eb2cCore/Test/Helper/ShippingTest.php

Doc Comments +2 added lines, -1 removed lines

@@ -121,7 +121,8 @@
      *
      * @param string
      * @param array $methods shipping method array
-     * @return Mage_Shipping_Model_Carrier_Abstract
+     * @param string $title
+     * @return PHPUnit_Framework_MockObject_MockObject
      */
     protected function mockCarrier($title, $methods = null)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Test/Model/SessionTest.php

Doc Comments +2 added lines, -1 removed lines

@@ -33,7 +33,8 @@
      * @param  int     $qty       Qty of the item in the cart
      * @param  bool $isVirtual Is the item virtual
      * @param  int
-     * @return Mage_Sales_Model_Quote_Item The stub quote item
+     * @param integer $itemId
+     * @return EcomDev_PHPUnit_Mock_Proxy The stub quote item
      */
     protected function _stubQuoteItem($sku, $qty, $isVirtual, $itemId)
     {

Indentation +13 added lines, -13 removed lines

@@ -1,17 +1,17 @@ 
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Eb2cCore_Test_Model_SessionTest extends EbayEnterprise_Eb2cCore_Test_Base
 {
@@ -50,7 +50,7 @@ 
             ->expects($this->any())
             ->method('getIsVirtual')
             ->will($this->returnValue($isVirtual));
-         $item
+            $item
             ->expects($this->any())
             ->method('getId')
             ->will($this->returnValue($itemId));

Spacing +17 added lines, -17 removed lines

@@ -552,11 +552,11 @@ 
 
         return [
             //    old     new   bill       coupon       shipping   items      amounts       final
-            [$old,   $new, $billDiff, $empty,      $empty,    $empty,    $empty,       $billDiff],
-            [$old,   $new, $billDiff, $couponDiff, $empty,    $empty,    $empty,       $billDiff + $couponDiff],
-            [$old,   $new, $empty,    $couponDiff, $shipDiff, $empty,    $empty,       $couponDiff + $shipDiff],
-            [$old,   $new, $billDiff, $couponDiff, $shipDiff, $itemDiff, $empty,       $billDiff + $couponDiff + $shipDiff + $itemDiff],
-            [$old,   $new, $billDiff, $couponDiff, $shipDiff, $itemDiff, $amountsDiff, $billDiff + $couponDiff + $shipDiff + $itemDiff + $amountsDiff],
+            [$old, $new, $billDiff, $empty, $empty, $empty, $empty, $billDiff],
+            [$old, $new, $billDiff, $couponDiff, $empty, $empty, $empty, $billDiff + $couponDiff],
+            [$old, $new, $empty, $couponDiff, $shipDiff, $empty, $empty, $couponDiff + $shipDiff],
+            [$old, $new, $billDiff, $couponDiff, $shipDiff, $itemDiff, $empty, $billDiff + $couponDiff + $shipDiff + $itemDiff],
+            [$old, $new, $billDiff, $couponDiff, $shipDiff, $itemDiff, $amountsDiff, $billDiff + $couponDiff + $shipDiff + $itemDiff + $amountsDiff],
         ];
     }
     /**
@@ -693,9 +693,9 @@ 
     {
         return [
             //    currFlag newFlag
-            [true,    false],
-            [false,   true],
-            [false,   false],
+            [true, false],
+            [false, true],
+            [false, false],
         ];
     }
     /**
@@ -856,14 +856,14 @@ 
 
         return [
             // quoteData diff        has virtual hasManaged tax    deets
-            [$quoteData, $coupon,    false,      true,      true,   false],
-            [$quoteData, $billing,   false,      true,      false,  false],
-            [$quoteData, $billing,   true,       true,      true,   false],
-            [$quoteData, $shipping,  false,      true,      true,    true],
-            [$quoteData, $shipping,  false,      false,     true,   false],
-            [$quoteData, $managed,   false,      true,      true,    true],
-            [$quoteData, $noManaged, true,       false,     true,   false],
-            [$quoteData, $amount,    false,      false,     true,   false],
+            [$quoteData, $coupon, false, true, true, false],
+            [$quoteData, $billing, false, true, false, false],
+            [$quoteData, $billing, true, true, true, false],
+            [$quoteData, $shipping, false, true, true, true],
+            [$quoteData, $shipping, false, false, true, false],
+            [$quoteData, $managed, false, true, true, true],
+            [$quoteData, $noManaged, true, false, true, false],
+            [$quoteData, $amount, false, false, true, false],
         ];
     }
     /**
@@ -967,7 +967,7 @@ 
                 // the same. skus should match data extracted from the quote.
                 // last_updated should have been updated to the current time - best
                 // test I can think of for that is just making sure the new time is more recent that the old one
-                function ($quoteData) use ($oldData, $skuDataExtract) {
+                function($quoteData) use ($oldData, $skuDataExtract) {
                     return $quoteData['billing'] === $oldData['billing'] &&
                         $quoteData['coupon'] === $oldData['coupon'] &&
                         $quoteData['shipping'] === $oldData['shipping'] &&

src/app/code/community/EbayEnterprise/Eb2cCustomerService/Overrides/Model/Admin/Session.php

Doc Comments +1 added lines, -1 removed lines

@@ -196,7 +196,7 @@
      * user object.
      * @param  Mage_Admin_Model_User $user
      * @param  Mage_Core_Controller_Request_Http $request
-     * @param  Mage_Core_Exception $authException
+     * @param  EbayEnterprise_Eb2cCustomerService_Exception_Authentication $authException
      * @return null
      * @codeCoverageIgnore All side-effects taken from Magento auth/login process
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

Braces +1 added lines, -2 removed lines

@@ -59,8 +59,7 @@
         Mage_Sales_Model_Order $order,
         $shipmentId,
         $trackingNumber=null
-    )
-    {
+    ) {
         return func_get_args();
     }
 

src/app/code/community/EbayEnterprise/Eb2cFraud/Helper/Http.php

Doc Comments +2 added lines, -1 removed lines

@@ -45,6 +45,7 @@ 
      * @param  string
      * @param  array
      * @param  mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce($key, array $ar, $default)
@@ -55,7 +56,7 @@ 
     /**
      * ensure correct types
      * @param Mage_Core_Model_Cookie
-     * @return array
+     * @return Mage_Core_Model_Cookie[]
      */
     protected function _checkTypes(Mage_Core_Model_Cookie $cookie)
     {

Spacing +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
     public function getCookiesString()
     {
         $cookies = $this->_cookie->get();
-        return implode(self::COOKIES_DELIMITER, array_map(function ($key, $value) {
+        return implode(self::COOKIES_DELIMITER, array_map(function($key, $value) {
             return "$key=$value";
         }, array_keys($cookies), $cookies));
     }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cFraud/Model/Order/Create/Context.php

Doc Comments +2 added lines, -1 removed lines

@@ -47,7 +47,7 @@ 
      * @param  EbayEnterprise_Eb2cFraud_Helper_Http
      * @param  EbayEnterprise_Eb2cCore_Helper_Data
      * @param  Mage_Core_Model_Cookie
-     * @return array
+     * @return Mage_Core_Model_Cookie[]
      */
     protected function _checkTypes(
         EbayEnterprise_Eb2cFraud_Helper_Data $helper,
@@ -63,6 +63,7 @@ 
      * @param  string
      * @param  array
      * @param  mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce($key, array $ar, $default)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/GiftCard/Helper/Tendertype.php

Doc Comments +5 added lines

@@ -56,6 +56,9 @@ 
         return func_get_args();
     }
 
+    /**
+     * @param string $key
+     */
     protected function nullCoalesce(array $arr, $key, $default)
     {
         return isset($arr[$key]) ? $arr[$key] : $default;
@@ -66,6 +69,8 @@ 
      * @param string
      * @param string
      * @param bool
+     * @param string $cardNumber
+     * @param null|string $currencyCode
      * @return string
      * @throws EbayEnterprise_GiftCard_Exception_InvalidCardNumber_Exception If card number cannot be retrieved.
      */

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
      * @return string
      * @throws EbayEnterprise_GiftCard_Exception_InvalidCardNumber_Exception If card number cannot be retrieved.
      */
-    public function lookupTenderType($cardNumber, $currencyCode, $panIsToken=false)
+    public function lookupTenderType($cardNumber, $currencyCode, $panIsToken = false)
     {
         try {
             $api = $this->getTenderTypeLookupApi();

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,10 +13,10 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedHttpAction;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedOperation;
+use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
 
 class EbayEnterprise_Inventory_Model_Allocation_Deallocator

src/app/code/community/EbayEnterprise/GiftCard/Model/Adminhtml/Observer.php

Doc Comments +1 added lines, -1 removed lines

@@ -119,7 +119,7 @@
     }
     /**
      * Get post data from the request. If not set, return the default value.
-     * @param string|int $field
+     * @param string $field
      * @param string $default
      * @return string
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/GiftCard/Model/Container.php

Doc Comments +3 added lines, -3 removed lines

@@ -58,9 +58,9 @@
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param  array $arr
-     * @param  string|int $field Valid array key
-     * @param  mixed $default
-     * @return mixed
+     * @param  string $field Valid array key
+     * @param  SplObjectStorage|null $default
+     * @return SplObjectStorage|null
      */
     protected function nullCoalesce(array $arr, $field, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/GiftCard/Model/Giftcard.php

Doc Comments +3 added lines, -2 removed lines

@@ -129,7 +129,7 @@ 
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param  array      $arr
-     * @param  string|int $field Valid array key
+     * @param  string $field Valid array key
      * @param  mixed      $default
      * @return mixed
      */
@@ -370,7 +370,6 @@ 
      * Log the different requests consistently.
      *
      * @param string $type 'balance', 'redeem', 'void'
-     * @param string $body the serialized xml body
      * @param string $direction 'request' or 'response'
      */
     protected function logApiCall($type, $direction)
@@ -665,6 +664,8 @@ 
      * @param IBidirectionalApi
      * @param bool
      * @param string
+     * @param boolean $isRequest
+     * @param string $logMessage
      */
     protected function logStoredValuePayload(IBidirectionalApi $api, $isRequest, $logMessage)
     {

Unused Use Statements +3 added lines, -3 removed lines

@@ -13,14 +13,14 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
+use Psr\Log\LoggerInterface;
+use Psr\Log\NullLogger;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedHttpAction;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedOperation;
+use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Payload;
 use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
-use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 /**
  * Model representing a gift card that has been applied to an order.

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {