eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Amqp/Test/Model/Adminhtml/System/Config/Backend/LasttestmessageTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     /**
      * Test getting the last saved test message timestamp to be displayed in the
      * admin.
-     * @param string|null $timestamp
+     * @param string|null $lastTimestamp
      * @param string $value
      * @dataProvider provideLastTimestamp
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Helper/Data.php

Doc Comments +3 added lines, -1 removed lines

@@ -63,6 +63,7 @@ 
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce(array $arr, $key, $default)
@@ -159,7 +160,7 @@ 
     /**
      * Get the base url for a given store
      *
-     * @param $storeId
+     * @param integer $storeId
      * @return string the store base url
      */
     public function getStoreUrl($storeId)
@@ -717,6 +718,7 @@ 
      *
      * @param string
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function reregister($key, $value=null)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

Spacing +5 added lines, -5 removed lines

@@ -370,8 +370,8 @@ 
      */
     public function mapPattern(array $keyMap, $pattern)
     {
-        return array_reduce(array_keys($keyMap), function ($result, $key) use ($keyMap, $pattern) {
-            $result = (trim($result) === '')? $pattern : $result;
+        return array_reduce(array_keys($keyMap), function($result, $key) use ($keyMap, $pattern) {
+            $result = (trim($result) === '') ? $pattern : $result;
             return str_replace(sprintf('{%s}', $key), $keyMap[$key], $result);
         });
     }
@@ -615,7 +615,7 @@ 
     {
         // Function to create hash of elements of a site filter that we care
         // about being unique.
-        $hashSite = function ($site) {
+        $hashSite = function($site) {
             return sprintf(
                 '%s|%s|%s|%s',
                 $site['catalog_id'], $site['client_id'], $site['store_id'], $site['lang_code']
@@ -702,7 +702,7 @@ 
      */
     public function denormalizeSku($itemId, $catalogId)
     {
-        return (!empty($itemId) && strpos($itemId, $catalogId . '-') === 0)?
+        return (!empty($itemId) && strpos($itemId, $catalogId . '-') === 0) ?
             str_replace($catalogId . '-', '', $itemId) : $itemId;
     }
 
@@ -780,7 +780,7 @@ 
      * @param mixed
      * @return mixed
      */
-    protected function reregister($key, $value=null)
+    protected function reregister($key, $value = null)
     {
         $old = Mage::registry($key);
         Mage::unregister($key);

src/app/code/community/EbayEnterprise/Catalog/Helper/Itemmaster.php

Doc Comments +11 added lines, -11 removed lines

@@ -89,7 +89,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMDocumentFragment|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passStyle($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -177,7 +177,7 @@ 
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument             $doc
      * @throws EbayEnterprise_Catalog_Model_Pim_Product_Validation_Exception
-     * @return DOMNode|null
+     * @return DOMCdataSection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passTaxCode($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -195,7 +195,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return null|DOMDocumentFragment
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passUnitCost($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -231,7 +231,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMCdataSection|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passColorCode($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -247,7 +247,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMCdataSection|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passColorDescription($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -263,7 +263,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMDocumentFragment
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passItemURL($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -300,7 +300,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMDocumentFragment
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passGiftCard($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -324,7 +324,7 @@ 
      * @param  string
      * @param  Mage_Catalog_Model_Product
      * @param  DOMDocument
-     * @return DOMNode|null
+     * @return DOMCdataSection|null
      */
     public function passDropShipSupplierPrefix($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
     {
@@ -337,7 +337,7 @@ 
      * @param  string
      * @param  Mage_Catalog_Model_Product
      * @param  DOMDocument
-     * @return DOMNode|null
+     * @return DOMCdataSection|null
      */
     public function passSupplierPartNumber($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
     {
@@ -353,7 +353,7 @@ 
      * @param  string
      * @param  Mage_Catalog_Model_Product
      * @param  DOMDocument
-     * @return DOMNode|null
+     * @return DOMCdataSection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passSubscriptionEligible($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -370,7 +370,7 @@ 
      * @param  string
      * @param  Mage_Catalog_Model_Product
      * @param  DOMDocument
-     * @return DOMNode|null
+     * @return DOMCdataSection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passSubscriptionType($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)

Spacing +2 added lines, -3 removed lines

@@ -116,7 +116,7 @@ 
      */
     public function passSubClass($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
     {
-        $value = (int)0;
+        $value = (int) 0;
         if (!empty($attrValue)) {
             $value = $attrValue;
         }
@@ -287,8 +287,7 @@ 
      */
     public function passSalesClass($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
     {
-        $enum = empty($attrValue) ? 'stock' :
-            Mage::getSingleton('eav/entity_attribute')
+        $enum = empty($attrValue) ? 'stock' : Mage::getSingleton('eav/entity_attribute')
                 ->loadByCode($product::ENTITY, $attribute)
                 ->getSource()->getOptionText($attrValue);
         return $this->passString($enum, $attribute, $product, $doc);

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Helper/Map.php

Doc Comments +1 added lines, -1 removed lines

@@ -346,7 +346,7 @@
     /**
      * it return the pass in value parameter
      * it's a callback to return static value set in the config
-     * @param mixed $value
+     * @param string $value
      * @return mixed
      */
     public function passThrough($value)

Spacing +11 added lines, -13 removed lines

@@ -99,9 +99,8 @@ 
      */
     public function extractStatusValue(DOMNodeList $nodes)
     {
-        return ($nodes->length && strtolower($nodes->item(0)->nodeValue) === 'active')?
-            Mage_Catalog_Model_Product_Status::STATUS_ENABLED:
-            Mage_Catalog_Model_Product_Status::STATUS_DISABLED;
+        return ($nodes->length && strtolower($nodes->item(0)->nodeValue) === 'active') ?
+            Mage_Catalog_Model_Product_Status::STATUS_ENABLED : Mage_Catalog_Model_Product_Status::STATUS_DISABLED;
     }
     /**
      * extracts visibility from node list, returning an expected integer or translating an expected string
@@ -142,7 +141,7 @@ 
     public function extractProductTypeValue(DOMNodeList $nodes, Mage_Catalog_Model_Product $product)
     {
         $value = strtolower($this->coreHelper->extractNodeVal($nodes));
-        $type = ($this->_isValidProductType($value))? $value : Mage_Catalog_Model_Product_Type::TYPE_SIMPLE;
+        $type = ($this->_isValidProductType($value)) ? $value : Mage_Catalog_Model_Product_Type::TYPE_SIMPLE;
         $product->setTypeId($type)
             ->setTypeInstance(Mage_Catalog_Model_Product_Type::factory($product, true), true);
         return $type;
@@ -232,9 +231,8 @@ 
     public function extractUrlKeyValue(DOMNodeList $nodes, Mage_Catalog_Model_Product $product)
     {
         $urlKey = $this->coreHelper->extractNodeVal($nodes);
-        return ($urlKey !== '')?
-            $urlKey . '-' . $product->getStoreId() :
-            'Incomplete Product: ' . $product->getSku() . '-' . $product->getStoreId();
+        return ($urlKey !== '') ?
+            $urlKey . '-' . $product->getStoreId() : 'Incomplete Product: ' . $product->getSku() . '-' . $product->getStoreId();
     }
     /**
      * given a gift card type return the gift card constant mapped to it
@@ -264,7 +262,7 @@ 
         $value = $this->coreHelper->extractNodeVal($nodes);
         $cfg = Mage::helper('ebayenterprise_catalog')->getConfigModel();
         $mapData = $cfg->getConfigData(EbayEnterprise_Catalog_Helper_Feed::GIFTCARD_TENDER_CONFIG_PATH);
-        return isset($mapData[$value])? $this->_getGiftCardType($mapData[$value]) : null;
+        return isset($mapData[$value]) ? $this->_getGiftCardType($mapData[$value]) : null;
     }
 
     /**
@@ -313,7 +311,7 @@ 
      */
     public function extractStringValue(DOMNodeList $nodes)
     {
-        return ($nodes->length)? $nodes->item(0)->nodeValue : null;
+        return ($nodes->length) ? $nodes->item(0)->nodeValue : null;
     }
     /**
      * extract the first element of a dom node list and return a boolean
@@ -323,7 +321,7 @@ 
      */
     public function extractBoolValue(DOMNodeList $nodes)
     {
-        return $this->coreHelper->parseBool(($nodes->length)? $nodes->item(0)->nodeValue : null);
+        return $this->coreHelper->parseBool(($nodes->length) ? $nodes->item(0)->nodeValue : null);
     }
     /**
      * extract the first element of a dom node list and return the string value cast as integer value
@@ -332,7 +330,7 @@ 
      */
     public function extractIntValue(DOMNodeList $nodes)
     {
-        return ($nodes->length)? (int) $nodes->item(0)->nodeValue : 0;
+        return ($nodes->length) ? (int) $nodes->item(0)->nodeValue : 0;
     }
     /**
      * extract the first element of a dom node list and return the string value cast as float value
@@ -341,7 +339,7 @@ 
      */
     public function extractFloatValue(DOMNodeList $nodes)
     {
-        return ($nodes->length)? (float) $nodes->item(0)->nodeValue : 0;
+        return ($nodes->length) ? (float) $nodes->item(0)->nodeValue : 0;
     }
     /**
      * it return the pass in value parameter
@@ -425,7 +423,7 @@ 
             $product->setUseConfigGiftMessageAvailable(0);
             // Explicitly casting the extracted boolean value as an integer value because
             // Magento only work with integer value 0 or 1 representing boolean value in the database.
-            return (int) $this->coreHelper->parseBool(($nodes->length)? $nodes->item(0)->nodeValue : null);
+            return (int) $this->coreHelper->parseBool(($nodes->length) ? $nodes->item(0)->nodeValue : null);
         }
         return null;
     }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

Braces +1 added lines, -2 removed lines

@@ -59,8 +59,7 @@
         Mage_Sales_Model_Order $order,
         $shipmentId,
         $trackingNumber=null
-    )
-    {
+    ) {
         return func_get_args();
     }
 

src/app/code/community/EbayEnterprise/Catalog/Helper/Map/Attribute.php

Doc Comments +3 added lines, -1 removed lines

@@ -149,6 +149,8 @@ 
      *
      * @param  string
      * @param  string
+     * @param string $attributeCode
+     * @param string $optionValue
      * @return Mage_Eav_Model_Entity_Attribute_Option | null
      */
     protected function _getAttributeOptionModel($attributeCode, $optionValue)
@@ -395,7 +397,7 @@ 
      * Return empty array if there's no option id
      *
      * @param $attribute
-     * @param $attributeOptionId
+     * @param integer $attributeOptionId
      * @return array
      */
     protected function _getAllOptionValues($attribute, $attributeOptionId)

Spacing +2 added lines, -2 removed lines

@@ -65,7 +65,7 @@ 
     protected function _getAttributeIdByName($name)
     {
         $attribute = $this->_getAttributeCollection()->getItemByColumnValue('attribute_code', $name);
-        return ($attribute)? $attribute->getId() : null;
+        return ($attribute) ? $attribute->getId() : null;
     }
 
     /**
@@ -140,7 +140,7 @@ 
     {
         /** @var Mage_Eav_Model_Entity_Attribute_Option */
         $option = $this->_getAttributeOptionModel($attributeCode, $optionValue);
-        return (!is_null($option))? (int) $option->getOptionId() : 0;
+        return (!is_null($option)) ? (int) $option->getOptionId() : 0;
     }
 
     /**

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Helper/Map/Giftcard.php

Doc Comments +1 added lines, -1 removed lines

@@ -105,7 +105,7 @@
      * giftcard lifetime otherwise return the product lifetime value
      * @param DOMNodeList $nodes
      * @param Mage_Catalog_Model_Product $product
-     * @return mixed
+     * @return integer
      */
     public function extractLifetime(DOMNodeList $nodes, Mage_Catalog_Model_Product $product)
     {

Spacing +6 added lines, -9 removed lines

@@ -94,9 +94,8 @@ 
      */
     public function extractIsRedeemable(DOMNodeList $nodes, Mage_Catalog_Model_Product $product)
     {
-        return (!is_null($this->extractGiftcardTenderValue($nodes, $product)) && $product->getUseConfigIsRedeemable())?
-            Mage::helper('eb2ccore')->getStoreConfigFlag(Enterprise_GiftCard_Model_Giftcard::XML_PATH_IS_REDEEMABLE, $product->getStoreId()) :
-            (bool) $product->getIsRedeemable();
+        return (!is_null($this->extractGiftcardTenderValue($nodes, $product)) && $product->getUseConfigIsRedeemable()) ?
+            Mage::helper('eb2ccore')->getStoreConfigFlag(Enterprise_GiftCard_Model_Giftcard::XML_PATH_IS_REDEEMABLE, $product->getStoreId()) : (bool) $product->getIsRedeemable();
     }
 
     /**
@@ -109,9 +108,8 @@ 
      */
     public function extractLifetime(DOMNodeList $nodes, Mage_Catalog_Model_Product $product)
     {
-        return (!is_null($this->extractGiftcardTenderValue($nodes, $product)) && $product->getUseConfigLifetime())?
-            (int) Mage::helper('eb2ccore')->getStoreConfig(Enterprise_GiftCard_Model_Giftcard::XML_PATH_LIFETIME, $product->getStoreId()) :
-            (int) $product->getLifetime();
+        return (!is_null($this->extractGiftcardTenderValue($nodes, $product)) && $product->getUseConfigLifetime()) ?
+            (int) Mage::helper('eb2ccore')->getStoreConfig(Enterprise_GiftCard_Model_Giftcard::XML_PATH_LIFETIME, $product->getStoreId()) : (int) $product->getLifetime();
     }
 
     /**
@@ -125,8 +123,7 @@ 
      */
     public function extractEmailTemplate(DOMNodeList $nodes, Mage_Catalog_Model_Product $product)
     {
-        return (!is_null($this->extractGiftcardTenderValue($nodes, $product)) && $product->getUseConfigEmailTemplate())?
-            Mage::helper('eb2ccore')->getStoreConfig(Enterprise_GiftCard_Model_Giftcard::XML_PATH_EMAIL_TEMPLATE, $product->getStoreId()) :
-            $product->getEmailTemplate();
+        return (!is_null($this->extractGiftcardTenderValue($nodes, $product)) && $product->getUseConfigEmailTemplate()) ?
+            Mage::helper('eb2ccore')->getStoreConfig(Enterprise_GiftCard_Model_Giftcard::XML_PATH_EMAIL_TEMPLATE, $product->getStoreId()) : $product->getEmailTemplate();
     }
 }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Helper/Pim.php

Doc Comments +16 added lines, -16 removed lines

@@ -27,7 +27,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument             $doc
-     * @return DOMNode|null
+     * @return DOMDocumentFragment|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function getValueAsDefault($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -47,7 +47,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMCdataSection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passString($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -63,7 +63,7 @@ 
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument             $doc
      * @throws EbayEnterprise_Catalog_Model_Pim_Product_Validation_Exception
-     * @return DOMNode|null
+     * @return DOMCdataSection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passSKU($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -84,7 +84,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMCdataSection|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passStringIf($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -102,7 +102,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMText
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passPrice($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -117,7 +117,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMText
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passDecimal($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -132,7 +132,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMText
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passDate($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -148,7 +148,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMText
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passInteger($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -164,7 +164,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMText
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passYesNoToBool($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -292,7 +292,7 @@ 
     /**
      * given a string representing decimal value if the string is a numeric value cast it as float otherwise return null
      * @param string $value
-     * @return int | null
+     * @return double|null | null
      */
     public function createDecimal($value)
     {
@@ -357,7 +357,7 @@ 
      * @param  string                     $attribute
      * @param  Mage_Catalog_Model_Product $product
      * @param  DOMDocument                $doc
-     * @return mixed
+     * @return DOMCdataSection|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passStyleId($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -372,7 +372,7 @@ 
      * @param  string                     $attribute
      * @param  Mage_Catalog_Model_Product $product
      * @param  DOMDocument                $doc
-     * @return mixed
+     * @return null|DOMDocumentFragment
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passGiftCard($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -402,7 +402,7 @@ 
      * @param  string                     $attribute
      * @param  Mage_Catalog_Model_Product $product
      * @param  DOMDocument                $doc
-     * @return mixed
+     * @return DOMDocumentFragment|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passProductLinks($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -457,7 +457,7 @@ 
      * @param  string                     $attribute
      * @param  Mage_Catalog_Model_Product $product
      * @param  DOMDocument                $doc
-     * @return mixed
+     * @return DOMDocumentFragment|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passCategoryLinks($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -487,7 +487,7 @@ 
      * @param  string                     $attribute
      * @param  Mage_Catalog_Model_Product $product
      * @param  DOMDocument                $doc
-     * @return mixed
+     * @return DOMCdataSection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passGiftWrap($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
@@ -504,7 +504,7 @@ 
      * @param  string                              $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  DOMDocument         $doc
-     * @return DOMNode|null
+     * @return DOMCdataSection|null
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function passIsoCountryCode($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)

Spacing +9 added lines, -12 removed lines

@@ -203,8 +203,7 @@ 
         $domAttribute = $this->_getDomAttr($doc, $attribute);
         $lastRunTime = Mage::helper('ebayenterprise_catalog')->getConfigModel()->pimExportFeedCutoffDate;
         $domAttribute->value = strtotime($product->getCreatedAt()) > strtotime($lastRunTime) ?
-            static::NEW_PRODUCT_OPERATION_TYPE :
-            static::DEFAULT_OPERATION_TYPE;
+            static::NEW_PRODUCT_OPERATION_TYPE : static::DEFAULT_OPERATION_TYPE;
         return $domAttribute;
     }
     /**
@@ -278,7 +277,7 @@ 
      */
     public function createDateTime($value)
     {
-        return !empty($value)? date('c', strtotime($value)) : null;
+        return !empty($value) ? date('c', strtotime($value)) : null;
     }
     /**
      * given a string representing integer value if the string is a numeric value cast it as integer otherwise return null
@@ -287,7 +286,7 @@ 
      */
     public function createInteger($value)
     {
-        return is_numeric($value)? (int) $value : null;
+        return is_numeric($value) ? (int) $value : null;
     }
     /**
      * given a string representing decimal value if the string is a numeric value cast it as float otherwise return null
@@ -296,7 +295,7 @@ 
      */
     public function createDecimal($value)
     {
-        return is_numeric($value)? (float) $value : null;
+        return is_numeric($value) ? (float) $value : null;
     }
     /**
      * given a string if it is '1' return 'true' otherwise 'false'
@@ -305,7 +304,7 @@ 
      */
     public function createBool($value)
     {
-        return ($value === '1')? 'true' : 'false';
+        return ($value === '1') ? 'true' : 'false';
     }
     /**
      * For a given product, look for a configurable product using that product.
@@ -382,11 +381,9 @@ 
         }
         $cfg = Mage::helper('ebayenterprise_catalog')->getConfigModel();
         $allowMessage = $product->getUseConfigAllowMessage() ?
-            $cfg->getConfigData(Enterprise_GiftCard_Model_Giftcard::XML_PATH_ALLOW_MESSAGE) :
-            $product->getAllowMessage();
+            $cfg->getConfigData(Enterprise_GiftCard_Model_Giftcard::XML_PATH_ALLOW_MESSAGE) : $product->getAllowMessage();
         $MessageMaxLength = $allowMessage ?
-            (int) $cfg->getConfigData(Enterprise_GiftCard_Model_Giftcard::XML_PATH_MESSAGE_MAX_LENGTH) :
-            0;
+            (int) $cfg->getConfigData(Enterprise_GiftCard_Model_Giftcard::XML_PATH_MESSAGE_MAX_LENGTH) : 0;
         $isDigital = $product->getGiftCardType() === Enterprise_GiftCard_Model_Giftcard::TYPE_VIRTUAL ? 'true' : 'false';
         $namespaceUri = $doc->documentElement->namespaceURI;
         $frag = $doc->createDocumentFragment();
@@ -468,7 +465,7 @@ 
             ->addAttributeToSelect('name');
         foreach ($categories as $category) {
             $pathArr = explode('/', $category->getPath());
-            array_walk($pathArr, function (&$val) use ($all) {
+            array_walk($pathArr, function(&$val) use ($all) {
                 $part = $all->getItemById((int) $val);
                 $val = $part ? $part->getName() : null;
             });
@@ -510,6 +507,6 @@ 
     public function passIsoCountryCode($attrValue, $attribute, Mage_Catalog_Model_Product $product, DOMDocument $doc)
     {
         return Mage::helper('ebayenterprise_catalog')->isValidIsoCountryCode($attrValue) ?
-            $this->passString($attrValue, $attribute, $product, $doc): null;
+            $this->passString($attrValue, $attribute, $product, $doc) : null;
     }
 }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Interface/Feed.php

Doc Comments +1 added lines

@@ -20,6 +20,7 @@
 {
     /**
      * The point of entry to start process a feed.
+     * @return integer
      */
     public function processFeeds();
 }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Model/Error/Confirmations.php

Doc Comments +6 added lines

@@ -190,6 +190,8 @@ 
 
     /**
      * @see EbayEnterprise_Catalog_Model_Error_IConfirmations::addMessage()
+     * @param string $msgTemplate
+     * @param string $message
      */
     public function addMessage($msgTemplate, $message)
     {
@@ -205,6 +207,8 @@ 
 
     /**
      * @see EbayEnterprise_Catalog_Model_Error_IConfirmations::addError()
+     * @param string $type
+     * @param string $fileName
      */
     public function addError($type, $fileName)
     {
@@ -221,6 +225,7 @@ 
 
     /**
      * @see EbayEnterprise_Catalog_Model_Error_IConfirmations::addErrorConfirmation()
+     * @param string $sku
      */
     public function addErrorConfirmation($sku)
     {
@@ -389,6 +394,7 @@ 
      * @param  array list of SKUs that were suppose to be imported
      * @param  string the file the sku was found on
      * @param  string the event type
+     * @param string $fileName
      * @return self
      */
     protected function addImportErrors(

Spacing +2 added lines, -3 removed lines

@@ -355,9 +355,8 @@
 
         $this->loadFile($errorFile);
 
-        return ($operationType === 'delete')?
-            $this->addDeleteErrors($collection, $fileName, $type) :
-            $this->addImportErrors($collection, $skus, $fileName, $type);
+        return ($operationType === 'delete') ?
+            $this->addDeleteErrors($collection, $fileName, $type) : $this->addImportErrors($collection, $skus, $fileName, $type);
     }
 
     /**

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {