eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Order/Overrides/Block/Order/Recent.php

Doc Comments +2 added lines

@@ -47,6 +47,7 @@ 
     /**
      * Returns URL for view a specific order id.
      * @param  string
+     * @param string $orderId
      * @return string
      */
     public function getViewUrl($orderId)
@@ -58,6 +59,7 @@ 
      * Returns URL to cancel an order.
      *
      * @param  string
+     * @param string $orderId
      * @return string
      */
     public function getCancelUrl($orderId)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Overrides/Model/Enterprise/Rma.php

Doc Comments +2 added lines, -2 removed lines

@@ -47,7 +47,7 @@ 
      * Type hinting for self::__construct $initParams
      *
      * @param  EbayEnterprise_Eb2cCore_Model_Config_Registry
-     * @return array
+     * @return EbayEnterprise_Eb2cCore_Model_Config_Registry[]
      */
     protected function _checkTypes(EbayEnterprise_Eb2cCore_Model_Config_Registry $config)
     {
@@ -60,7 +60,7 @@ 
      * @param  array
      * @param  string $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @return EbayEnterprise_Eb2cCore_Model_Config_Registry
      */
     protected function _nullCoalesce(array $arr, $field, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Test/Block/Order/CancelTest.php

Doc Comments +1 added lines

@@ -19,6 +19,7 @@
      * Create a block instance
      *
      * @param string
+     * @param string $class
      * @return Mage_Core_Block_Abstract
      */
     protected function _createBlock($class)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Test/Helper/DataTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -209,7 +209,7 @@
     /**
      * Test getting the current user id, prefixed by the configured client
      * customer id prefix.
-     * @param string|null $customer Customer retrieved from the session
+     * @param string|null $customerId Customer retrieved from the session
      * @param string $prefix Client customer id prefix
      * @param string|null $prefixedId prefixed customer id
      * @param int $length customer id padding length using zeros

Indentation +14 added lines, -14 removed lines

@@ -1,17 +1,17 @@ 
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Order_Test_Helper_DataTest extends EbayEnterprise_Eb2cCore_Test_Base
 {
@@ -352,8 +352,8 @@ 
     }
 
         /**
-     * Test removing the order increment id prefix.
-     */
+         * Test removing the order increment id prefix.
+         */
     public function testRemoveOrderIncrementPrefix()
     {
         $admin = Mage::getModel('core/store', ['store_id' => 0]);

src/app/code/community/EbayEnterprise/Order/Test/Helper/Item/SelectionTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
      *
      * @param string
      * @param Mage_Sales_Model_Order_Item|null
-     * @return Mage_Sales_Model_Order_Item
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
         protected function _mockItem($productType = null, Mage_Sales_Model_Order_Item $parentItem = null)
         {

Indentation +31 added lines, -31 removed lines

@@ -1,17 +1,17 @@ 
 	<?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
     class EbayEnterprise_Order_Test_Helper_Item_SelectionTest extends EcomDev_PHPUnit_Test_Case
     {
@@ -24,13 +24,13 @@ 
         }
 
         /**
-     * Create a quote item stubbed to return the given product type, parent
-     * item and quote item.
-     *
-     * @param string
-     * @param Mage_Sales_Model_Order_Item|null
-     * @return Mage_Sales_Model_Order_Item
-     */
+         * Create a quote item stubbed to return the given product type, parent
+         * item and quote item.
+         *
+         * @param string
+         * @param Mage_Sales_Model_Order_Item|null
+         * @return Mage_Sales_Model_Order_Item
+         */
         protected function _mockItem($productType = null, Mage_Sales_Model_Order_Item $parentItem = null)
         {
             $item = $this->getModelMock(
@@ -47,8 +47,8 @@ 
         }
 
         /**
-     * When selecting form only simple items, no items should be filtered out.
-     */
+         * When selecting form only simple items, no items should be filtered out.
+         */
         public function testSelectFromSimpleProducts()
         {
             $item = $this->_mockItem(Mage_Catalog_Model_Product_Type::TYPE_SIMPLE);
@@ -58,9 +58,9 @@ 
         }
 
         /**
-     * When selecting form a list with configurable items - parent config and
-     * simple child, only the parent item should be returned in the array of items.
-     */
+         * When selecting form a list with configurable items - parent config and
+         * simple child, only the parent item should be returned in the array of items.
+         */
         public function testSelectFromConfigurableProducts()
         {
             $parentItem = $this->_mockItem(Mage_Catalog_Model_Product_Type::TYPE_CONFIGURABLE);
@@ -71,10 +71,10 @@ 
         }
 
         /**
-     * When selecting form a list with bundle items - parent bundle and simple
-     * child - both parent and child items should be returned in the array of
-     * selected items.
-     */
+         * When selecting form a list with bundle items - parent bundle and simple
+         * child - both parent and child items should be returned in the array of
+         * selected items.
+         */
         public function testSelectFromBundleProducts()
         {
             $parentItem = $this->_mockItem(Mage_Catalog_Model_Product_Type::TYPE_BUNDLE);
@@ -85,9 +85,9 @@ 
         }
 
         /**
-     * When filtering from a list with a grouped item, the grouped item item,
-     * which will simply be one of the items added by the group, should be included.
-     */
+         * When filtering from a list with a grouped item, the grouped item item,
+         * which will simply be one of the items added by the group, should be included.
+         */
         public function testSelectFromGroupedProducts()
         {
             $groupedItem = $this->_mockItem(Mage_Catalog_Model_Product_Type::TYPE_GROUPED);

src/app/code/community/EbayEnterprise/Order/Test/Model/Cancel/Build/RequestTest.php

Unused Use Statements -3 removed lines

@@ -13,9 +13,6 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Payload\Order\OrderCancelRequest;
-use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
-
 class EbayEnterprise_Order_Test_Model_Cancel_Build_RequestTest extends EbayEnterprise_Eb2cCore_Test_Base
 {
     const API_CLASS = '\eBayEnterprise\RetailOrderManagement\Api\HttpApi';

Spacing +2 added lines, -2 removed lines

@@ -174,7 +174,7 @@ 
             // This key is required
             'order' => $order,
         ]]);
-        $buildRequest->expects($order->getCancelReasonCode()? $this->never() : $this->once())
+        $buildRequest->expects($order->getCancelReasonCode() ? $this->never() : $this->once())
             // When the varien magic method sales/order::getCancelReasonCode() return
             // a non-empty string value then this method will never be called, otherwise
             // we expect it to be invoked once.
@@ -218,7 +218,7 @@ 
 
         $code = $order->getCancelReasonCode();
         $orderHelper = $this->getHelperMock('ebayenterprise_order/data', ['getCancelReasonDescription']);
-        $orderHelper->expects($code? $this->once() : $this->never())
+        $orderHelper->expects($code ? $this->once() : $this->never())
             // When the varien magic method sales/order::getCancelReasonCode() return
             // a non-empty string value we expect this method to be called once, otherwise
             // it will never be called.

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Test/Model/Create/RelationshipsTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,8 +13,8 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderItem;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IItemRelationship;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderItem;
 
 /**
  * keeps track of relationship payloads

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Test/Model/CreateTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,8 +13,8 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
 use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
+use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
 
 /**
  * Test Order Create

Spacing +3 added lines, -4 removed lines

@@ -83,7 +83,7 @@ 
         $this->_requestStub = $this->getMock('\eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderCreateRequest');
         $this->_replyStub = $this->getMock('\eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderCreateReply');
         $this->_coreHelperStub = $this->getHelperMock('eb2ccore/data', ['generateRequestId', 'getConfigModel']);
-        $coreConfig = $this->buildCoreConfigRegistry(['clientCustomerIdPrefix' => $this->_clientCustomerIdPrefix, 'language_code' => 'en-us', 'clientCustomerIdLength' => 0,]);
+        $coreConfig = $this->buildCoreConfigRegistry(['clientCustomerIdPrefix' => $this->_clientCustomerIdPrefix, 'language_code' => 'en-us', 'clientCustomerIdLength' => 0, ]);
         $this->_coreHelperStub->expects($this->any())
             ->method('getConfigModel')
             ->will($this->returnValue($coreConfig));
@@ -107,7 +107,7 @@ 
         $this->_orderHelperStub
             ->method('prefixCustomerId')
             ->will($this->returnCallback(
-                function ($id) use ($clientCustomerIdPrefix) {
+                function($id) use ($clientCustomerIdPrefix) {
                     return $clientCustomerIdPrefix . $id;
                 }
             ));
@@ -261,8 +261,7 @@ 
             [$address, $this->_request->getDestinations()]
         );
         $expectedType = $address->getAddressType() === 'billing' ?
-            '\eBayEnterprise\RetailOrderManagement\Payload\Order\IEmailAddressDestination' :
-            '\eBayEnterprise\RetailOrderManagement\Payload\Order\IMailingAddress';
+            '\eBayEnterprise\RetailOrderManagement\Payload\Order\IEmailAddressDestination' : '\eBayEnterprise\RetailOrderManagement\Payload\Order\IMailingAddress';
         $this->assertInstanceOf($expectedType, $destination);
     }
 

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Test/Model/CreditissuedTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
      * @param string $name
      * @param $object
      * @param string $property
-     * @param $value
+     * @param EcomDev_PHPUnit_Mock_Proxy $value
      */
     protected function _injectProtectedProperty($name, $object, $property, $value)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {