eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Multishipping/Override/Model/Sales/Order/Address.php

Doc Comments +2 added lines

@@ -110,6 +110,7 @@ 
      * Retrieve item object by quote item Id
      *
      * @param int
+     * @param integer $itemId
      * @return Mage_Sales_Model_Orders_Item
      */
     public function getItemByQuoteItemId($itemId)
@@ -121,6 +122,7 @@ 
      * Remove item from collection
      *
      * @param int
+     * @param integer $itemId
      * @return self
      */
     public function removeItem($itemId)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2015 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2015 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 /** @var Mage_Sales_Model_Resource_Setup */
 $installer = $this;

src/app/code/community/EbayEnterprise/Multishipping/Test/Helper/FactoryTest.php

Doc Comments +3 added lines, -1 removed lines

@@ -29,7 +29,9 @@
      * @param bool
      * @param int
      * @param string
-     * @return Mage_Sales_Model_Order_Address
+     * @param integer $addressId
+     * @param integer $orderId
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function _stubAddress($addressId, $isPrimaryShipping, $orderId, $addressType)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Multishipping/Test/Model/Override/Sales/Order/AddressTest.php

Doc Comments +2 added lines

@@ -34,6 +34,8 @@
      *
      * @param int
      * @param int
+     * @param integer $addressId
+     * @param integer $orderId
      * @return EbayEnterprise_Multishipping_Override_Model_Sales_Order_Address
      */
     protected function _getPrimaryShippingAddress($addressId, $orderId)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Multishipping/Test/Model/Override/Sales/Service/QuoteTest.php

Doc Comments +4 added lines, -3 removed lines

@@ -119,7 +119,7 @@ 
      * Create a stub order address with the provided address type.
      *
      * @param string
-     * @return Mage_Sales_Model_Order_Address
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function _stubOrderAddress($type)
     {
@@ -133,7 +133,7 @@ 
      *
      * @param string
      * @param Mage_Sales_Model_Quote_Item_Abstract[]
-     * @return Mage_Sales_Model_Quote_Address
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function _stubQuoteAddress($type, array $items = [])
     {
@@ -149,7 +149,8 @@ 
      *
      * @param string|null
      * @param Mage_Sales_Model_Quote_Item_Abstract|null
-     * @return Mage_Sales_Model_Quote_Item_Abstract
+     * @param string $productType
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function _stubQuoteItem(
         $productType = null,

Spacing +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
 
         $this->_checkoutDispatcher = $this->getHelperMock(
             'ebayenterprise_multishipping/dispatcher_interface',
-            ['dispatchBeforeOrderSubmit', 'dispatchOrderSubmitSuccess', 'dispatchOrderSubmitFailure', 'dispatchAfterOrderSubmit',],
+            ['dispatchBeforeOrderSubmit', 'dispatchOrderSubmitSuccess', 'dispatchOrderSubmitFailure', 'dispatchAfterOrderSubmit', ],
             true
         );
         $this->_multishippingFactory = $this->getHelperMock(
@@ -64,7 +64,7 @@ 
         );
         $this->_quoteConvertor = $this->getModelMock(
             'sales/convert_quote',
-            ['toOrder', 'addressToOrderAddress', 'itemToOrderItem', 'paymentToOrderPayment',]
+            ['toOrder', 'addressToOrderAddress', 'itemToOrderItem', 'paymentToOrderPayment', ]
         );
         $this->_transaction = $this->getModelMock(
             'core/resource_transaction',

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/controllers/OrderController.php

Doc Comments +1 added lines, -1 removed lines

@@ -350,7 +350,7 @@
     /**
      * Ensure the proper data exist in before proceeding to show the current page.
      *
-     * @return self
+     * @return boolean
      */
     protected function _isValidOperation()
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Helper/Data.php

Doc Comments +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
     /**
      * Determine if order cancel reasons are configured.
      *
-     * @return array | null
+     * @return boolean | null
      */
     public function hasOrderCancelReason()
     {

src/app/code/community/EbayEnterprise/Order/Helper/Detail/Map.php

Doc Comments +1 added lines, -1 removed lines

@@ -126,7 +126,7 @@
      *
      * @param  IPayload
      * @param  string
-     * @return array
+     * @return string
      */
     public function getListAsSerialize(IPayload $payload, $getter)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Helper/Event.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
     }
     /**
      * Extract the name of the order event from the order event XML.
-     * @param  string $message OrderEvent XML
+     * @param  string $messageDoc OrderEvent XML
      * @return string
      * @throws EbayEnterprise_Amqp_Exception_Invalid_Message If message could not be parsed for event name
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Helper/Giftcard.php

Doc Comments +3 added lines, -2 removed lines

@@ -59,7 +59,7 @@ 
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param array      $arr
-     * @param string|int $field Valid array key
+     * @param string $field Valid array key
      * @param mixed      $default
      * @return mixed
      */
@@ -140,7 +140,7 @@ 
      *
      * @param IShipGroupIterable
      * @param Mage_Sales_Model_Order_Item[]
-     * @return array
+     * @return EbayEnterprise_Order_Model_Create_Itemreferencepair[]
      */
     protected function removeVirtualGiftCardPayloads(IShipGroupIterable $shipGroups, array $virtualGiftCards)
     {
@@ -391,6 +391,7 @@ 
      *
      * @param Varien_Object[]
      * @param string
+     * @param string $indexField
      * @return Varien_Object[]
      */
     protected function createItemIndex(array $items, $indexField)

Unused Use Statements +3 added lines, -3 removed lines

@@ -13,15 +13,15 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderDestinationIterable;
+use Psr\Log\LoggerInterface;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IEmailAddressDestination;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderCreateRequest;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderDestinationIterable;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderItemReference;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderItemReferenceIterable;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\IPriceGroup;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IShipGroup;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IShipGroupIterable;
-use eBayEnterprise\RetailOrderManagement\Payload\Order\IPriceGroup;
-use Psr\Log\LoggerInterface;
 
 class EbayEnterprise_Order_Helper_Giftcard
 {

Spacing +2 added lines, -2 removed lines

@@ -309,7 +309,7 @@ 
     protected function getVirtualGiftCardItemReferences(IOrderItemReferenceIterable $itemRefs, array $virtualGiftCards)
     {
         return $this->mapItemReferenceToItem(
-            function (IOrderItemReference $itemRef) {
+            function(IOrderItemReference $itemRef) {
                 return $itemRef;
             },
             $itemRefs,
@@ -328,7 +328,7 @@ 
     protected function createItemReferencePairs(array $itemRefs, array $virtualGiftCards)
     {
         return $this->mapItemReferenceToItem(
-            function (IOrderItemReference $itemRef, Mage_Sales_Model_Order_Item $item) {
+            function(IOrderItemReference $itemRef, Mage_Sales_Model_Order_Item $item) {
                 return $this->createItemReferencePair($item, $itemRef);
             },
             $itemRefs,

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -344,7 +344,7 @@
      * @param Mage_Sales_Model_Order_Item[]
      * @return array
      */
-    protected function mapItemReferenceToItem(Callable $cb, $itemRefs, array $virtualGiftCards)
+    protected function mapItemReferenceToItem(callable $cb, $itemRefs, array $virtualGiftCards)
     {
         $itemIndex = $this->createItemIndex($virtualGiftCards, 'line_number');
         $res = [];

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {