GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Pull Request — master (#32)
by Ryan
10:44
created
src/app/code/community/EbayEnterprise/Catalog/Model/Pim.php 3 patches
Doc Comments   +1 added lines, -5 removed lines patch added patch discarded remove patch
@@ -114,10 +114,7 @@  discard block
 block discarded – undo
114 114
     }
115 115
     /**
116 116
      * generate the outgoing product feed.
117
-     * @param  array  $productIds     list of product id's to include in the feed.
118
-     * @param  array  $feedTypeConfig configuration data for the current feed.
119
-     * @param  array  $stores         list of stores to use as context for getting values.
120
-     * @return array  array of full filepath where the feed files was saved.
117
+     * @return string  array of full filepath where the feed files was saved.
121 118
      */
122 119
     public function buildFeed()
123 120
     {
@@ -215,7 +212,6 @@  discard block
 block discarded – undo
215 212
      *
216 213
      * @param  Mage_Catalog_Model_Resource_Product_Collection $products products for a specific store
217 214
      * @param  EbayEnterprise_Catalog_Model_Pim_Product_Collection $pimProducts collection of PIM Product instances
218
-     * @param  string $key
219 215
      * @param array $productIds
220 216
      * @return EbayEnterprise_Catalog_Model_Pim_Product_Collection $pimProducts collection of PIM Product instances
221 217
      */
Please login to merge, or discard this patch.
Spacing   +4 added lines, -5 removed lines patch added patch discarded remove patch
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
                 $logMessage = 'Product "{sku}" excluded from export.';
251 251
                 $this->_logger->warning($logMessage, $this->_context->getMetaData(__CLASS__, $logData));
252 252
                 $this->_logger->logException($e, $this->_context->getMetaData(__CLASS__, [], $e));
253
-                $excludedProductIds[]= $product->getId();
253
+                $excludedProductIds[] = $product->getId();
254 254
                 $pimProducts->deleteItem($pimProduct);
255 255
             }
256 256
         }
@@ -270,9 +270,8 @@  discard block
 block discarded – undo
270 270
     protected function _getFeedAttributes($storeId)
271 271
     {
272 272
         $config = $this->_getFeedConfig();
273
-        return ((int) $storeId === (int) $this->_getDefaultStoreViewId())?
274
-            array_keys($config[self::KEY_MAPPINGS]) :
275
-            $this->_getTranslatableAttributes($config[self::KEY_MAPPINGS]);
273
+        return ((int) $storeId === (int) $this->_getDefaultStoreViewId()) ?
274
+            array_keys($config[self::KEY_MAPPINGS]) : $this->_getTranslatableAttributes($config[self::KEY_MAPPINGS]);
276 275
     }
277 276
     /**
278 277
      * get only translatable attributes
@@ -281,7 +280,7 @@  discard block
 block discarded – undo
281 280
      */
282 281
     protected function _getTranslatableAttributes(array $mapAttributes)
283 282
     {
284
-        return array_filter(array_map(function ($key) use ($mapAttributes) {
283
+        return array_filter(array_map(function($key) use ($mapAttributes) {
285 284
                 return ($mapAttributes[$key]['translate'] === '1') ? $key : null;
286 285
         }, array_keys($mapAttributes)));
287 286
     }
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
app/code/community/EbayEnterprise/Catalog/Model/Pim/Attribute/Factory.php 3 patches
Doc Comments   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,7 +47,6 @@  discard block
 block discarded – undo
47 47
      * @param  string $attribute
48 48
      * @param  Mage_Catalog_Model_Product          $product
49 49
      * @param  EbayEnterprise_Dom_Document             $doc
50
-     * @param  array $key
51 50
      * @return EbayEnterprise_Catalog_Model_Pim_Attribute
52 51
      */
53 52
     public function getPimAttribute(
@@ -69,7 +68,6 @@  discard block
 block discarded – undo
69 68
     /**
70 69
      * Get the attribute mapping. The result will be an empty array.
71 70
      * @param  string $attribute
72
-     * @param  string $key
73 71
      * @return array
74 72
      */
75 73
     protected function _getAttributeMapping($attribute, $config)
@@ -81,7 +79,7 @@  discard block
 block discarded – undo
81 79
      * Lookup the callable described in the mapping xml to export this attribute for this product.
82 80
      *
83 81
      * @param array $callbackMapping
84
-     * @param $attribute
82
+     * @param string $attribute
85 83
      * @param Mage_Catalog_Model_Product $product
86 84
      * @param EbayEnterprise_Dom_Document $doc
87 85
      * @return array|null
Please login to merge, or discard this patch.
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -125,8 +125,7 @@
 block discarded – undo
125 125
             'destination_xpath' => $callbackMapping['xml_dest'],
126 126
             'sku' => $product->getSku(),
127 127
             'language' => $callbackMapping['translate'] ?
128
-                $product->getPimLanguageCode() :
129
-                null,
128
+                $product->getPimLanguageCode() : null,
130 129
             'value' => $pimAttributeValue,
131 130
         );
132 131
     }
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/Catalog/Model/Price/Event.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 
112 112
     /**
113 113
      * Get the "special_price" if there is one.
114
-     * @return float|null
114
+     * @return double
115 115
      */
116 116
     public function getSpecialPrice()
117 117
     {
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
      * format string or via a default.
135 135
      * @see self::_formatDate
136 136
      * @param  string|null $format Date format string to use
137
-     * @return string|null Formatted datetime
137
+     * @return string Formatted datetime
138 138
      */
139 139
     public function getSpecialFromDate($format = null)
140 140
     {
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      * format string or via a default.
147 147
      * @see self::_formatDate
148 148
      * @param  string|null $format Date format string to use
149
-     * @return string|null Formatted datetime
149
+     * @return string Formatted datetime
150 150
      */
151 151
     public function getSpecialToDate($format = null)
152 152
     {
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/Catalog/Test/Helper/DataTest.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -862,8 +862,8 @@
 block discarded – undo
862 862
     }
863 863
     /**
864 864
      * Test normalizing a product style id to match formatting for skus
865
-     * @param  string $style   The product style id
866
-     * @param  string $catalog The product catalog id
865
+     * @param  string $styleId   The product style id
866
+     * @param  string $catalogId The product catalog id
867 867
      * @dataProvider dataProvider
868 868
      */
869 869
     public function testNormalizeSku($styleId, $catalogId)
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -243,17 +243,17 @@
 block discarded – undo
243 243
      */
244 244
     public function testParseTranslations()
245 245
     {
246
-        $sampleInput = array (
247
-            array (
246
+        $sampleInput = array(
247
+            array(
248 248
                 'lang' => 'en-US',
249 249
                 'description' => 'An en-US translation',
250 250
             ),
251
-            array (
251
+            array(
252 252
                 'lang' => 'ja-JP',
253 253
                 'description' => 'ja-JP に変換',
254 254
             ),
255 255
         );
256
-        $expectedOutput = array (
256
+        $expectedOutput = array(
257 257
             'en-US' => 'An en-US translation',
258 258
             'ja-JP' => 'ja-JP に変換',
259 259
         );
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/Catalog/Test/Helper/FeedTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@
 block discarded – undo
96 96
     /**
97 97
      * Test getting a DateTime object for a CreateDateAndTime from an import feed
98 98
      * @param string|null $feedTime  Create date and time in feed
99
-     * @param string $dateTimeStamp Expected timestamp
99
+     * @param string $dateTimeDate Expected timestamp
100 100
      * @dataProvider dataProvider
101 101
      */
102 102
     public function testGetDateTimeForFeedTime($feedTime, $dateTimeDate)
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/Catalog/Test/Helper/PimTest.php 3 patches
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -952,6 +952,10 @@  discard block
 block discarded – undo
952 952
         ));
953 953
         $this->assertSame($expected->saveXML(), $doc->saveXML());
954 954
     }
955
+
956
+    /**
957
+     * @param string $xml
958
+     */
955 959
     protected function _newDocument($xml = null)
956 960
     {
957 961
         $doc = Mage::helper('eb2ccore')->getNewDomDocument();
@@ -963,8 +967,6 @@  discard block
 block discarded – undo
963 967
     }
964 968
     /**
965 969
      * verify a fragment is returned containing the product links
966
-     * @param  bool   $allowMessage
967
-     * @param  bool   $isVirtual
968 970
      * @SuppressWarnings(PHPMD.UnusedLocalVariable)
969 971
      */
970 972
     public function testPassProductLinks()
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
         // return array containing config product's id and an empty array otherwise
87 87
         $this->configTypeResource->expects($this->any())
88 88
             ->method('getParentIdsByChild')
89
-            ->will($this->returnCallback(function ($childId) use ($configId, $simpleId) {
89
+            ->will($this->returnCallback(function($childId) use ($configId, $simpleId) {
90 90
                 return $childId === $simpleId ? array($configId) : array();
91 91
             }));
92 92
 
@@ -736,7 +736,7 @@  discard block
 block discarded – undo
736 736
     public function testCreateDateTime()
737 737
     {
738 738
         $value = '2014-03-15 12:33:48';
739
-        $result     = '2014-03-15T12:33:48+00:00';
739
+        $result = '2014-03-15T12:33:48+00:00';
740 740
 
741 741
         $pimHelperMock = $this->getHelperMockBuilder('ebayenterprise_catalog/pim')
742 742
             ->disableOriginalConstructor()
@@ -753,7 +753,7 @@  discard block
 block discarded – undo
753 753
     public function testCreateInteger()
754 754
     {
755 755
         $value = '12';
756
-        $result     = 12;
756
+        $result = 12;
757 757
 
758 758
         $pimHelperMock = $this->getHelperMockBuilder('ebayenterprise_catalog/pim')
759 759
             ->disableOriginalConstructor()
@@ -770,7 +770,7 @@  discard block
 block discarded – undo
770 770
     public function testCreateDecimal()
771 771
     {
772 772
         $value = '12.677';
773
-        $result     = 12.677;
773
+        $result = 12.677;
774 774
 
775 775
         $pimHelperMock = $this->getHelperMockBuilder('ebayenterprise_catalog/pim')
776 776
             ->disableOriginalConstructor()
@@ -787,7 +787,7 @@  discard block
 block discarded – undo
787 787
     public function testCreateBool()
788 788
     {
789 789
         $value = '1';
790
-        $result     = 'true';
790
+        $result = 'true';
791 791
 
792 792
         $pimHelperMock = $this->getHelperMockBuilder('ebayenterprise_catalog/pim')
793 793
             ->disableOriginalConstructor()
@@ -1000,7 +1000,7 @@  discard block
 block discarded – undo
1000 1000
         $pimHelper->expects($this->any())
1001 1001
             ->method('passSKU')
1002 1002
             ->will($this->returnCallback(
1003
-                function ($a, $b, $product, $doc) {
1003
+                function($a, $b, $product, $doc) {
1004 1004
                     return $doc->createCDataSection($product->getSku());
1005 1005
                 }
1006 1006
             ));
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
app/code/community/EbayEnterprise/Catalog/Test/Model/Feed/CleanerTest.php 3 patches
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -153,8 +153,6 @@
 block discarded – undo
153 153
     /**
154 154
      * Test determining if a product is expected to have a configuratble parent
155 155
      * products.
156
-     * @param  Mage_Catalog_Model_Product $product
157
-     * @param  bool $hasParent
158 156
      */
159 157
     public function testGetAllParentConfigurableSkus()
160 158
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -518,10 +518,10 @@
 block discarded – undo
518 518
         // Product links to try to make
519 519
         $linkUpdates = array(
520 520
             array(
521
-                'link_type' => $linkType, 'operation_type' => 'Add','link_to_unique_id' => '45-missing-link',
521
+                'link_type' => $linkType, 'operation_type' => 'Add', 'link_to_unique_id' => '45-missing-link',
522 522
             ),
523 523
             array(
524
-                'link_type' => $linkType, 'operation_type' => 'Add','link_to_unique_id' => '45-add-link',
524
+                'link_type' => $linkType, 'operation_type' => 'Add', 'link_to_unique_id' => '45-add-link',
525 525
             ),
526 526
             array(
527 527
                 'link_type' => $linkType, 'operation_type' => 'delete', 'link_to_unique_id' => '45-link-to-remove',
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/Catalog/Test/Model/Feed/CoreTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
 {
18 18
     /**
19 19
      * Get a mock Varien_Io_File object to sub out for a real one.
20
-     * @return Mock_Varien_File_Io
20
+     * @return PHPUnit_Framework_MockObject_MockBuilder
21 21
      */
22 22
     protected function _getMockFsTool()
23 23
     {
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/CreditCard/Model/Method/Ccpayment.php 4 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
      * Return the value at field in array if it exists. Otherwise, use the
164 164
      * default value.
165 165
      * @param array      $arr
166
-     * @param string|int $field Valid array key
166
+     * @param string $field Valid array key
167 167
      * @param mixed      $default
168 168
      * @return mixed
169 169
      */
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
     }
492 492
     /**
493 493
      * Make the API request and handle any exceptions.
494
-     * @param ApiIBidirectionalApi $api
494
+     * @param IBidirectionalApi $api
495 495
      * @return self
496 496
      */
497 497
     protected function _sendAuthRequest(Api\IBidirectionalApi $api)
@@ -534,7 +534,7 @@  discard block
 block discarded – undo
534 534
     /**
535 535
      * Update payment objects with details of the auth request and response. Validate
536 536
      * that a successful response was received.
537
-     * @param ApiIBidirectionalApi $api
537
+     * @param IBidirectionalApi $api
538 538
      * @param Varien_Object        $payment
539 539
      * @return self
540 540
      */
Please login to merge, or discard this patch.
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,14 +13,14 @@
 block discarded – undo
13 13
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14 14
  */
15 15
 
16
+use Psr\Log\LoggerInterface;
17
+use Psr\Log\NullLogger;
16 18
 use eBayEnterprise\RetailOrderManagement\Api;
17 19
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
18 20
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedHttpAction;
19 21
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedOperation;
20 22
 use eBayEnterprise\RetailOrderManagement\Payload;
21 23
 use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
22
-use Psr\Log\LoggerInterface;
23
-use Psr\Log\NullLogger;
24 24
 
25 25
 class EbayEnterprise_CreditCard_Model_Method_Ccpayment extends Mage_Payment_Model_Method_Cc
26 26
 {
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -39,51 +39,51 @@  discard block
 block discarded – undo
39 39
      * Code unique to this payment method.
40 40
      * @var string
41 41
      */
42
-    protected $_code          = 'ebayenterprise_creditcard';
42
+    protected $_code = 'ebayenterprise_creditcard';
43 43
     /**
44 44
      * Is this payment method a gateway (online auth/charge) ?
45 45
      */
46
-    protected $_isGateway               = false;
46
+    protected $_isGateway = false;
47 47
 
48 48
     /**
49 49
      * Can authorize online?
50 50
      */
51
-    protected $_canAuthorize            = true;
51
+    protected $_canAuthorize = true;
52 52
 
53 53
     /**
54 54
      * Can capture funds online?
55 55
      */
56
-    protected $_canCapture              = false;
56
+    protected $_canCapture = false;
57 57
 
58 58
     /**
59 59
      * Can capture partial amounts online?
60 60
      */
61
-    protected $_canCapturePartial       = false;
61
+    protected $_canCapturePartial = false;
62 62
 
63 63
     /**
64 64
      * Can refund online?
65 65
      */
66
-    protected $_canRefund               = false;
66
+    protected $_canRefund = false;
67 67
 
68 68
     /**
69 69
      * Can void transactions online?
70 70
      */
71
-    protected $_canVoid                 = false;
71
+    protected $_canVoid = false;
72 72
 
73 73
     /**
74 74
      * Can use this payment method in administration panel?
75 75
      */
76
-    protected $_canUseInternal          = true;
76
+    protected $_canUseInternal = true;
77 77
 
78 78
     /**
79 79
      * Can show this payment method as an option on checkout payment page?
80 80
      */
81
-    protected $_canUseCheckout          = true;
81
+    protected $_canUseCheckout = true;
82 82
 
83 83
     /**
84 84
      * Is this payment method suitable for multi-shipping checkout?
85 85
      */
86
-    protected $_canUseForMultishipping  = true;
86
+    protected $_canUseForMultishipping = true;
87 87
 
88 88
     /**
89 89
      * Can save credit card information for future processing?
@@ -573,7 +573,7 @@  discard block
 block discarded – undo
573 573
         $addresses = $quote->getAllShippingAddresses();
574 574
         $selected = array_reduce(
575 575
             $addresses,
576
-            function (
576
+            function(
577 577
                 Mage_Sales_Model_Quote_Address $current = null,
578 578
                 Mage_Sales_Model_Quote_Address $address
579 579
             ) {
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.