eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Order/Model/Tracking.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
         Mage_Shipping_Model_Config $shippingConfig,
         Mage_Sales_Model_Order $order,
         $shipmentId,
-        $trackingNumber=null
+        $trackingNumber = null
     )
     {
         return func_get_args();

Braces +1 added lines, -2 removed lines

@@ -59,8 +59,7 @@
         Mage_Sales_Model_Order $order,
         $shipmentId,
         $trackingNumber=null
-    )
-    {
+    ) {
         return func_get_args();
     }
 

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Test/Controller/OrderControllerTest.php

Spacing +2 added lines, -2 removed lines

@@ -649,7 +649,7 @@ 
         $controller->expects($this->once())
             ->method('_getRomCancelSession')
             ->will($this->returnValue($session));
-        $controller->expects($isRedirectSession? $this->never() : $this->once())
+        $controller->expects($isRedirectSession ? $this->never() : $this->once())
             // Proving that this method will never be called when the varien magic method
             // core/session::getCancelActionRefererUrl() returns a non-empty string.
             // When the method core/session::getCancelActionRefererUrl() return null
@@ -789,7 +789,7 @@ 
         $request->expects($this->once())
             ->method('isPost')
             ->will($this->returnValue($isPost));
-        $request->expects($isPost? $this->once() : $this->never())
+        $request->expects($isPost ? $this->once() : $this->never())
             // Proving that once the method Zend_Controller_Request_Abstract::isPost() return
             // false the method Zend_Controller_Request_Abstract::getPost() will never be invoked
             // since we are using logical AND operation for the condition.

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Test/Helper/FactoryTest.php

Indentation +15 added lines, -15 removed lines

@@ -1,17 +1,17 @@ 
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Order_Test_Helper_FactoryTest extends EbayEnterprise_Eb2cCore_Test_Base
 {
@@ -272,9 +272,9 @@ 
     }
 
         /**
-     * Test that the controller method ebayenterprise_order/factory::getCoreSessionModel()
-     * is invoked and it will instantiate an object of type core/session and return this object.
-     */
+         * Test that the controller method ebayenterprise_order/factory::getCoreSessionModel()
+         * is invoked and it will instantiate an object of type core/session and return this object.
+         */
     public function testGetCoreSessionModel()
     {
         /** @var Mock_Mage_Core_Model_Session */

src/app/code/community/EbayEnterprise/Order/Test/Helper/Search/MapTest.php

Spacing +3 added lines, -3 removed lines

@@ -66,7 +66,7 @@ 
         return [
             [new DateTime('2015-05-14T20:32:33+00:00'), '2015-05-14T20:32:33+00:00'],
             [null, null],
-            [new stdClass() , null],
+            [new stdClass(), null],
         ];
     }
 
@@ -97,7 +97,7 @@ 
         return [
             [7.65, 7.65],
             ['10.87', 10.87],
-            [null , 0.0],
+            [null, 0.0],
         ];
     }
 
@@ -126,7 +126,7 @@ 
         return [
             ['true', true],
             ['false', false],
-            [null , false],
+            [null, false],
         ];
     }
 

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Test/Model/Create/OrderitemTest.php

Spacing +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
                 'info_buyRequest' => [
                     'super_attribute' => [
                         92 => '15', // fake color
-                        3 => '2',   // fake size
+                        3 => '2', // fake size
                     ]
                 ]
             ])

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Test/Model/Detail/Process/ResponseTest.php

Spacing +8 added lines, -8 removed lines

@@ -62,29 +62,29 @@
         // Set the class property ebayenterprise_order/detail_process_response::$_response to a known state
         EcomDev_Utils_Reflection::setRestrictedPropertyValue($detailProcessResponse, '_response', $response);
 
-        $detailProcessResponse->expects($invalidResponse? $this->never() : $this->once())
+        $detailProcessResponse->expects($invalidResponse ? $this->never() : $this->once())
             // Proving that this method will only be invoked when there's a valid IOrderDetailResponse response.
             ->method('_populateOrder')
             ->will($this->returnSelf());
-        $detailProcessResponse->expects($invalidResponse? $this->never() : $this->once())
+        $detailProcessResponse->expects($invalidResponse ? $this->never() : $this->once())
             ->method('_populateOrderAddress')
             ->will($this->returnSelf());
-        $detailProcessResponse->expects($invalidResponse? $this->never() : $this->once())
+        $detailProcessResponse->expects($invalidResponse ? $this->never() : $this->once())
             ->method('_determineBillingAddress')
             ->will($this->returnSelf());
-        $detailProcessResponse->expects($invalidResponse? $this->never() : $this->once())
+        $detailProcessResponse->expects($invalidResponse ? $this->never() : $this->once())
             ->method('_determineShippingAddress')
             ->will($this->returnSelf());
-        $detailProcessResponse->expects($invalidResponse? $this->never() : $this->once())
+        $detailProcessResponse->expects($invalidResponse ? $this->never() : $this->once())
             ->method('_populateOrderItem')
             ->will($this->returnSelf());
-        $detailProcessResponse->expects($invalidResponse? $this->never() : $this->once())
+        $detailProcessResponse->expects($invalidResponse ? $this->never() : $this->once())
             ->method('_populateOrderPayment')
             ->will($this->returnSelf());
-        $detailProcessResponse->expects($invalidResponse? $this->never() : $this->once())
+        $detailProcessResponse->expects($invalidResponse ? $this->never() : $this->once())
             ->method('_populateOrderShipment')
             ->will($this->returnSelf());
-        $detailProcessResponse->expects($invalidResponse? $this->never() : $this->once())
+        $detailProcessResponse->expects($invalidResponse ? $this->never() : $this->once())
             ->method('_populateOrderShipGroup')
             ->will($this->returnSelf());
         $this->assertSame($detailProcessResponse, $detailProcessResponse->process());

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/ProductExport/Helper/Giftcard.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
      */
     protected function _getMaxGiftCardAmount(Mage_Catalog_Model_Product $product)
     {
-        return array_reduce($product->getGiftcardAmounts(), function ($p, $i) {
+        return array_reduce($product->getGiftcardAmounts(), function($p, $i) {
                 return max($p, $i['value']);
         }, 0);
     }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Helper/Duty.php

Spacing +3 added lines, -3 removed lines

@@ -70,9 +70,9 @@
             $dutyRecords = $collector->getTaxDutiesByAddressId($addressId);
             $feeRecords = $collector->getTaxFeesByAddressId($addressId);
         }
-        $taxes = array_sum(array_map(function ($record) { return $record->getCalculatedTax(); }, $taxRecords));
-        $duties = array_sum(array_map(function ($record) { return $record->getAmount(); }, $dutyRecords));
-        $fees = array_sum(array_map(function ($record) { return $record->getAmount(); }, $feeRecords));
+        $taxes = array_sum(array_map(function($record) { return $record->getCalculatedTax(); }, $taxRecords));
+        $duties = array_sum(array_map(function($record) { return $record->getAmount(); }, $dutyRecords));
+        $fees = array_sum(array_map(function($record) { return $record->getAmount(); }, $feeRecords));
         return [$taxes, $duties, $fees];
     }
 }

Doc Comments +2 added lines, -1 removed lines

@@ -63,7 +63,8 @@
      * @param string
      * @param array
      * @param mixed
-     * @return mixed
+     * @param string $key
+     * @return EbayEnterprise_Tax_Model_Collector
      */
     protected function _nullCoalesce(array $arr, $key, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Address/Model/Observer.php

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
      * Return the value at field in array if it exists. Otherwise, use the
      * default value.
      * @param array $arr
-     * @param string|int $field Valid array key
+     * @param string $field Valid array key
      * @param mixed $default
      * @return mixed
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {