eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Catalog/Test/Model/Pim/ProductTest.php

Spacing +3 added lines, -3 removed lines

@@ -22,10 +22,10 @@ 
     public function testLoadPimAttributesByProduct()
     {
         $config = array('the config');
-        $attributes = array('_gsi_client_id','sku');
+        $attributes = array('_gsi_client_id', 'sku');
 
         $result = array();
-        for ($i=0; $i < 3; $i++) {
+        for ($i = 0; $i < 3; $i++) {
             $result[] = $this->getModelMockBuilder('ebayenterprise_catalog/pim_attribute')
                 ->disableOriginalConstructor()
                 ->getMock();
@@ -100,7 +100,7 @@ 
             'client_id' => 'ClientId',
             'catalog_id' => 'CatalogId',
             'sku' => '45-12345',
-            'pim_attributes' => array(1,2,3),
+            'pim_attributes' => array(1, 2, 3),
         );
         $pimProduct = Mage::getModel('ebayenterprise_catalog/pim_product', $constructorArgs);
         $this->assertSame('ClientId', $pimProduct->getClientId());

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Helper/Languages.php

Spacing +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
         // Swallow libxml warnings. In this tightly controlled case, all that
         // can be expected to be invalid in the XML is the language code so
         // the warnings won't tell us anything more useful anyway.
-        set_error_handler(function () {
+        set_error_handler(function() {
         });
         // Need to capture results instead of just returning them so the error
         // handler used to swallow the libxml errors can be removed.

Doc Comments +2 added lines, -1 removed lines

@@ -46,7 +46,8 @@
      * @param  array
      * @param  string | int $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @param string $field
+     * @return EbayEnterprise_Eb2cCore_Helper_Data
      */
     protected function nullCoalesce(array $arr, $field, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Helper/Validator.php

Spacing +2 added lines, -2 removed lines

@@ -135,7 +135,7 @@ 
      */
     protected function _buildTestRequest()
     {
-        $coreHelper =  $this->_helper;
+        $coreHelper = $this->_helper;
         $request = <<<REQUEST
 <AddressValidationRequest xmlns="http://api.gsicommerce.com/schema/checkout/1.0">
 	<Header><MaxAddressSuggestions>3</MaxAddressSuggestions></Header>
@@ -218,7 +218,7 @@ 
         // When the Net_SFTP instance failes to connect, it will trigger an error
         // instead of throwing an exception. Convert the error to an exception
         // so it can halt execution and be caught.
-        set_error_handler(function ($errno, $errstr) {
+        set_error_handler(function($errno, $errstr) {
             throw new EbayEnterprise_Eb2cCore_Exception_Sftp_Configuration($errstr);
         }, E_USER_NOTICE);
         try {

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -147,7 +147,7 @@
 		<PostalCode>19406</PostalCode>
 	</Address>
 </AddressValidationRequest>
-REQUEST;
+request;
         $dom = $coreHelper->getNewDomDocument();
         $dom->loadXml($request);
         return $dom;

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Model/Api.php

Spacing +1 added lines, -1 removed lines

@@ -171,7 +171,7 @@
     public function schemaValidate(DOMDocument $doc, $xsdName)
     {
         $errors = array();
-        set_error_handler(function ($errno, $errstr) use (&$errors) {
+        set_error_handler(function($errno, $errstr) use (&$errors) {
             $errors[] = "'$errstr' [Errno $errno]";
         });
         $cfg = Mage::helper('eb2ccore')->getConfigModel();

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Model/Session.php

Spacing +5 added lines, -9 removed lines

@@ -123,8 +123,7 @@ 
     {
         $address = $quote->getBillingAddress();
         return $address ?
-            $this->_extractAddressData($address) :
-            array();
+            $this->_extractAddressData($address) : array();
     }
     /**
      * Extract quote amounts from each address.
@@ -134,7 +133,7 @@ 
     protected function _extractQuoteAmounts(Mage_Sales_Model_Quote $quote)
     {
         return array_map(
-            function ($address) {
+            function($address) {
                 return array(
                     'subtotal' => round($address->getSubtotal(), 4) ?: 0.0000,
                     'discount' => round($address->getDiscountAmount(), 4) ?: 0.0000,
@@ -176,8 +175,7 @@ 
     protected function _diffBilling(array $oldAddress, array $newAddress)
     {
         return ($oldAddress !== $newAddress) ?
-            array('billing' => $newAddress) :
-            array();
+            array('billing' => $newAddress) : array();
     }
     /**
      * Diff the old coupon to the new coupon. Return array of coupon data if coupon
@@ -190,8 +188,7 @@ 
     protected function _diffCoupon($oldCoupon, $newCoupon)
     {
         return ($oldCoupon !== $newCoupon) ?
-            array('coupon' => $newCoupon) :
-            array();
+            array('coupon' => $newCoupon) : array();
     }
     /**
      * Diff the old shipping data to the new shipping data. Any change to shipping
@@ -203,8 +200,7 @@ 
     protected function _diffShipping($oldShipping, $newShipping)
     {
         return ($oldShipping !== $newShipping) ?
-            array('shipping' => $newShipping) :
-            array();
+            array('shipping' => $newShipping) : array();
     }
     /**
      * Diff quote item quantities between the old items and new items. Diff should only check for

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

Doc Comments +1 added lines, -1 removed lines

@@ -359,7 +359,7 @@
     /**
      * Update the inventory details flag.
      * NOTE: this method cannot set the flag to be false if the flag was already set to be true.
-     * @param $value
+     * @param boolean $value
      * @return self
      */
     public function setDetailsUpdateRequired($value)

src/app/code/community/EbayEnterprise/Eb2cCore/Test/Helper/DataTest.php

Spacing +1 added lines, -1 removed lines

@@ -388,7 +388,7 @@
         if ($expect === '') {
             $expect = null;
         }
-        $mockMethod = (trim($iteration['mock_method']) === '')? array() : array($iteration['mock_method']);
+        $mockMethod = (trim($iteration['mock_method']) === '') ? array() : array($iteration['mock_method']);
 
         if (!empty($mockMethod)) {
             switch ($iteration['mock_type']) {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Test/Helper/LanguagesTest.php

Braces +1 added lines, -2 removed lines

@@ -43,8 +43,7 @@
                 $key,
                 $store->getStoreId()
             );
-            switch ($store->getStoreId())
-            {
+            switch ($store->getStoreId()) {
                 case 2: // Test Team USA Store is configured to default to website language
                     $this->assertEquals(
                         'default_lang',

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Test/Helper/Quote/ItemTest.php

Spacing +5 added lines, -5 removed lines

@@ -57,16 +57,16 @@
         $inventoriedSku         = Mage::getModel('sales/quote_item', ['product' => $inventoriedProduct]);
         $nonInventoriedSku      = Mage::getModel('sales/quote_item', ['product' => $nonInventoriedProduct]);
         $overrideInventoriedSku = Mage::getModel('sales/quote_item', ['product' => $overrideInventoriedProduct]);
-        $inventoriedChildSku    = Mage::getModel('sales/quote_item', ['product' => $inventoriedProduct, 'parent_item_id' => 2,]);
+        $inventoriedChildSku    = Mage::getModel('sales/quote_item', ['product' => $inventoriedProduct, 'parent_item_id' => 2, ]);
 
         $childInventoriesParentSku = Mage::getModel('sales/quote_item', ['product' => $nonInventoriedProduct]);
         $childInventoriesParentSku->addChild($inventoriedChildSku);
 
         return [
-            [$inventoriedSku, true],            // Set by ROM to be inventoried
-            [$nonInventoriedSku, true],         // Set by ROM to not be inventoried
-            [$overrideInventoriedSku, false],   // Set by ROM to be inventoried, but overridden by manage-stock flag
-            [$inventoriedChildSku, false],      // Set by ROM to be inventoried, but has parent, so no check
+            [$inventoriedSku, true], // Set by ROM to be inventoried
+            [$nonInventoriedSku, true], // Set by ROM to not be inventoried
+            [$overrideInventoriedSku, false], // Set by ROM to be inventoried, but overridden by manage-stock flag
+            [$inventoriedChildSku, false], // Set by ROM to be inventoried, but has parent, so no check
             [$childInventoriesParentSku, true], // Set by ROM to not be inventoried, but child forces it.
         ];
     }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Test/Model/ConfigRegistryTest.php

Spacing +2 added lines, -2 removed lines

@@ -174,7 +174,7 @@ 
     public function testUnknownProp()
     {
         // ensure code execution continues after the error is triggered
-        $handler = set_error_handler(function () {
+        $handler = set_error_handler(function() {
         });
         $config = Mage::getModel('eb2ccore/config_registry');
         $nonexistent = $config->nonexistentConfig;
@@ -199,7 +199,7 @@ 
      */
     public function testAllPropsReadonly()
     {
-        $handler = set_error_handler(function () {
+        $handler = set_error_handler(function() {
         });
         $config = Mage::getModel('eb2ccore/config_registry')
             ->addConfigModel($this->_createConfigStub());

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {