GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Pull Request — master (#29)
by Scott van
47:46 queued 47:46
created
src/app/code/community/EbayEnterprise/PayPal/Helper/Region.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -52,6 +52,7 @@
 block discarded – undo
52 52
      * @param  array
53 53
      * @param  string|int
54 54
      * @param  mixed
55
+     * @param string $field
55 56
      * @return mixed
56 57
      */
57 58
     protected function nullCoalesce(array $arr, $field, $default)
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/PayPal/Model/Express/Api.php 3 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
422 422
      * Send the request via the sdk
423 423
      *
424 424
      * @param  IBidirectionalApi
425
-     * @return Payload
425
+     * @return IPayload
426 426
      *
427 427
      * @throws EbayEnterprise_PayPal_Exception
428 428
      * @throws UnsupportedOperation
@@ -603,6 +603,7 @@  discard block
 block discarded – undo
603 603
      *
604 604
      * @param  string
605 605
      * @param  Mage_Sales_Model_Quote
606
+     * @param string $type
606 607
      * @return float
607 608
      */
608 609
     protected function getTotal($type, Mage_Sales_Model_Quote $quote)
Please login to merge, or discard this patch.
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,9 +16,9 @@
 block discarded – undo
16 16
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
17 17
 use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
18 18
 use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
19
-use eBayEnterprise\RetailOrderManagement\Payload\Payment\IShippingAddress;
20
-use eBayEnterprise\RetailOrderManagement\Payload\Payment\ILineItemIterable;
21 19
 use eBayEnterprise\RetailOrderManagement\Payload\Payment\ILineItemContainer;
20
+use eBayEnterprise\RetailOrderManagement\Payload\Payment\ILineItemIterable;
21
+use eBayEnterprise\RetailOrderManagement\Payload\Payment\IShippingAddress;
22 22
 
23 23
 /**
24 24
  * Payment Method for PayPal payments through Retail Order Management.
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/PayPal/Model/Express/Checkout.php 2 patches
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
      * default value.
138 138
      *
139 139
      * @param  array      $arr
140
-     * @param  string|int $field Valid array key
140
+     * @param  string $field Valid array key
141 141
      * @param  mixed      $default
142 142
      * @return mixed
143 143
      */
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
      *
190 190
      * @param Mage_Customer_Model_Customer $customer
191 191
      *
192
-     * @return Mage_Paypal_Model_Express_Checkout
192
+     * @return EbayEnterprise_PayPal_Model_Express_Checkout
193 193
      */
194 194
     public function setCustomer($customer)
195 195
     {
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
      * @param  Mage_Sales_Model_Quote_Address $billingAddress
206 206
      * @param  Mage_Sales_Model_Quote_Address $shippingAddress
207 207
      *
208
-     * @return Mage_Paypal_Model_Express_Checkout
208
+     * @return EbayEnterprise_PayPal_Model_Express_Checkout
209 209
      */
210 210
     public function setCustomerWithAddressChange(
211 211
         $customer,
@@ -516,7 +516,7 @@  discard block
 block discarded – undo
516 516
     /**
517 517
      * Prepare quote for guest checkout order submit
518 518
      *
519
-     * @return Mage_Paypal_Model_Express_Checkout
519
+     * @return EbayEnterprise_PayPal_Model_Express_Checkout
520 520
      */
521 521
     protected function _prepareGuestQuote()
522 522
     {
@@ -545,7 +545,7 @@  discard block
 block discarded – undo
545 545
      * Prepare quote for customer registration and customer order submit
546 546
      * and restore magento customer data from quote
547 547
      *
548
-     * @return Mage_Paypal_Model_Express_Checkout
548
+     * @return EbayEnterprise_PayPal_Model_Express_Checkout
549 549
      */
550 550
     protected function _prepareNewCustomerQuote()
551 551
     {
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/PayPal/Model/Method/Express.php 2 patches
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -107,7 +107,6 @@  discard block
 block discarded – undo
107 107
      *
108 108
      * @param EbayEnterprise_PayPal_Helper_Data             $helper
109 109
      * @param EbayEnterprise_Eb2cCore_Helper_Data           $coreHelper
110
-     * @param Mage_Core_Helper_Http                         $httpHelper
111 110
      * @param EbayEnterprise_MageLog_Helper_Data            $logger
112 111
      * @param EbayEnterprise_Eb2cCore_Model_Config_Registry $config
113 112
      *
@@ -127,7 +126,7 @@  discard block
 block discarded – undo
127 126
      * default value.
128 127
      *
129 128
      * @param  array      $arr
130
-     * @param  string|int $field Valid array key
129
+     * @param  string $field Valid array key
131 130
      * @param  mixed      $default
132 131
      *
133 132
      * @return mixed
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/PayPal/Model/Multishipping.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
      * @param  array
53 53
      * @param  string $field Valid array key
54 54
      * @param  mixed
55
-     * @return mixed
55
+     * @return EbayEnterprise_Paypal_Model_Express_Api
56 56
      */
57 57
     protected function nullCoalesce(array $arr, $field, $default)
58 58
     {
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
      * @param array $initParams May have this key:
26 26
      *                          - 'multi_shipping' => EbayEnterprise_PayPal_Model_Multishipping
27 27
      */
28
-    public function __construct(array $initParams=[])
28
+    public function __construct(array $initParams = [])
29 29
     {
30 30
         list($this->multiShipping) = $this->checkTypes(
31 31
             $this->nullCoalesce($initParams, 'multi_shipping', Mage::getModel('ebayenterprise_paypal/multishipping'))
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/PayPal/Model/Observer.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      * @param  array
50 50
      * @param  string $field Valid array key
51 51
      * @param  mixed
52
-     * @return mixed
52
+     * @return EbayEnterprise_PayPal_Model_Multishipping
53 53
      */
54 54
     protected function nullCoalesce(array $arr, $field, $default)
55 55
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
      * @param array $initParams May have this key:
26 26
      *                          - 'multi_shipping' => EbayEnterprise_PayPal_Model_Multishipping
27 27
      */
28
-    public function __construct(array $initParams=[])
28
+    public function __construct(array $initParams = [])
29 29
     {
30 30
         list($this->multiShipping) = $this->checkTypes(
31 31
             $this->nullCoalesce($initParams, 'multi_shipping', Mage::getModel('ebayenterprise_paypal/multishipping'))
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/PayPal/Test/Model/Express/ApiTest.php 4 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -504,7 +504,7 @@  discard block
 block discarded – undo
504 504
 
505 505
     /**
506 506
      * stub items for the tests.
507
-     * @return Mage_Sale_Model_Quote_Item[]
507
+     * @return EcomDev_PHPUnit_Mock_Proxy[]
508 508
      */
509 509
     protected function stubQuoteItems()
510 510
     {
@@ -718,7 +718,7 @@  discard block
 block discarded – undo
718 718
     /**
719 719
      * stub the specified methods on the mock to expect a
720 720
      * string argument and return itself
721
-     * @param  array  $methods
721
+     * @param  string[]  $methods
722 722
      * @param  object $stub
723 723
      * @return object
724 724
      */
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,11 +13,11 @@
 block discarded – undo
13 13
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14 14
  */
15 15
 
16
+use Psr\Log\NullLogger;
16 17
 use eBayEnterprise\RetailOrderManagement\Api;
17 18
 use eBayEnterprise\RetailOrderManagement\Payload;
18 19
 use eBayEnterprise\RetailOrderManagement\Payload\PayloadMap;
19 20
 use eBayEnterprise\RetailOrderManagement\Payload\ValidatorIterator;
20
-use Psr\Log\NullLogger;
21 21
 
22 22
 class EbayEnterprise_PayPal_Test_Model_Express_ApiTest extends EbayEnterprise_Eb2cCore_Test_Base
23 23
 {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -566,7 +566,7 @@  discard block
 block discarded – undo
566 566
     protected function isNumeric()
567 567
     {
568 568
         return $this->callback(
569
-            function ($val) {
569
+            function($val) {
570 570
 
571 571
                 return is_numeric($val);
572 572
             }
@@ -708,7 +708,7 @@  discard block
 block discarded – undo
708 708
     protected function isScalar()
709 709
     {
710 710
         return $this->callback(
711
-            function ($val) {
711
+            function($val) {
712 712
 
713 713
                 return is_scalar($val);
714 714
             }
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
app/code/community/EbayEnterprise/ProductImageExport/Model/Image/Export.php 3 patches
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
      * @param  EbayEnterprise_Eb2cCore_Helper_Data
49 49
      * @param  EbayEnterprise_Catalog_Helper_Data
50 50
      * @param  EbayEnterprise_Eb2cCore_Model_Config_Registry
51
-     * @return array
51
+     * @return EbayEnterprise_Eb2cCore_Model_Config_Registry[]
52 52
      */
53 53
     protected function _checkTypes(
54 54
         EbayEnterprise_Eb2cCore_Helper_Data $coreHelper,
@@ -60,9 +60,9 @@  discard block
 block discarded – undo
60 60
     /**
61 61
      * Return the value of field in array if it exists. Otherwise, use the default value.
62 62
      * @param  array
63
-     * @param  string|int $field Valid array key
63
+     * @param  string $field Valid array key
64 64
      * @param  mixed
65
-     * @return mixed
65
+     * @return EbayEnterprise_Eb2cCore_Model_Config_Registry
66 66
      */
67 67
     protected function _nullCoalesce(array $arr, $field, $default)
68 68
     {
@@ -237,6 +237,7 @@  discard block
 block discarded – undo
237 237
      * get product image data for product that doesn't exceed the self::SKU_MAX_LENGTH
238 238
      * @param  int
239 239
      * @param  string
240
+     * @param integer $storeId
240 241
      * @return array
241 242
      * Example: [
242 243
      *   [
@@ -395,6 +396,7 @@  discard block
 block discarded – undo
395 396
     /**
396 397
      * @param  string
397 398
      * @param  string
399
+     * @param string $path
398 400
      * @return self
399 401
      */
400 402
     protected function _updateConfig($path, $value)
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
     {
275 275
         $media = $product->getMediaGalleryImages();
276 276
 
277
-        return ($media && $media->count())?
277
+        return ($media && $media->count()) ?
278 278
             [
279 279
                 'id' => $product->getSku(),
280 280
                 'image_data' => $this->_getMediaData($media, $product)
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
     protected function _getMageImageViewMap(Mage_Catalog_Model_Product $mageProduct)
348 348
     {
349 349
         $attributes = $mageProduct->getAttributes();
350
-        return array_reduce(array_keys($attributes), function ($result = [], $key) use ($attributes, $mageProduct) {
350
+        return array_reduce(array_keys($attributes), function($result = [], $key) use ($attributes, $mageProduct) {
351 351
             if (!strcmp($attributes[$key]->getFrontendInput(), EbayEnterprise_ProductImageExport_Model_Image_Export::FRONTEND_INPUT)) {
352 352
                 $result[$key] = $mageProduct->getData($key);
353 353
             }
@@ -362,11 +362,11 @@  discard block
 block discarded – undo
362 362
      */
363 363
     protected function _filterImageViews(array $imageViews)
364 364
     {
365
-        $views = array_filter(array_keys($imageViews), function ($key) use ($imageViews) {
365
+        $views = array_filter(array_keys($imageViews), function($key) use ($imageViews) {
366 366
             return ($imageViews[$key] !== EbayEnterprise_ProductImageExport_Model_Image_Export::FILTER_OUT_VALUE);
367 367
         });
368 368
 
369
-        return !empty($views)? $views : [''];
369
+        return !empty($views) ? $views : [''];
370 370
     }
371 371
     /**
372 372
      * @return Mage_Core_Model_Config_Data
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.
src/app/code/community/EbayEnterprise/Tax/Helper/Factory.php 4 patches
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,8 +34,7 @@  discard block
 block discarded – undo
34 34
      * @param int $taxSource Should be one of the tax record source consts.
35 35
      * @param int
36 36
      * @param int
37
-     * @param int|null $itemId Address level taxes may not have an associated item id.
38
-     * @param ITax $taxPayload|null SDK payload of tax data to use to populate the tax record.
37
+     * @param ITax $taxPayload SDK payload of tax data to use to populate the tax record.
39 38
      * @param array $recordData Tax record data to be set directly on the tax record. May be used in place of an ITax payload.
40 39
      * @return EbayEnterprise_Tax_Model_Record
41 40
      */
@@ -65,6 +64,8 @@  discard block
 block discarded – undo
65 64
      * @param int $taxSource Should be one of hte tax record source consts.
66 65
      * @param int
67 66
      * @param int
67
+     * @param integer $quoteId
68
+     * @param integer $addressId
68 69
      * @return EbayEnterprise_Tax_Model_Record[]
69 70
      */
70 71
     public function createTaxRecordsForTaxContainer(
@@ -128,6 +129,8 @@  discard block
 block discarded – undo
128 129
      * @param ITaxedDutyPriceGroup
129 130
      * @param int
130 131
      * @param int
132
+     * @param integer $itemId
133
+     * @param integer $addressId
131 134
      * @return EbayEnterprise_Tax_Model_Duty
132 135
      */
133 136
     public function createTaxDuty(
@@ -185,6 +188,8 @@  discard block
 block discarded – undo
185 188
      * @param Mage_Sales_Model_Quote_Item_Abstract
186 189
      * @param int
187 190
      * @param int
191
+     * @param integer $addressId
192
+     * @param integer $quoteId
188 193
      * @return EbayEnterprise_Tax_Model_Response_Parser_Item
189 194
      */
190 195
     public function createResponseItemParser(
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,6 +17,7 @@  discard block
 block discarded – undo
17 17
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\IDestinationIterable;
18 18
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\IOrderItemRequestIterable;
19 19
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\IShipGroupIterable;
20
+use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxContainer;
20 21
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxDutyFeeQuoteReply;
21 22
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxDutyFeeQuoteRequest;
22 23
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxedDutyPriceGroup;
@@ -24,7 +25,6 @@  discard block
 block discarded – undo
24 25
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxedFeeIterable;
25 26
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxedOrderItem;
26 27
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxedShipGroup;
27
-use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxContainer;
28 28
 
29 29
 class EbayEnterprise_Tax_Helper_Factory
30 30
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@
 block discarded – undo
154 154
     ) {
155 155
         return Mage::getModel(
156 156
             'ebayenterprise_tax/response_parser_quote',
157
-            ['tax_response' => $taxResponse, 'quote' => $quote,]
157
+            ['tax_response' => $taxResponse, 'quote' => $quote, ]
158 158
         );
159 159
     }
160 160
 
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,17 +1,17 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
- *
5
- * NOTICE OF LICENSE
6
- *
7
- * This source file is subject to the Open Software License (OSL 3.0)
8
- * that is bundled with this package in the file LICENSE.md.
9
- * It is also available through the world-wide-web at this URL:
10
- * http://opensource.org/licenses/osl-3.0.php
11
- *
12
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
- */
3
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
4
+     *
5
+     * NOTICE OF LICENSE
6
+     *
7
+     * This source file is subject to the Open Software License (OSL 3.0)
8
+     * that is bundled with this package in the file LICENSE.md.
9
+     * It is also available through the world-wide-web at this URL:
10
+     * http://opensource.org/licenses/osl-3.0.php
11
+     *
12
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
13
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
14
+     */
15 15
 
16 16
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
17 17
 {
Please login to merge, or discard this patch.