eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/CreditCard/Test/Model/Order/Create/PaymentTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
     /**
      * stub out the setter methods for the payload excluding those
      * specified in the array
-     * @param  array  $exclude
+     * @param  string[]  $exclude
      */
     protected function _stubPayload($exclude = [])
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/controllers/Exchange/System/Config/ValidateController.php

Doc Comments +3 added lines, -3 removed lines

@@ -50,7 +50,7 @@ 
     /**
      * Type checks for __construct's $initParams
      * @param EbayEnterprise_Eb2cCore_Helper_Validator $validatorHelper
-     * @return mixed[]
+     * @return EbayEnterprise_Eb2cCore_Helper_Validator[]
      */
     protected function _checkTypes(EbayEnterprise_Eb2cCore_Helper_Validator $validatorHelper)
     {
@@ -59,9 +59,9 @@ 
     /**
      * Get the value form the array if set, else the default value.
      * @param  mixed[] $arr
-     * @param  string|int $field
+     * @param  string $field
      * @param  mixed $default
-     * @return mixed
+     * @return EbayEnterprise_Eb2cCore_Helper_Validator
      */
     protected function _nullCoalesce(array $arr, $field, $default)
     {

src/app/code/community/EbayEnterprise/Eb2cCore/Helper/Data.php

Doc Comments +1 added lines, -1 removed lines

@@ -357,7 +357,7 @@
      * getting how long ago a file has been modified or created in minutes
      *
      * @param string $sourceFile
-     * @return int time ago in minutes
+     * @return double time ago in minutes
      */
     public function getFileTimeElapse($sourceFile)
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,8 +13,8 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Api;
 use Psr\Log\LoggerInterface;
+use eBayEnterprise\RetailOrderManagement\Api;
 
 /**
  * Class EbayEnterprise_Eb2cCore_Helper_Data

Spacing +4 added lines, -4 removed lines

@@ -210,7 +210,7 @@ 
      */
     public function extractNodeVal(DOMNodeList $nodeList)
     {
-        return ($nodeList->length)? $nodeList->item(0)->nodeValue : null;
+        return ($nodeList->length) ? $nodeList->item(0)->nodeValue : null;
     }
 
     /**
@@ -222,7 +222,7 @@ 
      */
     public function extractNodeAttributeVal(DOMNodeList $nodeList, $attributeName)
     {
-        return ($nodeList->length)? $nodeList->item(0)->getAttribute($attributeName) : null;
+        return ($nodeList->length) ? $nodeList->item(0)->getAttribute($attributeName) : null;
     }
 
     /**
@@ -482,7 +482,7 @@ 
     {
         $cfg = Mage::helper('eb2ccore')->getConfigModel();
         $ids = explode(',', $appliedRuleIds);
-        $ruleId = !empty($ids)?$ids[0]: 0;
+        $ruleId = !empty($ids) ? $ids[0] : 0;
         return sprintf('%.12s', $cfg->storeId . '-' . $ruleId);
     }
     /**
@@ -590,7 +590,7 @@ 
         if (empty($meta)) {
             return null;
         }
-        $parameters = isset($meta['parameters'])? $meta['parameters'] : [];
+        $parameters = isset($meta['parameters']) ? $meta['parameters'] : [];
         switch ($meta['type']) {
             case 'model':
                 return call_user_func_array([Mage::getModel($meta['class']), $meta['method']], $parameters);

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Helper/Shipping.php

Doc Comments +4 added lines

@@ -125,6 +125,7 @@ 
      * return null if $shippingMethod evaluates to false
      *
      * @param  string
+     * @param string $shippingMethod
      * @return string|null
      */
     public function getMethodTitle($shippingMethod)
@@ -186,6 +187,8 @@ 
      *
      * @param string
      * @param string
+     * @param string $shippingMethod
+     * @param string $displayString
      */
     protected function storeShippingMethodInfo($shippingMethod, $displayString)
     {
@@ -227,6 +230,7 @@ 
      *
      * @param string
      * @param string
+     * @param string $carrierTitle
      * @return string
      */
     protected function buildNameString($carrierTitle, $methodName)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Model/Config/Registry.php

Doc Comments +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
      * Get the configuration flag value represented by the given configKey
      * @param string $configKey
      * @param null|string|bool|int|Mage_Core_Model_Store $store
-     * @return bool
+     * @return string|boolean
      */
     public function getConfig($configKey, $store = null)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Model/Observer.php

Doc Comments +2 added lines, -1 removed lines

@@ -44,7 +44,8 @@
      * @param array
      * @param mixed
      * @param mixed
-     * @return mixed
+     * @param string $key
+     * @return EbayEnterprise_Eb2cCore_Helper_Data
      */
     protected function nullCoalesce(array $arr, $key, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Model/System/Config/Backend/Language/Code.php

Doc Comments +2 added lines, -1 removed lines

@@ -36,7 +36,7 @@ 
 
     /**
      * @param EbayEnterprise_Eb2cCore_Helper_Languages
-     * @return array
+     * @return EbayEnterprise_Eb2cCore_Helper_Languages[]
      */
     protected function _checkTypes(
         EbayEnterprise_Eb2cCore_Helper_Languages $langHelper,
@@ -71,6 +71,7 @@ 
      * is not, throw an exception.
      *
      * @param string
+     * @param string $langCode
      * @return self
      * @throws EbayeEnterprise_Eb2cCore_Exception If value is not a valid language code.
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Test/Base.php

Doc Comments +2 added lines, -2 removed lines

@@ -124,8 +124,8 @@
 
     /**
      * @param  string $alias           model alias
-     * @param  array  $methodActions   mapping of method name to a value or PHPUnit_Framework_MockObject_Stub
-     * @return object                  mock object with specified methods mocked under the 'any' invokation constraint.
+     * @param  array  $methods   mapping of method name to a value or PHPUnit_Framework_MockObject_Stub
+     * @return EcomDev_PHPUnit_Mock_Proxy                  mock object with specified methods mocked under the 'any' invokation constraint.
      */
     protected function _buildModelMock($alias, array $methods = [])
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Eb2cCore/Test/Helper/Api/ValidatorTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
      * Get an eb2ccore helper to translate the messages. Replaces the translate
      * method with a simpler callback that will simply prepend the string
      * "Translated_" to the beginning of the first argument it is passed.
-     * @return Mock_EbayEnterprise_Eb2cCore_Helper_Data
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function _getMockTranslationHelper()
     {

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
         $helper->expects($this->once())
             ->method('__')
             ->will($this->returnCallback(
-                function ($msg) {
+                function($msg) {
                     return 'Translated_' . $msg;
                 }
             ));

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {