eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/PayPal/Block/Payment/Mark.php

Doc Comments -1 removed lines

@@ -83,7 +83,6 @@
      * Supposed to be used on payment methods selection
      * $staticSize is applicable for static images only
      *
-     * @param string $staticSize
      */
     protected function generatePaymentMarkImageUrl()
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/PayPal/Helper/Region.php

Doc Comments +1 added lines

@@ -52,6 +52,7 @@
      * @param  array
      * @param  string|int
      * @param  mixed
+     * @param string $field
      * @return mixed
      */
     protected function nullCoalesce(array $arr, $field, $default)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/PayPal/Model/Express/Api.php

Doc Comments +2 added lines, -1 removed lines

@@ -422,7 +422,7 @@ 
      * Send the request via the sdk
      *
      * @param  IBidirectionalApi
-     * @return Payload
+     * @return IPayload
      *
      * @throws EbayEnterprise_PayPal_Exception
      * @throws UnsupportedOperation
@@ -603,6 +603,7 @@ 
      *
      * @param  string
      * @param  Mage_Sales_Model_Quote
+     * @param string $type
      * @return float
      */
     protected function getTotal($type, Mage_Sales_Model_Quote $quote)

Unused Use Statements +2 added lines, -2 removed lines

@@ -16,9 +16,9 @@
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
 use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
-use eBayEnterprise\RetailOrderManagement\Payload\Payment\IShippingAddress;
-use eBayEnterprise\RetailOrderManagement\Payload\Payment\ILineItemIterable;
 use eBayEnterprise\RetailOrderManagement\Payload\Payment\ILineItemContainer;
+use eBayEnterprise\RetailOrderManagement\Payload\Payment\ILineItemIterable;
+use eBayEnterprise\RetailOrderManagement\Payload\Payment\IShippingAddress;
 
 /**
  * Payment Method for PayPal payments through Retail Order Management.

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/PayPal/Model/Express/Checkout.php

Doc Comments +5 added lines, -5 removed lines

@@ -137,7 +137,7 @@ 
      * default value.
      *
      * @param  array      $arr
-     * @param  string|int $field Valid array key
+     * @param  string $field Valid array key
      * @param  mixed      $default
      * @return mixed
      */
@@ -189,7 +189,7 @@ 
      *
      * @param Mage_Customer_Model_Customer $customer
      *
-     * @return Mage_Paypal_Model_Express_Checkout
+     * @return EbayEnterprise_PayPal_Model_Express_Checkout
      */
     public function setCustomer($customer)
     {
@@ -205,7 +205,7 @@ 
      * @param  Mage_Sales_Model_Quote_Address $billingAddress
      * @param  Mage_Sales_Model_Quote_Address $shippingAddress
      *
-     * @return Mage_Paypal_Model_Express_Checkout
+     * @return EbayEnterprise_PayPal_Model_Express_Checkout
      */
     public function setCustomerWithAddressChange(
         $customer,
@@ -516,7 +516,7 @@ 
     /**
      * Prepare quote for guest checkout order submit
      *
-     * @return Mage_Paypal_Model_Express_Checkout
+     * @return EbayEnterprise_PayPal_Model_Express_Checkout
      */
     protected function _prepareGuestQuote()
     {
@@ -545,7 +545,7 @@ 
      * Prepare quote for customer registration and customer order submit
      * and restore magento customer data from quote
      *
-     * @return Mage_Paypal_Model_Express_Checkout
+     * @return EbayEnterprise_PayPal_Model_Express_Checkout
      */
     protected function _prepareNewCustomerQuote()
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/PayPal/Model/Method/Express.php

Doc Comments +1 added lines, -2 removed lines

@@ -107,7 +107,6 @@ 
      *
      * @param EbayEnterprise_PayPal_Helper_Data             $helper
      * @param EbayEnterprise_Eb2cCore_Helper_Data           $coreHelper
-     * @param Mage_Core_Helper_Http                         $httpHelper
      * @param EbayEnterprise_MageLog_Helper_Data            $logger
      * @param EbayEnterprise_Eb2cCore_Model_Config_Registry $config
      *
@@ -127,7 +126,7 @@ 
      * default value.
      *
      * @param  array      $arr
-     * @param  string|int $field Valid array key
+     * @param  string $field Valid array key
      * @param  mixed      $default
      *
      * @return mixed

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/PayPal/Model/Multishipping.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
      * @param  array
      * @param  string $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @return EbayEnterprise_Paypal_Model_Express_Api
      */
     protected function nullCoalesce(array $arr, $field, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
      * @param array $initParams May have this key:
      *                          - 'multi_shipping' => EbayEnterprise_PayPal_Model_Multishipping
      */
-    public function __construct(array $initParams=[])
+    public function __construct(array $initParams = [])
     {
         list($this->multiShipping) = $this->checkTypes(
             $this->nullCoalesce($initParams, 'multi_shipping', Mage::getModel('ebayenterprise_paypal/multishipping'))

src/app/code/community/EbayEnterprise/PayPal/Model/Observer.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
      * @param  array
      * @param  string $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @return EbayEnterprise_PayPal_Model_Multishipping
      */
     protected function nullCoalesce(array $arr, $field, $default)
     {

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
      * @param array $initParams May have this key:
      *                          - 'multi_shipping' => EbayEnterprise_PayPal_Model_Multishipping
      */
-    public function __construct(array $initParams=[])
+    public function __construct(array $initParams = [])
     {
         list($this->multiShipping) = $this->checkTypes(
             $this->nullCoalesce($initParams, 'multi_shipping', Mage::getModel('ebayenterprise_paypal/multishipping'))

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/PayPal/Test/Model/Express/ApiTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -504,7 +504,7 @@ 
 
     /**
      * stub items for the tests.
-     * @return Mage_Sale_Model_Quote_Item[]
+     * @return EcomDev_PHPUnit_Mock_Proxy[]
      */
     protected function stubQuoteItems()
     {
@@ -718,7 +718,7 @@ 
     /**
      * stub the specified methods on the mock to expect a
      * string argument and return itself
-     * @param  array  $methods
+     * @param  string[]  $methods
      * @param  object $stub
      * @return object
      */

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,11 +13,11 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
+use Psr\Log\NullLogger;
 use eBayEnterprise\RetailOrderManagement\Api;
 use eBayEnterprise\RetailOrderManagement\Payload;
 use eBayEnterprise\RetailOrderManagement\Payload\PayloadMap;
 use eBayEnterprise\RetailOrderManagement\Payload\ValidatorIterator;
-use Psr\Log\NullLogger;
 
 class EbayEnterprise_PayPal_Test_Model_Express_ApiTest extends EbayEnterprise_Eb2cCore_Test_Base
 {

Spacing +2 added lines, -2 removed lines

@@ -566,7 +566,7 @@ 
     protected function isNumeric()
     {
         return $this->callback(
-            function ($val) {
+            function($val) {
 
                 return is_numeric($val);
             }
@@ -708,7 +708,7 @@ 
     protected function isScalar()
     {
         return $this->callback(
-            function ($val) {
+            function($val) {
 
                 return is_scalar($val);
             }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/ProductImageExport/Model/Image/Export.php

Doc Comments +5 added lines, -3 removed lines

@@ -48,7 +48,7 @@ 
      * @param  EbayEnterprise_Eb2cCore_Helper_Data
      * @param  EbayEnterprise_Catalog_Helper_Data
      * @param  EbayEnterprise_Eb2cCore_Model_Config_Registry
-     * @return array
+     * @return EbayEnterprise_Eb2cCore_Model_Config_Registry[]
      */
     protected function _checkTypes(
         EbayEnterprise_Eb2cCore_Helper_Data $coreHelper,
@@ -60,9 +60,9 @@ 
     /**
      * Return the value of field in array if it exists. Otherwise, use the default value.
      * @param  array
-     * @param  string|int $field Valid array key
+     * @param  string $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @return EbayEnterprise_Eb2cCore_Model_Config_Registry
      */
     protected function _nullCoalesce(array $arr, $field, $default)
     {
@@ -237,6 +237,7 @@ 
      * get product image data for product that doesn't exceed the self::SKU_MAX_LENGTH
      * @param  int
      * @param  string
+     * @param integer $storeId
      * @return array
      * Example: [
      *   [
@@ -395,6 +396,7 @@ 
     /**
      * @param  string
      * @param  string
+     * @param string $path
      * @return self
      */
     protected function _updateConfig($path, $value)

Spacing +4 added lines, -4 removed lines

@@ -274,7 +274,7 @@ 
     {
         $media = $product->getMediaGalleryImages();
 
-        return ($media && $media->count())?
+        return ($media && $media->count()) ?
             [
                 'id' => $product->getSku(),
                 'image_data' => $this->_getMediaData($media, $product)
@@ -347,7 +347,7 @@ 
     protected function _getMageImageViewMap(Mage_Catalog_Model_Product $mageProduct)
     {
         $attributes = $mageProduct->getAttributes();
-        return array_reduce(array_keys($attributes), function ($result = [], $key) use ($attributes, $mageProduct) {
+        return array_reduce(array_keys($attributes), function($result = [], $key) use ($attributes, $mageProduct) {
             if (!strcmp($attributes[$key]->getFrontendInput(), EbayEnterprise_ProductImageExport_Model_Image_Export::FRONTEND_INPUT)) {
                 $result[$key] = $mageProduct->getData($key);
             }
@@ -362,11 +362,11 @@ 
      */
     protected function _filterImageViews(array $imageViews)
     {
-        $views = array_filter(array_keys($imageViews), function ($key) use ($imageViews) {
+        $views = array_filter(array_keys($imageViews), function($key) use ($imageViews) {
             return ($imageViews[$key] !== EbayEnterprise_ProductImageExport_Model_Image_Export::FILTER_OUT_VALUE);
         });
 
-        return !empty($views)? $views : [''];
+        return !empty($views) ? $views : [''];
     }
     /**
      * @return Mage_Core_Model_Config_Data

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {