eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Inventory/Test/Model/DetailsTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -329,7 +329,7 @@ 
      * @param  string
      * @param  integer
      * @param  Mage_Catalog_Model_Product
-     * @return Mage_Sales_Model_Quote_Item_Abstract
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function stubItem($id = 1, $sku = 'sku_1', $qty = 1, Mage_Catalog_Model_Product $product = null)
     {
@@ -355,7 +355,7 @@ 
      * stub an address with information required for an item payload
      *
      * @param array
-     * @return Mage_Sales_Model_Quote_Address
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function stubAddress(array $items = [])
     {

Unused Use Statements +1 added lines, -2 removed lines

@@ -13,9 +13,8 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Api\HttpApi;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedOperation;
-use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
+use eBayEnterprise\RetailOrderManagement\Api\HttpApi;
 
 class EbayEnterprise_Inventory_Test_Model_DetailsTest extends EbayEnterprise_Eb2cCore_Test_Base
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 
     public function setUp()
     {
-        $this->logger= $this->getHelperMockBuilder('ebayenterprise_magelog/data')
+        $this->logger = $this->getHelperMockBuilder('ebayenterprise_magelog/data')
             ->disableOriginalConstructor()
             ->getMock();
         $this->logContext = $this->getHelperMockBuilder('ebayenterprise_magelog/context')

src/app/code/community/EbayEnterprise/Inventory/Test/Model/Quantity/ResultsTest.php

Doc Comments +2 added lines

@@ -21,6 +21,8 @@
      *
      * @param string
      * @param int
+     * @param string $sku
+     * @param integer $itemId
      * @return EbayEnterprise_Inventory_Model_Quantity
      */
     protected function _mockQuantityResult($sku, $itemId)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Inventory/Test/Model/Quantity/ServiceTest.php

Doc Comments +6 added lines, -1 removed lines

@@ -124,7 +124,9 @@ 
      * @param int|null
      * @param string
      * @param Mage_Sales_Model_Quote_Item|null
-     * @return Mage_Sales_Model_Quote_Item
+     * @param string $sku
+     * @param integer $qty
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function _mockQuoteItem(
         $sku,
@@ -177,6 +179,9 @@ 
      * @param int
      * @param string
      * @param int
+     * @param integer $quantity
+     * @param string $sku
+     * @param integer|null $itemId
      * @return EbayEnterprise_Inventory_Model_Quantity
      */
     protected function _createQuantity($quantity, $sku, $itemId)

Spacing +3 added lines, -3 removed lines

@@ -199,20 +199,20 @@
     protected function _mockQuantityResults($resultsData)
     {
         $bySku = array_map(
-            function ($result) {
+            function($result) {
                 return [$result['sku'], $result['quantity']];
             },
             $resultsData
         );
         $byId = array_map(
-            function ($result) {
+            function($result) {
                 return [$result['item_id'], $result['quantity']];
             },
             // If an item doesn't have an id, it will not be retrievable
             // by id, so filter out any results that have an empty item id.
             array_filter(
                 $resultsData,
-                function ($result) {
+                function($result) {
                     return (bool) $result['item_id'];
                 }
             )

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Multishipping/Override/Model/Sales/Order.php

Doc Comments +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
      * Sum totals field from each address for the order.
      *
      * @param string
-     * @return float
+     * @return integer
      */
     protected function _sumAddressTotals($totalField)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2015 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2015 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 /** @var Mage_Sales_Model_Resource_Setup */
 $installer = $this;

src/app/code/community/EbayEnterprise/Multishipping/Override/Model/Sales/Order/Address.php

Doc Comments +2 added lines

@@ -110,6 +110,7 @@ 
      * Retrieve item object by quote item Id
      *
      * @param int
+     * @param integer $itemId
      * @return Mage_Sales_Model_Orders_Item
      */
     public function getItemByQuoteItemId($itemId)
@@ -121,6 +122,7 @@ 
      * Remove item from collection
      *
      * @param int
+     * @param integer $itemId
      * @return self
      */
     public function removeItem($itemId)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2015 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2015 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 /** @var Mage_Sales_Model_Resource_Setup */
 $installer = $this;

src/app/code/community/EbayEnterprise/Multishipping/Test/Helper/FactoryTest.php

Doc Comments +3 added lines, -1 removed lines

@@ -29,7 +29,9 @@
      * @param bool
      * @param int
      * @param string
-     * @return Mage_Sales_Model_Order_Address
+     * @param integer $addressId
+     * @param integer $orderId
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function _stubAddress($addressId, $isPrimaryShipping, $orderId, $addressType)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Multishipping/Test/Model/Override/Sales/Order/AddressTest.php

Doc Comments +2 added lines

@@ -34,6 +34,8 @@
      *
      * @param int
      * @param int
+     * @param integer $addressId
+     * @param integer $orderId
      * @return EbayEnterprise_Multishipping_Override_Model_Sales_Order_Address
      */
     protected function _getPrimaryShippingAddress($addressId, $orderId)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Multishipping/Test/Model/Override/Sales/Service/QuoteTest.php

Doc Comments +4 added lines, -3 removed lines

@@ -119,7 +119,7 @@ 
      * Create a stub order address with the provided address type.
      *
      * @param string
-     * @return Mage_Sales_Model_Order_Address
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function _stubOrderAddress($type)
     {
@@ -133,7 +133,7 @@ 
      *
      * @param string
      * @param Mage_Sales_Model_Quote_Item_Abstract[]
-     * @return Mage_Sales_Model_Quote_Address
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function _stubQuoteAddress($type, array $items = [])
     {
@@ -149,7 +149,8 @@ 
      *
      * @param string|null
      * @param Mage_Sales_Model_Quote_Item_Abstract|null
-     * @return Mage_Sales_Model_Quote_Item_Abstract
+     * @param string $productType
+     * @return EcomDev_PHPUnit_Mock_Proxy
      */
     protected function _stubQuoteItem(
         $productType = null,

Spacing +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
 
         $this->_checkoutDispatcher = $this->getHelperMock(
             'ebayenterprise_multishipping/dispatcher_interface',
-            ['dispatchBeforeOrderSubmit', 'dispatchOrderSubmitSuccess', 'dispatchOrderSubmitFailure', 'dispatchAfterOrderSubmit',],
+            ['dispatchBeforeOrderSubmit', 'dispatchOrderSubmitSuccess', 'dispatchOrderSubmitFailure', 'dispatchAfterOrderSubmit', ],
             true
         );
         $this->_multishippingFactory = $this->getHelperMock(
@@ -64,7 +64,7 @@ 
         );
         $this->_quoteConvertor = $this->getModelMock(
             'sales/convert_quote',
-            ['toOrder', 'addressToOrderAddress', 'itemToOrderItem', 'paymentToOrderPayment',]
+            ['toOrder', 'addressToOrderAddress', 'itemToOrderItem', 'paymentToOrderPayment', ]
         );
         $this->_transaction = $this->getModelMock(
             'core/resource_transaction',

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/controllers/OrderController.php

Doc Comments +1 added lines, -1 removed lines

@@ -350,7 +350,7 @@
     /**
      * Ensure the proper data exist in before proceeding to show the current page.
      *
-     * @return self
+     * @return boolean
      */
     protected function _isValidOperation()
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {