eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Inventory/Model/Allocation/Allocator.php

Doc Comments +3 added lines, -1 removed lines

@@ -68,6 +68,7 @@ 
      * @param  string
      * @param  array
      * @param  mixed
+     * @param string $key
      * @return mixed
      */
     protected function nullCoalesce($key, array $arr, $default)
@@ -306,6 +307,7 @@ 
      *
      * @param Reservation
      * @param array
+     * @param EbayEnterprise_Inventory_Model_Allocation_Reservation $reservation
      * @return
      */
     protected function createResult($reservation, array $allocations = [])
@@ -323,7 +325,7 @@ 
      * wrap the allocation model factory method in an anonymous function
      * to allow public invocation.
      *
-     * @return callable
+     * @return Closure
      */
     protected function createAllocationFactoryCallback()
     {

Unused Use Statements +2 added lines, -2 removed lines

@@ -13,14 +13,14 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedHttpAction;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedOperation;
+use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
+use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IAllocatedItem;
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IAllocationReply;
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IAllocationRequest;
-use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IAllocatedItem;
 
 class EbayEnterprise_Inventory_Model_Allocation_Allocator
 {

Spacing +1 added lines, -1 removed lines

@@ -327,7 +327,7 @@
      */
     protected function createAllocationFactoryCallback()
     {
-        return function ($payload) {
+        return function($payload) {
             return $this->createAllocationFromPayload($payload);
         };
     }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Inventory/Model/Allocation/Deallocator.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,10 +13,10 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedHttpAction;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedOperation;
+use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
 
 class EbayEnterprise_Inventory_Model_Allocation_Deallocator

Doc Comments +1 added lines

@@ -83,6 +83,7 @@
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce(array $arr, $key, $default)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Inventory/Model/Allocation/Result.php

Doc Comments +3 added lines, -3 removed lines

@@ -79,7 +79,7 @@ 
     /**
      * get all allocations
      *
-     * @return array
+     * @return EbayEnterprise_Inventory_Model_Allocation[]
      */
     public function getAllocations()
     {
@@ -89,7 +89,7 @@ 
     /**
      * get the reservation the results are for
      *
-     * @return EbayEnterprise_Inventory_Allocation_Reservation
+     * @return EbayEnterprise_Inventory_Model_Allocation_Reservation
      */
     public function getReservation()
     {
@@ -110,7 +110,7 @@ 
     /**
      * the callback used to create an allocation object.
      *
-     * @return callable
+     * @return Closure
      */
     protected function getAllocationFactoryCallback()
     {

Spacing +1 added lines, -1 removed lines

@@ -114,7 +114,7 @@
      */
     protected function getAllocationFactoryCallback()
     {
-        return function (array $allocationData) {
+        return function(array $allocationData) {
             return $this->createAllocation($allocationData);
         };
     }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Inventory/Model/Details.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,10 +13,10 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Api\HttpApi;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\NetworkError;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedHttpAction;
 use eBayEnterprise\RetailOrderManagement\Api\Exception\UnsupportedOperation;
+use eBayEnterprise\RetailOrderManagement\Api\HttpApi;
 use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
 
 class EbayEnterprise_Inventory_Model_Details

Doc Comments +1 added lines

@@ -83,6 +83,7 @@
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce(array $arr, $key, $default)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Inventory/Model/Details/Item.php

Doc Comments +2 added lines, -2 removed lines

@@ -79,7 +79,7 @@ 
      * Identifier for an order item.
      *
      * restrictions: 1 <= length <= 39, unique in request
-     * @return string
+     * @return integer
      */
     public function getItemId()
     {
@@ -150,7 +150,7 @@ 
     /**
      * Indicates if the delivery estimate should be displayed.
      *
-     * @return DateTime
+     * @return boolean
      */
     public function getDeliveryEstimateDisplayFlag()
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Inventory/Model/Details/Request/Builder/Abstract.php

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
      *
      * @param  Mage_Sales_Model_Quote_Item_Abstract
      * @param  Mage_Customer_Model_Address_Abstract
-     * @return IInStorePickUpItem|null
+     * @return Payload\Inventory\IInStorePickUpItemIterable|null
      */
     protected function getIspuItem(
         Mage_Sales_Model_Quote_Item_Abstract $item,

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
  */
 
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IInStorePickUpItem;
-use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IShippingItem;
 use eBayEnterprise\RetailOrderManagement\Payload\Inventory\IInventoryDetailsRequest;
 
 abstract class EbayEnterprise_Inventory_Model_Details_Request_Builder_Abstract

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Inventory/Model/Order/Create/Item/Allocation.php

Doc Comments +1 added lines, -5 removed lines

@@ -37,11 +37,6 @@ 
     protected $logContext;
 
     /**
-     * @param array $args May contain:
-     *                    - helper => EbayEnterprise_Inventory_Helper_Data
-     *                    - allocation_service => EbayEnterprise_Inventory_Model_Allocation_Service
-     *                    - logger => EbayEnterprise_MageLog_Helper_Data
-     *                    - log_context => EbayEnterprise_MageLog_Helper_Context
      */
     public function __construct(array $init = [])
     {
@@ -86,6 +81,7 @@ 
      * @param array
      * @param string
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function nullCoalesce(array $arr, $key, $default)

Indentation +19 added lines, -19 removed lines

@@ -1,17 +1,17 @@ 
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 use \eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderItem;
 
@@ -182,13 +182,13 @@ 
             && $allocation->getQuantityAllocated() < $item->getQtyOrdered();
     }
 
-     /**
-     * Determine if the passed in item is backorderable.
-     *
-     * @param  Mage_Core_Model_Abstract
-     * @param  int
-     * @return bool
-     */
+        /**
+         * Determine if the passed in item is backorderable.
+         *
+         * @param  Mage_Core_Model_Abstract
+         * @param  int
+         * @return bool
+         */
     protected function isBackorderable(Mage_Core_Model_Abstract $item)
     {
         return $this->getStockItem($item)->getBackorders() > Mage_CatalogInventory_Model_Stock::BACKORDERS_NO;

src/app/code/community/EbayEnterprise/Inventory/Model/Order/Create/Item/Details.php

Doc Comments +2 added lines, -1 removed lines

@@ -72,6 +72,7 @@ 
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function nullCoalesce(array $arr, $key, $default)
@@ -83,7 +84,7 @@ 
      * Enforce type checks for the config key in the constructors parameter array $args.
      *
      * @param EbayEnterprise_Eb2cCore_Model_Config_Registry
-     * @return array
+     * @return EbayEnterprise_Eb2cCore_Model_Config_Registry[]
      */
     protected function checkConfigTypes(EbayEnterprise_Eb2cCore_Model_Config_Registry $config)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Inventory/Model/Quantity/Collector.php

Doc Comments +3 added lines, -1 removed lines

@@ -85,6 +85,7 @@ 
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function nullCoalesce(array $arr, $key, $default)
@@ -120,7 +121,7 @@ 
      * if they are valid and apply to the current state of the provided items.
      *
      * @param Mage_Sales_Model_Quote_Item[]
-     * @return EbayEnterprise_Inventory_Model_Quantity_Restults|null
+     * @return EbayEnterprise_Inventory_Model_Quantity_IResults|null
      */
     protected function getSessionResults(array $items)
     {
@@ -135,6 +136,7 @@ 
      * Request new quantity results.
      *
      * @param Mage_Sales_Model_Quote_Item[]
+     * @param Mage_Sales_Model_Quote_Item_Abstract[] $items
      * @return EbayEnterprise_Inventory_Model_Quantity_Restults
      */
     protected function requestNewResults($items)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {