eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Order/Model/Detail/Process/Response.php

Unused Use Statements +4 added lines, -4 removed lines

@@ -14,14 +14,14 @@
  */
 
 use eBayEnterprise\RetailOrderManagement\Payload\IPayload;
-use eBayEnterprise\RetailOrderManagement\Payload\Order\Detail\IOrderDetailResponse;
-use eBayEnterprise\RetailOrderManagement\Payload\Order\IMailingAddress;
-use eBayEnterprise\RetailOrderManagement\Payload\Order\IEmailAddressDestination;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\Detail\IOrderDetailItem;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\Detail\IOrderDetailResponse;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\Detail\IOrderDetailStoredValueCardPayment;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\Detail\IShipment;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\IEmailAddressDestination;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\IMailingAddress;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IPayment;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IShipGroup;
-use eBayEnterprise\RetailOrderManagement\Payload\Order\Detail\IOrderDetailStoredValueCardPayment;
 
 class EbayEnterprise_Order_Model_Detail_Process_Response extends Mage_Sales_Model_Order implements EbayEnterprise_Order_Model_Detail_Process_IResponse
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Model/Detail/Process/Response/Shipgroup.php

Doc Comments +3 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
      *
      * @param  EbayEnterprise_Order_Model_Detail_Process_IResponse
      * @param  EbayEnterprise_Eb2cCore_Helper_Data
-     * @return array
+     * @return EbayEnterprise_Order_Model_Detail_Process_IResponse[]
      */
     protected function _checkTypes(
         EbayEnterprise_Order_Model_Detail_Process_IResponse $order,
@@ -63,7 +63,7 @@ 
      * @param  array
      * @param  string $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @return EbayEnterprise_Eb2cCore_Helper_Data
      */
     protected function _nullCoalesce(array $arr, $field, $default)
     {
@@ -130,6 +130,7 @@ 
      * Build a collection of order item from this particular ship group
      *
      * @param bool
+     * @param boolean $includeHidden
      * @return Varien_Data_Collection
      */
     protected function _buildItemsCollection($includeHidden)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Model/Observer.php

Doc Comments +2 added lines

@@ -99,6 +99,7 @@ 
      * @param  string
      * @param  array
      * @param  mixed
+     * @param string $key
      * @return mixed
      */
     protected function nullCoalesce($key, array $ar, $default)
@@ -280,6 +281,7 @@ 
      * the document.
      *
      * @param  string
+     * @param string $xml
      * @return Varien_Data_Collection
      */
     protected function loadOrdersFromXml($xml)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Model/Ordershipped.php

Doc Comments +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
     /**
      * Return the value at field in array if it exists. Otherwise, use the default value.
      * @param  array $arr
-     * @param  string|int $field Valid array key
+     * @param  string $field Valid array key
      * @param  mixed $default
      * @return mixed
      */

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Payload;
 use eBayEnterprise\RetailOrderManagement\Payload\OrderEvents;
 
 class EbayEnterprise_Order_Model_Ordershipped

src/app/code/community/EbayEnterprise/Order/Model/Search.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -12,9 +12,9 @@
  * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
+use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 use eBayEnterprise\RetailOrderManagement\Payload\Customer\IOrderSummaryRequest;
 use eBayEnterprise\RetailOrderManagement\Payload\Customer\IOrderSummaryResponse;
-use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
 
 class EbayEnterprise_Order_Model_Search implements EbayEnterprise_Order_Model_ISearch
 {

src/app/code/community/EbayEnterprise/Order/Model/Search/Process/Response.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,8 +13,8 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Payload\Customer\IOrderSummaryResponse;
 use eBayEnterprise\RetailOrderManagement\Payload\Customer\IOrderSummaryIterable;
+use eBayEnterprise\RetailOrderManagement\Payload\Customer\IOrderSummaryResponse;
 
 class EbayEnterprise_Order_Model_Search_Process_Response implements EbayEnterprise_Order_Model_Search_Process_IResponse
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Model/System/Config/Source/Emailer.php

Doc Comments +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
      * Type hinting for self::__construct $initParams
      *
      * @param  EbayEnterprise_Order_Helper_Data
-     * @return array
+     * @return EbayEnterprise_Order_Helper_Data[]
      */
     protected function _checkTypes(EbayEnterprise_Order_Helper_Data $orderHelper)
     {
@@ -42,7 +42,7 @@ 
      * @param  array
      * @param  string $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @return EbayEnterprise_Order_Helper_Data
      */
     protected function _nullCoalesce(array $arr, $field, $default)
     {

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
     public function toOptionArray()
     {
         $arr = $this->toArray();
-        return array_map(function ($k) use ($arr) {
+        return array_map(function($k) use ($arr) {
             return ['value' => $k, 'label' => $arr[$k]];
         }, array_keys($arr));
     }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Overrides/Block/Checkout/Multishipping/Success.php

Doc Comments +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
      * @param  array
      * @param  string $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @return EbayEnterprise_Order_Helper_Factory
      */
     protected function nullCoalesce(array $arr, $field, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Overrides/Block/Order/Abstract.php

Doc Comments +2 added lines, -1 removed lines

@@ -53,7 +53,7 @@ 
      *
      * @param  EbayEnterprise_Order_Helper_Data
      * @param  Mage_Core_Helper_Data
-     * @return array
+     * @return Mage_Core_Helper_Data[]
      */
     protected function _checkTypes(
         EbayEnterprise_Order_Helper_Data $orderHelper,
@@ -79,6 +79,7 @@ 
      * @see Mage_Core_Block_Abstract::getHelper()
      * Returns a helper instance.
      *
+     * @param string $type
      * @return EbayEnterprise_Order_Helper_Data
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {