eBayEnterprise / RetailOrderManagement-SDK

src/eBayEnterprise/RetailOrderManagement/Payload/TaxDutyFee/TaxDutyFeeQuoteRequest.php

Unused Use Statements -5 removed lines

@@ -15,19 +15,14 @@
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee;
 
-use DateTime;
-use DOMXPath;
 use eBayEnterprise\RetailOrderManagement\Payload\IPayload;
 use eBayEnterprise\RetailOrderManagement\Payload\IPayloadMap;
 use eBayEnterprise\RetailOrderManagement\Payload\ISchemaValidator;
 use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
 use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
 use eBayEnterprise\RetailOrderManagement\Payload\TTopLevelPayload;
-
 use eBayEnterprise\RetailOrderManagement\Payload\Checkout\TDestinationContainer;
-
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 class TaxDutyFeeQuoteRequest implements ITaxDutyFeeQuoteRequest
 {

Spacing +1 added lines, -1 removed lines

@@ -225,7 +225,7 @@
 
     protected function serializeVatInclusivePricing()
     {
-        $flag =$this->getVatInclusivePricingFlag();
+        $flag = $this->getVatInclusivePricingFlag();
         if ($flag === true || $flag === false) {
             $flag = $this->convertBooleanToString($flag);
             return "<VATInclusivePricing>$flag</VATInclusivePricing>";

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2014-2015 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2014-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2014-2015 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2014-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TaxDutyFee/TaxedOrderItem.php

Unused Use Statements -5 removed lines

@@ -15,18 +15,13 @@
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee;
 
-use DateTime;
-use DOMXPath;
-use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
 use eBayEnterprise\RetailOrderManagement\Payload\IPayload;
 use eBayEnterprise\RetailOrderManagement\Payload\IPayloadMap;
 use eBayEnterprise\RetailOrderManagement\Payload\ISchemaValidator;
 use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
 use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
-use eBayEnterprise\RetailOrderManagement\Payload\TIdentity;
 use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 class TaxedOrderItem implements ITaxedOrderItem
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TaxDutyFee/TaxedPriceGroup.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\Payment\TAmount;
 use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 class TaxedPriceGroup implements ITaxedPriceGroup
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Validator\Order;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TaxDutyFee/TCustomizationBase.php

Unused Use Statements -10 removed lines

@@ -15,16 +15,6 @@
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee;
 
-use eBayEnterprise\RetailOrderManagement\Payload\IPayload;
-use eBayEnterprise\RetailOrderManagement\Payload\IPayloadMap;
-use eBayEnterprise\RetailOrderManagement\Payload\ISchemaValidator;
-use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
-use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
-use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
-use eBayEnterprise\RetailOrderManagement\Payload\TIdentity;
-use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
-
 trait TCustomizationBase
 {
     /** @var string */

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Validator\Order;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TaxDutyFee/TGiftingBase.php

Doc Comments +1 added lines

@@ -110,6 +110,7 @@
      *
      * @param string
      * @param string
+     * @param string $name
      * @return string
      */
     abstract protected function serializeOptionalXmlEncodedValue($name, $value);

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TaxDutyFee/TOrderItem.php

Unused Use Statements -10 removed lines

@@ -15,18 +15,8 @@
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee;
 
-use DateTime;
 use DOMXPath;
-use eBayEnterprise\RetailOrderManagement\Payload\Exception\InvalidPayload;
 use eBayEnterprise\RetailOrderManagement\Payload\IPayload;
-use eBayEnterprise\RetailOrderManagement\Payload\IPayloadMap;
-use eBayEnterprise\RetailOrderManagement\Payload\ISchemaValidator;
-use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
-use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
-use eBayEnterprise\RetailOrderManagement\Payload\TIdentity;
-use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
-
-use Psr\Log\LoggerInterface;
 
 trait TOrderItem
 {

Spacing +1 added lines, -1 removed lines

@@ -161,7 +161,7 @@
         foreach ($itemPrices as $property => $extractionPath) {
             $priceNode = $xpath->query($extractionPath)->item(0);
             if ($priceNode) {
-                $getter = $priceGroupGetters[$property];
+                $getter = $priceGroupGetters[ $property ];
                 $this->$property = $this->$getter()->deserialize($priceNode->C14N());
             }
         }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TaxDutyFee/TPriceGroup.php

Doc Comments +3 added lines

@@ -29,6 +29,9 @@
         return $this->amount;
     }
 
+    /**
+     * @param double $amount
+     */
     public function setAmount($amount)
     {
         $this->amount = $this->sanitizeAmount($amount);

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Validator\Order;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TIterablePayload.php

Unused Use Statements -2 removed lines

@@ -15,8 +15,6 @@
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 
-use DOMDocument;
-use DOMXPath;
 use eBayEnterprise\RetailOrderManagement\Payload\IPayload;
 
 trait TIterablePayload

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TPayload.php

Doc Comments +10 added lines, -1 removed lines

@@ -186,6 +186,7 @@ 
      * be overridden by payloads that need it.
      *
      * @param string
+     * @param string $serializedPayload
      * @return self
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
@@ -280,6 +281,9 @@ 
         return $this->parentPayload;
     }
 
+    /**
+     * @param string $type
+     */
     protected function getAncestorPayloadOfType($type)
     {
         $pl = $this;
@@ -321,7 +325,7 @@ 
     /**
      * Name, value pairs of root attributes
      *
-     * @return array
+     * @return callable
      */
     protected function getRootAttributes()
     {
@@ -355,6 +359,7 @@ 
      *
      * @param string
      * @param mixed
+     * @param string $attributeName
      * @return string
      */
     protected function serializeOptionalAttribute($attributeName, $value)
@@ -368,6 +373,7 @@ 
      *
      * @param string
      * @param float
+     * @param string $nodeName
      * @return string
      */
     protected function serializeOptionalAmount($nodeName, $amount)
@@ -384,6 +390,8 @@ 
      * @param string
      * @param string
      * @param DateTime
+     * @param string $nodeName
+     * @param string $format
      * @return string
      */
     protected function serializeOptionalDateValue($nodeName, $format, DateTime $date = null)
@@ -420,6 +428,7 @@ 
      *
      * @param string
      * @param string
+     * @param string $name
      * @return string
      */
     protected function serializeOptionalXmlEncodedValue($name, $value)

Spacing +13 added lines, -13 removed lines

@@ -41,20 +41,20 @@ 
     /** @var IPayload */
     protected $parentPayload;
     /** @var array XPath expressions to extract required data from the serialized payload (XML) */
-    protected $extractionPaths = [];
+    protected $extractionPaths = [ ];
     /** @var array */
-    protected $optionalExtractionPaths = [];
+    protected $optionalExtractionPaths = [ ];
     /** @var array property/XPath pairs that take boolean values */
-    protected $booleanExtractionPaths = [];
+    protected $booleanExtractionPaths = [ ];
     /** @var array pair address lines properties with xpaths for extraction */
-    protected $addressLinesExtractionMap = [];
+    protected $addressLinesExtractionMap = [ ];
     /** @var array extracting node value and assigned the property as DateTime */
-    protected $datetimeExtractionPaths = [];
+    protected $datetimeExtractionPaths = [ ];
     /**
      * @var array property/XPath pairs. if property is a payload, first node matched
      *            will be deserialized by that payload
      */
-    protected $subpayloadExtractionPaths = [];
+    protected $subpayloadExtractionPaths = [ ];
     /** @var LoggerInterface enabled PSR-3 logging */
     protected $logger;
     /** @var bool flag to determine to either serialize empty node not or to serialize empty node. */
@@ -156,8 +156,8 @@ 
     protected function addressLinesFromXPath(\DOMXPath $domXPath)
     {
         foreach ($this->addressLinesExtractionMap as $address) {
-            $lines = $domXPath->query($address['xPath']);
-            $property = $address['property'];
+            $lines = $domXPath->query($address[ 'xPath' ]);
+            $property = $address[ 'property' ];
             $this->$property = $this->addressLinesFromNodeList($lines);
         }
     }
@@ -172,9 +172,9 @@ 
      */
     protected function addressLinesFromNodeList(\DOMNodeList $lines)
     {
-        $result = [];
+        $result = [ ];
         foreach ($lines as $line) {
-            $result[] = $line->nodeValue;
+            $result[ ] = $line->nodeValue;
         }
         return $result ?: null;
     }
@@ -304,8 +304,8 @@ 
     protected function serializeRootAttributes()
     {
         $rootAttributes = $this->getRootAttributes();
-        $qualifyAttributes = function ($name) use ($rootAttributes) {
-            return sprintf('%s="%s"', $name, $this->xmlEncode($rootAttributes[$name]));
+        $qualifyAttributes = function($name) use ($rootAttributes) {
+            return sprintf('%s="%s"', $name, $this->xmlEncode($rootAttributes[ $name ]));
         };
         $qualifiedAttributes = array_map($qualifyAttributes, array_keys($rootAttributes));
         return implode(' ', $qualifiedAttributes);
@@ -325,7 +325,7 @@ 
      */
     protected function getRootAttributes()
     {
-        return [];
+        return [ ];
     }
 
     /**

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;