eBayEnterprise / RetailOrderManagement-SDK

src/eBayEnterprise/RetailOrderManagement/Payload/Payment/PayPalDoAuthorizationRequest.php

Doc Comments +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
      *
      * xsd note: minimum value 0
      *           maximum precision 2 decimal places
-     * @return float
+     * @return string
      */
     public function getAmount()
     {

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\Payment\TAmount;
 use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 class TaxedPriceGroup implements ITaxedPriceGroup
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/Payment/StoredValueRedeemReply.php

Doc Comments +3 added lines

@@ -251,6 +251,9 @@
      * @param string
      * @param float
      * @param string
+     * @param string $amountType
+     * @param double $amount
+     * @param string $currencyCode
      * @return string
      */
     protected function serializeAmounts($amountType, $amount, $currencyCode)

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\Payment\TAmount;
 use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 class TaxedPriceGroup implements ITaxedPriceGroup
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 
     protected $responseCode;
     /** @var array response codes that are considered a success */
-    protected $successResponseCodes = ['Success'];
+    protected $successResponseCodes = [ 'Success' ];
 
     /**
      * @param IValidatorIterator

src/eBayEnterprise/RetailOrderManagement/Payload/Payment/TenderType/LookupReply.php

Doc Comments +2 added lines

@@ -76,6 +76,7 @@ 
 
     /**
      * @param string
+     * @param string $tenderType
      * @return self
      */
     public function setTenderType($tenderType)
@@ -96,6 +97,7 @@ 
 
     /**
      * @param string
+     * @param string $responseCode
      * @return self
      */
     public function setResponseCode($responseCode)

Spacing +3 added lines, -3 removed lines

@@ -109,8 +109,8 @@ 
      */
     public function getResponseMessage()
     {
-        return isset($this->responseCodeMessage[$this->getResponseCode()])
-            ? $this->responseCodeMessage[$this->getResponseCode()]
+        return isset($this->responseCodeMessage[ $this->getResponseCode() ])
+            ? $this->responseCodeMessage[ $this->getResponseCode() ]
             : '';
     }
 
@@ -130,7 +130,7 @@ 
 
     protected function validateResponseCode()
     {
-        if (!isset($this->responseCodeMessage[$this->getResponseCode()])) {
+        if (!isset($this->responseCodeMessage[ $this->getResponseCode() ])) {
             throw new InvalidPayload("Unrecognized response code '{$this->getResponseCode()}'");
         }
     }

src/eBayEnterprise/RetailOrderManagement/Payload/Payment/TLineItemContainer.php

Doc Comments +7 added lines

@@ -86,6 +86,7 @@ 
 
     /**
      * @param float
+     * @param double $amount
      * @return self
      */
     public function setLineItemsTotal($amount)
@@ -134,6 +135,11 @@ 
         return $this;
     }
 
+    /**
+     * @param string $nodeName
+     * @param double $amount
+     * @param string|null $currencyCode
+     */
     abstract protected function serializeCurrencyAmount($nodeName, $amount, $currencyCode);
     abstract protected function sanitizeAmount($amount);
 
@@ -206,6 +212,7 @@ 
      * otherwise simply return the null parameter.
      *
      * @param string|null
+     * @param string $value
      * @return string|null
      */
     abstract protected function xmlEncode($value = null);

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TaxDutyFee/AbstractCustomization.php

Unused Use Statements -2 removed lines

@@ -21,8 +21,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
 use eBayEnterprise\RetailOrderManagement\Payload\PayloadFactory;
 use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
-use eBayEnterprise\RetailOrderManagement\Payload\TIdentity;
-
 use Psr\Log\LoggerInterface;
 
 abstract class AbstractCustomization

Spacing +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
 
     protected function getRootAttributes()
     {
-        return $this->getId() ? ['id' => $this->getId()] : [];
+        return $this->getId() ? [ 'id' => $this->getId() ] : [ ];
     }
 
     protected function getRootNodeName()

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Validator\Order;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TaxDutyFee/DestinationIterable.php

Doc Comments +1 added lines, -1 removed lines

@@ -106,7 +106,7 @@
     /**
      * Get a new, empty store location destination object.
      *
-     * @return IStoreLocation
+     * @return IPayload
      */
     public function getEmptyStoreLocation()
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TaxDutyFee/Discount.php

Doc Comments +1 added lines

@@ -102,6 +102,7 @@
 
     /**
      * @param float
+     * @param double $amount
      * @return self
      */
     public function setAmount($amount)

Spacing +3 added lines, -3 removed lines

@@ -152,13 +152,13 @@
      */
     protected function getRootAttributes()
     {
-        $attrs = [];
+        $attrs = [ ];
         if ($this->getId()) {
-            $attrs['id'] = $this->getId();
+            $attrs[ 'id' ] = $this->getId();
         }
         $flag = $this->getCalculateDutyFlag();
         if ($flag === true || $flag === false) {
-            $attrs['calculateDuty'] = $this->convertBooleanToString($this->getCalculateDutyFlag());
+            $attrs[ 'calculateDuty' ] = $this->convertBooleanToString($this->getCalculateDutyFlag());
         }
         return $attrs;
     }

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 use eBayEnterprise\RetailOrderManagement\Payload\Payment\TAmount;
 use eBayEnterprise\RetailOrderManagement\Payload\TPayload;
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 class TaxedPriceGroup implements ITaxedPriceGroup
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2014-2015 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2014-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2014-2015 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2014-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TaxDutyFee/EmailAddressDestination.php

Unused Use Statements -3 removed lines

@@ -15,15 +15,12 @@
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee;
 
-use eBayEnterprise\RetailOrderManagement\Payload\Checkout\TPersonName;
 use eBayEnterprise\RetailOrderManagement\Payload\IPayload;
 use eBayEnterprise\RetailOrderManagement\Payload\IPayloadMap;
 use eBayEnterprise\RetailOrderManagement\Payload\ISchemaValidator;
 use eBayEnterprise\RetailOrderManagement\Payload\IValidatorIterator;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\EmailAddressDestination as OrderEmailAddressDestination;
-
 use Psr\Log\LoggerInterface;
-use Psr\Log\NullLogger;
 
 class EmailAddressDestination extends OrderEmailAddressDestination implements IEmailAddressDestination
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2015 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\Validator\Order;
 

src/eBayEnterprise/RetailOrderManagement/Payload/TaxDutyFee/OrderItemRequest.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 
 namespace eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee;
 
-use DOMXPath;
 use eBayEnterprise\RetailOrderManagement\Payload\IPayload;
 use eBayEnterprise\RetailOrderManagement\Payload\IPayloadMap;
 use eBayEnterprise\RetailOrderManagement\Payload\ISchemaValidator;

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 namespace eBayEnterprise\RetailOrderManagement\Payload;