Dynamic\Staff\Pages\StaffDirectoryController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	PaginatedList()	0	15	3
A	getPageSize()	0	7	2
A	GroupedList()	0	8	1

<?php

namespace Dynamic\Staff\Pages;

use PageController;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\ORM\GroupedList;
use SilverStripe\ORM\PaginatedList;

/**
 * Class StaffDirectoryController
 * @package Dynamic\Staff\Pages
 */
class StaffDirectoryController extends PageController
{
    /**
     * @return int
     */
    public function getPageSize()
    {
        if ($object = $this->config()->page_size) {
            return (int)$object;
        }

        return 10;
    }

    /**
     * @param HTTPRequest|null $request
     *
     * @return PaginatedList
     */
    public function PaginatedList(HTTPRequest $request = null)
    {
        if ($request === null) {
            $request = $this->request;
        }
        $start = ($request->getVar('start')) ? (int)$request->getVar('start') : 0;

        $records = PaginatedList::create($this->getStaffMembers(), $this->request);

The method getStaffMembers() does not exist on Dynamic\Staff\Pages\StaffDirectoryController. Since you implemented __call, consider adding a @method annotation.

        $records->setPageStart($start);
        $records->setPageLength($this->getPageSize());

        // allow $records to be updated via extension
        $this->extend('updatePaginatedList', $records);

        return $records;
    }

    /**
     * @return GroupedList
     */
    public function GroupedList()
    {
        $records = GroupedList::create($this->getStaffMembers());

        // allow $records to be updated via extension
        $this->owner->extend('updateGroupedList', $records);

The method extend() does not exist on null.

The property owner does not exist on Dynamic\Staff\Pages\StaffDirectoryController. Since you implemented __get, consider adding a @property annotation.

        return $records;
    }
}