dynamic / silverstripe-salsify

tests/ORM/SalsifyIDExtensionTest.php

<?php

namespace Dynamic\Salsify\Tests\Model\ORM;

use Dynamic\Salsify\ORM\SalsifyIDExtension;
use Dynamic\Salsify\Tests\TestOnly\MappedObject;
use Dynamic\Salsify\Tests\TestOnly\TestController;
use SilverStripe\CMS\Forms\SiteTreeURLSegmentField;

The type SilverStripe\CMS\Forms\SiteTreeURLSegmentField was not found. Maybe you did not declare it correctly or list all dependencies?

use SilverStripe\Control\HTTPRequest;
use SilverStripe\Control\Session;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\FormAction;
use SilverStripe\Forms\FormField;

/**
 * Class SalsifyIDExtensionTest
 * @package Dynamic\Salsify\Tests\Model\ORM
 */
class SalsifyIDExtensionTest extends SapphireTest
{
    /**
     * @var array
     */
    protected static $extra_dataobjects = [
        MappedObject::class,
    ];

    /**
     * @var array
     */
    protected static $extra_controllers = [
        TestController::class,
    ];

    /**
     * @var array
     */
    protected static $required_extensions = [
        MappedObject::class => [
            SalsifyIDExtension::class,
        ],
    ];

    /**
     *
     */
    public function testUpdateCMSFieldsWithID()
    {
        /** @var MappedObject|SalsifyIDExtension $object */
        $object = MappedObject::create();
        $object->SalsifyID = '001';

The property SalsifyID does not exist on Dynamic\Salsify\Tests\TestOnly\MappedObject. Since you implemented __set, consider adding a @property annotation.

        $fields = $object->getCMSFields();

The method getCMSFields() does not exist on Dynamic\Salsify\ORM\SalsifyIDExtension.

        $this->assertInstanceOf(FieldList::class, $fields);
        $this->assertInstanceOf(FormField::class, $fields->fieldByName('SalsifyID'));

Are you sure the usage of $fields->fieldByName('SalsifyID') targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

        $this->assertEquals(SiteTreeURLSegmentField::class, $fields->fieldByName('SalsifyID')->getTemplate());

Are you sure the usage of $fields->fieldByName('SalsifyID') targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

    }

    /**
     *
     */
    public function testUpdateCMSFieldsWithoutID()
    {
        /** @var MappedObject|SalsifyIDExtension $object */
        $object = MappedObject::create();
        $fields = $object->getCMSFields();
        $this->assertInstanceOf(FieldList::class, $fields);
        $this->assertInstanceOf(FormField::class, $fields->fieldByName('SalsifyID'));

Are you sure the usage of $fields->fieldByName('SalsifyID') targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

        $this->assertNotEquals(SiteTreeURLSegmentField::class, $fields->fieldByName('SalsifyID'));

Are you sure the usage of $fields->fieldByName('SalsifyID') targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

    }

    /**
     *
     */
    public function testUpdateCMSActionsWithoutID()
    {
        /** @var MappedObject|SalsifyIDExtension $object */
        $object = MappedObject::create();
        $actions = $object->getCMSActions();

The method getCMSActions() does not exist on Dynamic\Salsify\ORM\SalsifyIDExtension.

        $this->assertInstanceOf(FieldList::class, $actions);
        $this->assertNull($actions->fieldByName('action_salsifyFetch'));

Are you sure the usage of $actions->fieldByName('action_salsifyFetch') targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

    }

    /**
     *
     */
    public function testUpdateCMSActionsWithID()
    {
        $controller = TestController::create();
        $request = new HTTPRequest('GET', '/');
        $session = new Session([]);
        $request->setSession($session);
        $controller->setRequest($request);
        $controller->doInit();
        $controller->pushCurrent();


        /** @var MappedObject|SalsifyIDExtension $object */
        $object = MappedObject::create();
        $object->SalsifyID = '001';

The property SalsifyID does not exist on Dynamic\Salsify\Tests\TestOnly\MappedObject. Since you implemented __set, consider adding a @property annotation.

        $actions = $object->getCMSActions();
        $this->assertInstanceOf(FieldList::class, $actions);
        $this->assertInstanceOf(FormAction::class, $actions->fieldByName('action_salsifyFetch'));

Are you sure the usage of $actions->fieldByName('action_salsifyFetch') targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

    }
}