dynamic / silverstripe-salsify

src/Task/ImportTask.php

<?php

namespace Dynamic\Salsify\Task;

use Dynamic\Salsify\Model\Importer;
use Dynamic\Salsify\Traits\Yieldable;
use SilverStripe\Control\Director;
use SilverStripe\Core\Config\Config;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\BuildTask;

/**
 * Class ImportTask
 * @package Dynamic\Salsify\Task
 * @mixin Yieldable
 */
class ImportTask extends BuildTask
{
    use Yieldable;

    /**
     * @var string
     */
    private static $segment = 'SalsifyImportTask';

The private property $segment is not used, and could be removed.

    /**
     * @var string
     */
    protected $title = 'Import products from salsify';

    /**
     * @var string
     */
    protected $description = 'Imports products from salsify into silverstripe';

    /**
     * @var bool
     */
    protected $enabled = true;

    /**
     * @var
     */
    private static $lineEnding;

    /**
     * @var bool
     */
    private static $output = true;

The private property $output is not used, and could be removed.

    /**
     * @param \SilverStripe\Control\HTTPRequest $request
     */
    public function run($request)
    {
        static::$lineEnding = Director::is_cli() ? PHP_EOL : '<br />';

Since $lineEnding is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $lineEnding to at least protected.

        // gets all importers
        $injectorConfig = array_keys(Config::inst()->get(Injector::class));
        $importers = array_filter(
            $injectorConfig,
            function ($element) {
                return strncmp($element, Importer::class, strlen(Importer::class)) === 0;
            }
        );

        foreach ($this->yieldSingle($importers) as $importerClass) {
            $importer = Injector::inst()->create($importerClass);
            $importer->run();
        }
    }

    /**
     * @param $string
     */
    public static function output($string)
    {
        if (static::config()->get('output')) {
            echo $string . static::$lineEnding;

Since $lineEnding is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $lineEnding to at least protected.

        }
    }
}