dynamic / silverstripe-salsify

src/ORM/SalsifyIDExtension.php

<?php

namespace Dynamic\Salsify\ORM;

use Dynamic\Salsify\Model\MapperHash;
use SilverStripe\Admin\LeftAndMain;

The type SilverStripe\Admin\LeftAndMain was not found. Maybe you did not declare it correctly or list all dependencies?

use SilverStripe\CMS\Forms\SiteTreeURLSegmentField;

The type SilverStripe\CMS\Forms\SiteTreeURLSegmentField was not found. Maybe you did not declare it correctly or list all dependencies?

use SilverStripe\CMS\Model\SiteTree;

The type SilverStripe\CMS\Model\SiteTree was not found. Maybe you did not declare it correctly or list all dependencies?

use SilverStripe\Control\Controller;
use SilverStripe\Forms\DatetimeField;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\FormAction;
use SilverStripe\Forms\TextField;
use SilverStripe\ORM\DataExtension;
use SilverStripe\ORM\HasManyList;

/**
 * Class FileExtension
 *
 * @property string SalsifyID
 * @property string SalsifyUpdatedAt
 * @property string SalsifyRelationsUpdatedAt
 *
 * @method HasManyList MapperHashes()
 *
 * @property-read \SilverStripe\ORM\DataObject|\Dynamic\Salsify\ORM\SalsifyIDExtension $owner
 */
class SalsifyIDExtension extends DataExtension
{

    /**
     * @var array
     */
    private static $db = [

The private property $db is not used, and could be removed.

        'SalsifyID' => 'Varchar(255)',
        'SalsifyUpdatedAt' => 'Varchar(255)',
        'SalsifyRelationsUpdatedAt' => 'Varchar(255)',
    ];

    /**
     * @var array
     */
    private static $has_many = [
        'MapperHashes' => MapperHash::class,
    ];

    /**
     * @var array
     */
    private static $indexes = [

The private property $indexes is not used, and could be removed.

        'SalsifyID' => true,
    ];

    /**
     * @param \SilverStripe\Forms\FieldList $fields
     */
    protected function updateFields(FieldList $fields)
    {
        $salsifyID = $fields->fieldByName('SalsifyID');

Are you sure the assignment to $salsifyID is correct as $fields->fieldByName('SalsifyID') targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

        if (!$salsifyID) {

$salsifyID is of type null, thus it always evaluated to false.

            $fields->push($salsifyID = TextField::create('SalsifyID'));
        }

        $salsifyUpdatedAt = $fields->fieldByName('SalsifyUpdatedAt');

Are you sure the assignment to $salsifyUpdatedAt is correct as $fields->fieldByName('SalsifyUpdatedAt') targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

        if (!$salsifyUpdatedAt) {

$salsifyUpdatedAt is of type null, thus it always evaluated to false.

            $fields->push($salsifyUpdatedAt = DatetimeField::create('SalsifyUpdatedAt'));
        }

        $salsifyRelationsUpdatedAt = $fields->fieldByName('SalsifyRelationsUpdatedAt');

Are you sure the assignment to $salsifyRelationsUpdatedAt is correct as $fields->fieldByName('SalsifyRelationsUpdatedAt') targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

        if (!$salsifyRelationsUpdatedAt) {

$salsifyRelationsUpdatedAt is of type null, thus it always evaluated to false.

            $fields->push($salsifyRelationsUpdatedAt = DatetimeField::create('SalsifyRelationsUpdatedAt'));
        }

        if ($this->owner->SalsifyID) {
            $salsifyID->setTemplate(SiteTreeURLSegmentField::class)->addExtraClass('urlsegment');
        }
        $salsifyUpdatedAt->setReadonly(true);
        $salsifyRelationsUpdatedAt->setReadonly(true);
    }

    /**
     * @param \SilverStripe\Forms\FieldList $fields
     */
    public function updateCMSFields(FieldList $fields)
    {
        if ($this->owner instanceof SiteTree) {
            return parent::updateCMSFields($fields);

Are you sure the usage of parent::updateCMSFields($fields) targeting SilverStripe\ORM\DataExtension::updateCMSFields() seems to always return null.

        }

        $this->updateFields($fields);
        return parent::updateCMSFields($fields);

Are you sure the usage of parent::updateCMSFields($fields) targeting SilverStripe\ORM\DataExtension::updateCMSFields() seems to always return null.

    }

    /**
     * @param \SilverStripe\Forms\FieldList $fields
     */
    public function updateSettingsFields(FieldList $fields)
    {
        $this->updateFields($fields);
    }

    /**
     * @param \SilverStripe\Forms\FieldList $actions
     */
    public function updateCMSActions(FieldList $actions)
    {
        parent::updateCMSActions($actions);

        if (!$this->owner->SalsifyID) {
            return;
        }

        $controller = Controller::curr();
        if ($controller instanceof LeftAndMain && $controller->canFetchSalsify()) {
            /** @var FormAction $action */
            $action = FormAction::create('salsifyFetch', 'Re-fetch Salsify')
                ->addExtraClass('btn-primary font-icon-sync')
                ->setUseButtonTag(true);

            $actions->push($action);
        }
    }

    /**
     *
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();

        $this->owner->SalsifyID = trim($this->owner->SalsifyID);

It seems like $this->owner->SalsifyID can also be of type null; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

    }
}