dynamic /
silverstripe-salsify
| Conditions | 10 |
| Paths | 16 |
| Total Lines | 24 |
| Code Lines | 14 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 31 | public function handleSalsifyRelationType($class, $data, $dataField, $config, $dbField) |
||
| 32 | { |
||
| 33 | if (!array_key_exists('salsify:relations', $data)) { |
||
| 34 | return []; |
||
| 35 | } |
||
| 36 | |||
| 37 | $related = []; |
||
| 38 | $fieldData = $data['salsify:relations']; |
||
| 39 | foreach ($this->owner->yieldSingle($fieldData) as $relation) { |
||
| 40 | if (array_key_exists('relation_type', $relation) && $relation['relation_type'] == $dataField) { |
||
| 41 | $related[] = DataObject::get($class)->find('SalsifyID', $relation['salsify:target_product_id']); |
||
| 42 | } |
||
| 43 | } |
||
| 44 | |||
| 45 | $related = array_filter($related); |
||
| 46 | |||
| 47 | if (array_key_exists('single', $config) && $config['single'] == true) { |
||
| 48 | if (count($related)) { |
||
| 49 | $object = $related[0]; |
||
| 50 | return preg_match('/ID$/', $dbField) ? $object->ID : $object; |
||
| 51 | } |
||
| 52 | return preg_match('/ID$/', $dbField) ? 0 : null; |
||
| 53 | } |
||
| 54 | return $related; |
||
| 55 | } |
||
| 57 |
Loading history...