Dynamic\Salsify\TypeHandler\BooleanHandler

Complexity

Total Complexity

5

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	handleBooleanType()	0	3	1
A	isTrue()	0	13	4

<?php

namespace Dynamic\Salsify\TypeHandler;

use SilverStripe\Core\Extension;

/**
 * Class BooleanHandler
 * @package Dynamic\Salsify\TypeHandler
 */
class BooleanHandler extends Extension
{
    /**
     * @var array
     */
    private static $field_types = [

The private property $field_types is not used, and could be removed.

        'Boolean' => [
            'requiresWrite' => false,
            'requiresSalsifyObjects' => false,
            'allowsModification' => true,
        ],
    ];

    /**
     * @param string|SilverStripe\ORM\DataObject $class

The type Dynamic\Salsify\TypeHandler\SilverStripe\ORM\DataObject was not found. Did you mean SilverStripe\ORM\DataObject? If so, make sure to prefix the type with \.

     * @param $data
     * @param $dataField
     * @param $config
     * @param $dbField
     * @return string|int
     *
     * @return string|boolean|int|double
     */
    public function handleBooleanType($class, $data, $dataField, $config, $dbField)

The parameter $class is not used and could be removed.

The parameter $config is not used and could be removed.

The parameter $dbField is not used and could be removed.

    {
        return $this->isTrue($data[$dataField]);

The expression return $this->isTrue($data[$dataField]) also could return the type boolean which is incompatible with the documented return type integer|string.

    }

    /**
     * @param $val
     * @param bool $return_null
     * @return bool|mixed|null
     *
     * FROM https://www.php.net/manual/en/function.boolval.php#116547
     */
    public function isTrue($val, $return_null = false)
    {
        $boolval = (bool)$val;

        if (is_string($val)) {
            $boolval = filter_var($val, FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE);
        }

        if ($boolval === null && !$return_null) {
            return false;
        }

        return $boolval;
    }
}