SalsifyIDExtension::updateFields() - Code Metrics - Inspection of "Updated where SalsifyID and SalsifyUpdatedAt field..." - dynamic/silverstripe-salsify - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#20)

by Matthew

created 2019-11-06 19:44 UTC

SalsifyIDExtension::updateFields() A

↳ Parent: SalsifyIDExtension

Complexity

Conditions	4
Paths	8

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
c	1
b	0
f	0
dl	0
loc	16
rs	9.9666
cc	4
nc	8
nop	1

<?php

namespace Dyanmic\Salsify\ORM;

use SilverStripe\Admin\LeftAndMain;
filter:
    dependency_paths: ["lib/*"]
use SilverStripe\CMS\Model\SiteTree;
filter:
    dependency_paths: ["lib/*"]
use SilverStripe\Control\Controller;
use SilverStripe\Forms\DatetimeField;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\FormAction;
use SilverStripe\Forms\TextField;
use SilverStripe\ORM\DataExtension;

/**
 * Class FileExtension
 *
 * @property string SalsifyID
 * @property string SalsifyUpdatedAt
 *
 * @property-read \SilverStripe\ORM\DataObject|\Dyanmic\Salsify\ORM\SalsifyIDExtension $owner
 */
class SalsifyIDExtension extends DataExtension
{

    /**
     * @var array
     */
    private static $db = [

        'SalsifyID' => 'Varchar(255)',
        'SalsifyUpdatedAt' => 'Varchar(255)'
    ];

    /**
     * @param \SilverStripe\Forms\FieldList $fields
     */
    protected function updateFields(FieldList $fields)
    {
        $salsifyID = $fields->dataFieldByName('SalsifyID');
        if (!$salsifyID) {

            $fields->push($salsifyID = TextField::create('SalsifyID'));
        }

        $salsifyUpdatedAt = $fields->dataFieldByName('SalsifyUpdatedAt');
        if (!$salsifyUpdatedAt) {

            $fields->push($salsifyUpdatedAt = DatetimeField::create('SalsifyUpdatedAt'));
        }

        if ($this->owner->SalsifyID) {
            $salsifyID->setReadonly(true);
        }
        $salsifyUpdatedAt->setReadonly(true);
    }

    /**
     * @param \SilverStripe\Forms\FieldList $fields
     */
    public function updateCMSFields(FieldList $fields)
    {
        if ($this->owner instanceof SiteTree) {
            return parent::updateCMSFields($fields);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        $this->updateFields($fields);
        return parent::updateCMSFields($fields);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    /**
     * @param \SilverStripe\Forms\FieldList $fields
     */
    public function updateSettingsFields(FieldList $fields) {
        $this->updateFields($fields);
    }

    /**
     * @param \SilverStripe\Forms\FieldList $actions
     */
    public function updateCMSActions(FieldList $actions)
    {
        parent::updateCMSActions($actions);

        if (!$this->owner->SalsifyID) {
            return;
        }

        $controller = Controller::curr();
        if ($controller instanceof LeftAndMain && $controller->canFetchSalsify()) {
            /** @var FormAction $action */
            $action = FormAction::create('salsifyFetch', 'Re-fetch Salsify')
                ->addExtraClass('btn-primary font-icon-sync')
                ->setUseButtonTag(true);

            $actions->push($action);
        }
    }
}


1			<?php
2
3			namespace Dyanmic\Salsify\ORM;
4
5			use SilverStripe\Admin\LeftAndMain;
			0 ignored issues – show Bug introduced 2019-08-08 19:59 UTC by Report Bug Copy Issue Report The type `SilverStripe\Admin\LeftAndMain` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
6			use SilverStripe\CMS\Model\SiteTree;
			0 ignored issues – show Bug introduced 2019-11-06 19:43 UTC by Report Bug Copy Issue Report The type `SilverStripe\CMS\Model\SiteTree` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
7			use SilverStripe\Control\Controller;
8			use SilverStripe\Forms\DatetimeField;
9			use SilverStripe\Forms\FieldList;
10			use SilverStripe\Forms\FormAction;
11			use SilverStripe\Forms\TextField;
12			use SilverStripe\ORM\DataExtension;
13
14			/**
15			* Class FileExtension
16			*
17			* @property string SalsifyID
18			* @property string SalsifyUpdatedAt
19			*
20			* @property-read \SilverStripe\ORM\DataObject\|\Dyanmic\Salsify\ORM\SalsifyIDExtension $owner
21			*/
22			class SalsifyIDExtension extends DataExtension
23			{
24
25			/**
26			* @var array
27			*/
28			private static $db = [
			0 ignored issues – show introduced 2019-06-12 15:17 UTC by Report Bug Copy Issue Report The private property `$db` is not used, and could be removed. Loading history...
29			'SalsifyID' => 'Varchar(255)',
30			'SalsifyUpdatedAt' => 'Varchar(255)'
31			];
32
33			/**
34			* @param \SilverStripe\Forms\FieldList $fields
35			*/
36			protected function updateFields(FieldList $fields)
37			{
38			$salsifyID = $fields->dataFieldByName('SalsifyID');
39			if (!$salsifyID) {
			0 ignored issues – show introduced 2019-08-08 19:59 UTC by Report Bug Copy Issue Report `$salsifyID` is of type `SilverStripe\Forms\FormField`, thus it always evaluated to `true`. Loading history...
40			$fields->push($salsifyID = TextField::create('SalsifyID'));
41			}
42
43			$salsifyUpdatedAt = $fields->dataFieldByName('SalsifyUpdatedAt');
44			if (!$salsifyUpdatedAt) {
			0 ignored issues – show introduced 2019-08-08 19:59 UTC by Report Bug Copy Issue Report `$salsifyUpdatedAt` is of type `SilverStripe\Forms\FormField`, thus it always evaluated to `true`. Loading history...
45			$fields->push($salsifyUpdatedAt = DatetimeField::create('SalsifyUpdatedAt'));
46			}
47
48			if ($this->owner->SalsifyID) {
49			$salsifyID->setReadonly(true);
50			}
51			$salsifyUpdatedAt->setReadonly(true);
52			}
53
54			/**
55			* @param \SilverStripe\Forms\FieldList $fields
56			*/
57			public function updateCMSFields(FieldList $fields)
58			{
59			if ($this->owner instanceof SiteTree) {
60			return parent::updateCMSFields($fields);
			0 ignored issues – show Bug introduced 2019-08-08 19:59 UTC by Report Bug Copy Issue Report Are you sure the usage of `parent::updateCMSFields($fields)` targeting `SilverStripe\ORM\DataExtension::updateCMSFields()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
61			}
62
63			$this->updateFields($fields);
64			return parent::updateCMSFields($fields);
			0 ignored issues – show Bug introduced 2019-11-06 19:43 UTC by Report Bug Copy Issue Report Are you sure the usage of `parent::updateCMSFields($fields)` targeting `SilverStripe\ORM\DataExtension::updateCMSFields()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
65			}
66
67			/**
68			* @param \SilverStripe\Forms\FieldList $fields
69			*/
70			public function updateSettingsFields(FieldList $fields) {
71			$this->updateFields($fields);
72			}
73
74			/**
75			* @param \SilverStripe\Forms\FieldList $actions
76			*/
77			public function updateCMSActions(FieldList $actions)
78			{
79			parent::updateCMSActions($actions);
80
81			if (!$this->owner->SalsifyID) {
82			return;
83			}
84
85			$controller = Controller::curr();
86			if ($controller instanceof LeftAndMain && $controller->canFetchSalsify()) {
87			/** @var FormAction $action */
88			$action = FormAction::create('salsifyFetch', 'Re-fetch Salsify')
89			->addExtraClass('btn-primary font-icon-sync')
90			->setUseButtonTag(true);
91
92			$actions->push($action);
93			}
94			}
95			}
96

dynamic / silverstripe-salsify

Pull Request — master (#20)

SalsifyIDExtension::updateFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like