ImageHandler::fixExtension() - Code Metrics - Inspection of "Enhancement/type handlers" - dynamic/silverstripe-salsify - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#16)

by Matthew

created 2019-07-31 14:21 UTC

ImageHandler::fixExtension() A

↳ Parent: ImageHandler

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	2
eloc	9
c	2
b	0
f	0
nc	2
nop	1
dl	0
loc	16
rs	9.9666

<?php

namespace Dynamic\Salsify\TypeHandler;

use SilverStripe\Assets\Image;
use SilverStripe\ORM\DataObject;

/**
 * Class ImageHandler
 * @package Dynamic\Salsify\TypeHandler
 *
 * @property-read \Dynamic\Salsify\Model\Mapper|\Dynamic\Salsify\TypeHandler\ImageHandler $owner
 */
class ImageHandler extends FileHandler
{
    /**
     * @var array
     */
    private static $field_types = [

        'Image'
    ];

    /**
     * @var string
     */
    private static $defaultImageType = 'png';


    /**
     * @param $value
     * @param $field
     * @param string |DataObject $class
     * @return string
     *
     * @throws \Exception
     */
    public function handleImageType($value, $field, $class)
    public function handleImageType($value, $field, /** @scrutinizer ignore-unused */ $class)
    {
        $data = $this->getAssetBySalsifyID($value);
        if (!$data) {

            return '';
        }

        $url = $this->fixExtension($data['salsify:url']);
        $name = $this->fixExtension($data['salsify:name']);

        $asset = $this->updateFile(
            $data['salsify:id'],
            $data['salsify:updated_at'],
            $url,
            $name,
            Image::class
        );
        return preg_match('/ID$/', $field) ? $asset->ID : $asset;
    }

    protected function fixExtension($string)
    {
        $supportedImageExtensions = Image::get_category_extensions(
            Image::singleton()->File->getAllowedCategories()
        );
        $extension = pathinfo($string)['extension'];

        if (!in_array($extension, $supportedImageExtensions)) {
            return str_replace(
                '.' . $extension,
                '.' . $this->owner->config()->get('defaultImageType'),
                '.' . $this->owner->/** @scrutinizer ignore-call */ config()->get('defaultImageType'),
                $string
            );
        }

        return $string;
    }
}


dynamic / silverstripe-salsify

Pull Request — master (#16)

ImageHandler::fixExtension() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like