MapperTest::setUp() - Code Metrics - Inspection of "Fixed fallback fields not working" - dynamic/silverstripe-salsify - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#79)

by Matthew

created 2020-11-11 14:50 UTC

MapperTest::setUp() A

↳ Parent: MapperTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	56
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
eloc	39
c	3
b	0
f	0
dl	0
loc	56
rs	9.296
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace Dynamic\Salsify\Tests\Model\Mapper;

use Dynamic\Salsify\ORM\SalsifyIDExtension;
use Dynamic\Salsify\Model\Mapper;
use Dynamic\Salsify\Task\ImportTask;
use Dynamic\Salsify\Tests\TestOnly\MappedObject;
use Dynamic\Salsify\Tests\TestOnly\MapperModification;
use Dynamic\Salsify\Tests\TestOnly\MapperSkipper;
use Exception;
use SilverStripe\Assets\Image;
use SilverStripe\Core\Config\Config;
use SilverStripe\Dev\SapphireTest;

/**
 * Class MapperTest
 * @package Dynamic\Salsify\Tests\Model\Mapper
 */
class MapperTest extends SapphireTest
{

    /**
     * @var string
     */
    protected static $fixture_file = '../fixtures.yml';

    /**
     * @var array
     */
    protected static $required_extensions = [
        Mapper::class => [
            MapperModification::class,
            MapperSkipper::class,
        ],
        MappedObject::class => [
            SalsifyIDExtension::class,
        ]
    ];

    /**
     * @var array
     */
    protected static $extra_dataobjects = [
        MappedObject::class,
    ];

    /**
     * @var string
     */
    private $importerKey = 'test';

    /**
     *
     */
    public function setUp()
    {
        Config::modify()->set(
            Mapper::class . '.' . $this->importerKey,
            'mapping',
            [
                MappedObject::class => [
                    'SalsifyID' => [
                        'salsifyField' => 'salsify:id',
                    ],
                    'SalsifyUpdatedAt' => 'salsify:updated_at',
                    'Unique' => [
                        'salsifyField' => 'custom-field-unique',
                        'unique' => true,
                        'shouldSkip' => 'testSkip',
                    ],
                    'Title' => 'custom-field-title',
                    'Seller' => [
                        'salsifyField' => 'custom-field-seller',
                        'unique' => false,
                    ],
                    'Modified' => [
                        'salsifyField' => 'custom-field-modified',
                        'modification' => 'testModification'
                    ],
                    'MainImage' => [
                        'salsifyField' => 'custom-field-front-image',
                        'type' => 'Image',
                    ],
                    'Images' => [
                        'salsifyField' => 'custom-field-images',
                        'type' => 'ManyImages',
                        'sortColumn' => 'SortOrder',
                    ],
                    'FallbackString' => [
                        'salsifyField' => 'YYYYY',
                        'fallback' => 'custom-field-title',
                    ],
                    'FallbackArray' => [
                        'salsifyField' => 'YYYYY',
                        'fallback' => [
                            'XXXXX',
                            'custom-field-seller',
                        ],
                    ],
                    'Unknown' => [
                        'unique' => true,
                    ],
                    'Unknown2' => [
                        'salsifyField' => 'XXXXX',
                    ],
                ],
            ]
        );
        Config::modify()->set(ImportTask::class, 'output', false);
        return parent::setUp();
    }

    /**
     * @throws Exception
     */
    public function testConstructorFailsWithoutMapping()
    {
        Config::modify()->remove(Mapper::class . '.' . $this->importerKey, 'mapping');
        $this->expectException(Exception::class);
        new Mapper($this->importerKey, __DIR__ . '/../data.json');
    }

    /**
     * @throws Exception
     */
    public function testConstructor()
    {
        $mapper = new Mapper($this->importerKey, __DIR__ . '/../data.json');
        $this->assertInstanceOf(Mapper::class, $mapper);
    }

    /**
     * @throws \Exception
     */
    public function testMap()
    {
        $mapper = new Mapper($this->importerKey, __DIR__ . '/../data.json');
        $mapper->map();

        // check to see if existing added
        $this->assertEquals(7, MappedObject::get()->count());
        $this->testExisting();

        // tests for unchanged
        $mapper = new Mapper($this->importerKey, __DIR__ . '/../data.json');
        $mapper->map();

        $this->testImages();

        $this->assertEquals(7, MappedObject::get()->count());
        $this->assertEquals('modified TEST_MOD', MappedObject::get()->find('Unique', '2')->Modified);

        // test fallbacks
        $this->assertEquals('Brooklyn Bridge', MappedObject::get()->find('Unique', '3')->FallbackString);
        $this->assertEquals('William McCloundy', MappedObject::get()->find('Unique', '3')->FallbackArray);
    }

    /**
     * Checks existing records to see if they got updated
     */
    private function testExisting()
    {
        // check to see if existing object with unique was modified
        $this->assertEquals('William McCloundy', MappedObject::get()->find('Unique', '3')->Seller);
        $this->assertEquals('00000000000002', MappedObject::get()->find('Unique', '3')->SalsifyID);

        // check to see if existing object with salsify id was modified
        $this->assertEquals('Victor Lustig', MappedObject::get()->find('Unique', '2')->Seller);
        $this->assertEquals('00000000000001', MappedObject::get()->find('Unique', '2')->SalsifyID);
    }

    /**
     * Tests images and sorting
     */
    private function testImages()
    {
        // test images
        $this->assertEquals(9, Image::get()->count());
        $this->assertEquals(2, MappedObject::get()->find('Unique', '3')->Images()->count());
        // first in image array is actually first with sort column specified
        $this->assertEquals(
            'DA-002-002',
            MappedObject::get()->find('Unique', '3')->Images()->sort('SortOrder')->first()->SalsifyID
        );

        $this->assertTrue(MappedObject::get()->first()->MainImageID > 0);
        $this->assertTrue(MappedObject::get()->last()->MainImageID > 0);
    }
}


1			<?php
2
3			namespace Dynamic\Salsify\Tests\Model\Mapper;
4
5			use Dynamic\Salsify\ORM\SalsifyIDExtension;
6			use Dynamic\Salsify\Model\Mapper;
7			use Dynamic\Salsify\Task\ImportTask;
8			use Dynamic\Salsify\Tests\TestOnly\MappedObject;
9			use Dynamic\Salsify\Tests\TestOnly\MapperModification;
10			use Dynamic\Salsify\Tests\TestOnly\MapperSkipper;
11			use Exception;
12			use SilverStripe\Assets\Image;
13			use SilverStripe\Core\Config\Config;
14			use SilverStripe\Dev\SapphireTest;
15
16			/**
17			* Class MapperTest
18			* @package Dynamic\Salsify\Tests\Model\Mapper
19			*/
20			class MapperTest extends SapphireTest
21			{
22
23			/**
24			* @var string
25			*/
26			protected static $fixture_file = '../fixtures.yml';
27
28			/**
29			* @var array
30			*/
31			protected static $required_extensions = [
32			Mapper::class => [
33			MapperModification::class,
34			MapperSkipper::class,
35			],
36			MappedObject::class => [
37			SalsifyIDExtension::class,
38			]
39			];
40
41			/**
42			* @var array
43			*/
44			protected static $extra_dataobjects = [
45			MappedObject::class,
46			];
47
48			/**
49			* @var string
50			*/
51			private $importerKey = 'test';
52
53			/**
54			*
55			*/
56			public function setUp()
57			{
58			Config::modify()->set(
59			Mapper::class . '.' . $this->importerKey,
60			'mapping',
61			[
62			MappedObject::class => [
63			'SalsifyID' => [
64			'salsifyField' => 'salsify:id',
65			],
66			'SalsifyUpdatedAt' => 'salsify:updated_at',
67			'Unique' => [
68			'salsifyField' => 'custom-field-unique',
69			'unique' => true,
70			'shouldSkip' => 'testSkip',
71			],
72			'Title' => 'custom-field-title',
73			'Seller' => [
74			'salsifyField' => 'custom-field-seller',
75			'unique' => false,
76			],
77			'Modified' => [
78			'salsifyField' => 'custom-field-modified',
79			'modification' => 'testModification'
80			],
81			'MainImage' => [
82			'salsifyField' => 'custom-field-front-image',
83			'type' => 'Image',
84			],
85			'Images' => [
86			'salsifyField' => 'custom-field-images',
87			'type' => 'ManyImages',
88			'sortColumn' => 'SortOrder',
89			],
90			'FallbackString' => [
91			'salsifyField' => 'YYYYY',
92			'fallback' => 'custom-field-title',
93			],
94			'FallbackArray' => [
95			'salsifyField' => 'YYYYY',
96			'fallback' => [
97			'XXXXX',
98			'custom-field-seller',
99			],
100			],
101			'Unknown' => [
102			'unique' => true,
103			],
104			'Unknown2' => [
105			'salsifyField' => 'XXXXX',
106			],
107			],
108			]
109			);
110			Config::modify()->set(ImportTask::class, 'output', false);
111			return parent::setUp();
112			}
113
114			/**
115			* @throws Exception
116			*/
117			public function testConstructorFailsWithoutMapping()
118			{
119			Config::modify()->remove(Mapper::class . '.' . $this->importerKey, 'mapping');
120			$this->expectException(Exception::class);
121			new Mapper($this->importerKey, __DIR__ . '/../data.json');
122			}
123
124			/**
125			* @throws Exception
126			*/
127			public function testConstructor()
128			{
129			$mapper = new Mapper($this->importerKey, __DIR__ . '/../data.json');
130			$this->assertInstanceOf(Mapper::class, $mapper);
131			}
132
133			/**
134			* @throws \Exception
135			*/
136			public function testMap()
137			{
138			$mapper = new Mapper($this->importerKey, __DIR__ . '/../data.json');
139			$mapper->map();
140
141			// check to see if existing added
142			$this->assertEquals(7, MappedObject::get()->count());
143			$this->testExisting();
144
145			// tests for unchanged
146			$mapper = new Mapper($this->importerKey, __DIR__ . '/../data.json');
147			$mapper->map();
148
149			$this->testImages();
150
151			$this->assertEquals(7, MappedObject::get()->count());
152			$this->assertEquals('modified TEST_MOD', MappedObject::get()->find('Unique', '2')->Modified);
153
154			// test fallbacks
155			$this->assertEquals('Brooklyn Bridge', MappedObject::get()->find('Unique', '3')->FallbackString);
156			$this->assertEquals('William McCloundy', MappedObject::get()->find('Unique', '3')->FallbackArray);
157			}
158
159			/**
160			* Checks existing records to see if they got updated
161			*/
162			private function testExisting()
163			{
164			// check to see if existing object with unique was modified
165			$this->assertEquals('William McCloundy', MappedObject::get()->find('Unique', '3')->Seller);
166			$this->assertEquals('00000000000002', MappedObject::get()->find('Unique', '3')->SalsifyID);
167
168			// check to see if existing object with salsify id was modified
169			$this->assertEquals('Victor Lustig', MappedObject::get()->find('Unique', '2')->Seller);
170			$this->assertEquals('00000000000001', MappedObject::get()->find('Unique', '2')->SalsifyID);
171			}
172
173			/**
174			* Tests images and sorting
175			*/
176			private function testImages()
177			{
178			// test images
179			$this->assertEquals(9, Image::get()->count());
180			$this->assertEquals(2, MappedObject::get()->find('Unique', '3')->Images()->count());
181			// first in image array is actually first with sort column specified
182			$this->assertEquals(
183			'DA-002-002',
184			MappedObject::get()->find('Unique', '3')->Images()->sort('SortOrder')->first()->SalsifyID
185			);
186
187			$this->assertTrue(MappedObject::get()->first()->MainImageID > 0);
188			$this->assertTrue(MappedObject::get()->last()->MainImageID > 0);
189			}
190			}
191

dynamic / silverstripe-salsify

Pull Request — master (#79)

MapperTest::setUp() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like