Dynamic\Salsify\TypeHandler\Asset\ImageHandler

Complexity

Total Complexity

7

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	handleManyImagesType()	0	11	2
A	handleImageType()	0	18	3
A	fixExtension()	0	16	2

<?php

namespace Dynamic\Salsify\TypeHandler\Asset;

use Dynamic\Salsify\Task\ImportTask;
use SilverStripe\Assets\Image;
use SilverStripe\ORM\DataObject;

/**
 * Class ImageHandler
 * @package Dynamic\Salsify\TypeHandler
 *
 * @property-read \Dynamic\Salsify\Model\Mapper|\Dynamic\Salsify\TypeHandler\Asset\ImageHandler $owner
 */
class ImageHandler extends AssetHandler
{
    /**
     * @var array
     */
    private static $field_types = [

The private property $field_types is not used, and could be removed.

        'Image',
        'ManyImages',
    ];

    /**
     * @var string
     */
    private static $defaultImageType = 'png';

The private property $defaultImageType is not used, and could be removed.

    /**
     * @param $data
     * @param $dataField
     * @param $config
     * @param $dbField
     * @param string |DataObject $class
     * @return string|int
     *
     * @throws \Exception
     */
    public function handleImageType($data, $dataField, $config, $dbField, $class)

The parameter $class is not used and could be removed.

The parameter $config is not used and could be removed.

    {
        $assetData = $this->getAssetBySalsifyID($data[$dataField]);
        if (!$assetData) {

The condition $assetData is always false.

            return '';
        }

        $url = $this->fixExtension($assetData['salsify:url']);
        $name = $this->fixExtension($assetData['salsify:name']);

        $asset = $this->updateFile(
            $assetData['salsify:id'],
            $assetData['salsify:updated_at'],
            $url,
            $name,
            Image::class
        );
        return preg_match('/ID$/', $dbField) ? $asset->ID : $asset;
    }

    protected function fixExtension($string)
    {
        $supportedImageExtensions = Image::get_category_extensions(
            Image::singleton()->File->getAllowedCategories()
        );
        $extension = pathinfo($string)['extension'];

        if (!in_array($extension, $supportedImageExtensions)) {
            return str_replace(
                '.' . $extension,
                '.' . $this->owner->config()->get('defaultImageType'),

The method config() does not exist on Dynamic\Salsify\TypeHandler\Asset\ImageHandler.

                $string
            );
        }

        return $string;
    }

    /**
     * @param $data
     * @param $dataField
     * @param $config
     * @param $dbField
     * @param string |DataObject $class
     * @return array
     *
     * @throws \Exception
     */
    public function handleManyImagesType($data, $dataField, $config, $dbField, $class)
    {
        $files = [];
        $fieldData = $data[$dataField];
        foreach ($fieldData as $fileID) {
            $entryData = array_merge($data, [
                $dataField => $fileID
            ]);
            $files[] = $this->owner->handleImageType($entryData, $dataField, $config, $dbField, $class);

The method handleImageType() does not exist on Dynamic\Salsify\Model\Mapper. Since you implemented __call, consider adding a @method annotation.

        }
        return $files;
    }
}