Dynamic\Salsify\TypeHandler\Asset\FileHandler

Complexity

Total Complexity

5

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	handleFileType()	0	14	3
A	handleManyFilesType()	0	11	2

<?php

namespace Dynamic\Salsify\TypeHandler\Asset;

use SilverStripe\ORM\DataObject;

/**
 * Class FileHandler
 * @package Dynamic\Salsify\TypeHandler
 *
 * @property-read \Dynamic\Salsify\Model\Mapper|\Dynamic\Salsify\TypeHandler\Asset\FileHandler $owner
 */
class FileHandler extends AssetHandler
{
    /**
     * @var array
     */
    private static $field_types = [

The private property $field_types is not used, and could be removed.

        'File',
        'ManyFiles',
    ];

    /**
     * @param $data
     * @param $dataField
     * @param $config
     * @param $dbField
     * @param string |DataObject $class
     * @return string|int
     *
     * @throws \Exception
     */
    public function handleFileType($data, $dataField, $config, $dbField, $class)

The parameter $config is not used and could be removed.

The parameter $class is not used and could be removed.

    {
        $data = $this->getAssetBySalsifyID($data[$dataField]);
        if (!$data) {

The condition $data is always false.

            return '';
        }

        $asset = $this->updateFile(
            $data['salsify:id'],
            $data['salsify:updated_at'],
            $data['salsify:url'],
            $data['salsify:name']
        );
        return preg_match('/ID$/', $dbField) ? $asset->ID : $asset;
    }

    /**
     * @param $data
     * @param $dataField
     * @param $config
     * @param $dbField
     * @param string |DataObject $class
     * @return array
     *
     * @throws \Exception
     */
    public function handleManyFilesType($data, $dataField, $config, $dbField, $class)
    {
        $files = [];
        $fieldData = $data[$dataField];
        foreach ($fieldData as $fileID) {
            $entryData = array_merge($data, [
                $dataField => $fileID
            ]);
            $files[] = $this->owner->handleFileType($entryData, $dataField, $config, $dbField, $class);

The method handleFileType() does not exist on Dynamic\Salsify\Model\Mapper. Since you implemented __call, consider adding a @method annotation.

        }
        return $files;
    }
}