Dynamic\Salsify\TypeHandler\Relation\HasOneHandler::handleHasOneType()

Complexity

Conditions	8
Paths	11

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function handleHasOneType($class, $data, $dataField, $config, $dbField)

The parameter $dataField is not used and could be removed.

    {
        if (!array_key_exists('relation', $config) || !is_array($config['relation'])) {
            return preg_match('/ID$/', $dbField) ? 0 : null;
        }

        $relationConfig = $config['relation'];
        $relatedClass = array_key_first($relationConfig);

        foreach ($this->owner->yieldKeyVal($relationConfig[$relatedClass]) as $dbField => $salsifyField) {

The method yieldKeyVal() does not exist on Dynamic\Salsify\TypeHandler\Relation\HasOneHandler.

$dbField is overwriting one of the parameters of this function.

            if ($this->owner->handleShouldSkip($class, $dbField, $salsifyField, $data)) {

The method handleShouldSkip() does not exist on Dynamic\Salsify\TypeHandler\Relation\HasOneHandler.

It seems like $dbField can also be of type true; however, parameter $dbField of Dynamic\Salsify\Model\Mapper::handleShouldSkip() does only seem to accept string, maybe add an additional type check?

                return false;

The expression return false returns the type false which is incompatible with the documented return type SilverStripe\ORM\DataObject|integer.

            }
        }

        $object = $this->owner->mapToObject($relatedClass, $relationConfig[$relatedClass], $data);

The method mapToObject() does not exist on Dynamic\Salsify\TypeHandler\Relation\HasOneHandler.

        $objectID = $object ? $object->ID : 0;

$object is of type SilverStripe\ORM\DataObject, thus it always evaluated to true.

        return preg_match('/ID$/', $dbField) ? $objectID : $object;
    }