Dynamic\Salsify\Model\Service::__construct()

Complexity

Conditions	5
Paths	5

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function __construct($importerKey)
    {
        $this->importerKey = $importerKey;
        $this->serviceName = static::class . '.' . $this->importerKey;

        $serviceConfig = Config::inst()->get($this->serviceName);
        foreach ($this->yieldKeyVal($serviceConfig) as $key => $value) {
            $this->config()->merge($key, $value);

It seems like $key can also be of type true; however, parameter $name of SilverStripe\Core\Config\Config_ForClass::merge() does only seem to accept string, maybe add an additional type check?

            if ($key === 'extensions') {
                if (!is_array($value)) {
                    throw new \Exception("Extensions for {$this->serviceName} is not an array");
                }
                foreach ($this->yieldSingle($value) as $extension) {
                    static::add_extension($extension);
                }