dynamic / silverstripe-recipe-book

src/Page/RecipeLanding.php

<?php

namespace Dynamic\RecipeBook\Page;

use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\Forms\GridField\GridFieldAddExistingAutocompleter;
use SilverStripe\Forms\GridField\GridFieldAddNewButton;
use SilverStripe\Forms\GridField\GridFieldConfig_RelationEditor;
use SilverStripe\Forms\NumericField;
use Symbiote\GridFieldExtensions\GridFieldAddExistingSearchButton;
use Symbiote\GridFieldExtensions\GridFieldOrderableRows;

class RecipeLanding extends \Page
{
    /**
     * @var array
     */
    private static $db = [

The private property $db is not used, and could be removed.

        'PerPage' => 'Int',
    ];

    /**
     * @var array
     */
    private static $many_many = [

The private property $many_many is not used, and could be removed.

        'FeaturedCategories' => RecipeCategoryPage::class,
    ];

    /**
     * @var array
     */
    private static $many_many_extraFields = [

The private property $many_many_extraFields is not used, and could be removed.

        'FeaturedCategories' => [
            'SortOrder' => 'Int',
        ],
    ];

    /**
     * @var array
     */
    private static $defaults = [

The private property $defaults is not used, and could be removed.

        'PerPage' => 9,
    ];

    /**
     * @var string
     */
    private static $singular_name = 'Recipe Landing Page';

The private property $singular_name is not used, and could be removed.

    /**
     * @var string
     */
    private static $plural_name = 'Recipe Landing Pages';

The private property $plural_name is not used, and could be removed.

    /**
     * @var array
     */
    private static $allowed_children = [

The private property $allowed_children is not used, and could be removed.

        RecipeCategoryPage::class,
    ];

    /**
     * @var string
     */
    private static $table_name = 'RecipeLanding';

The private property $table_name is not used, and could be removed.

    /**
     * @return \SilverStripe\Forms\FieldList
     */
    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function (FieldList $fields) {
            if ($this->ID) {
                $config = GridFieldConfig_RelationEditor::create()
                    ->addComponent(new GridFieldOrderableRows('SortOrder'))
                    ->removeComponentsByType(GridFieldAddExistingAutocompleter::class)
                    ->removeComponentsByType(GridFieldAddNewButton::class)
                    ->addComponent(new GridFieldAddExistingSearchButton());
                $cats = $this->FeaturedCategories()->sort('SortOrder');

The method FeaturedCategories() does not exist on Dynamic\RecipeBook\Page\RecipeLanding. Since you implemented __call, consider adding a @method annotation.

                $catsField = GridField::create(
                    'FeaturedCategories',
                    'Featured Categories',
                    $cats,
                    $config
                );

                $fields->addFieldsToTab('Root.Featured', array(
                    $catsField,
                ));
            }

            $fields->addFieldsToTab('Root.Browse', [
                NumericField::create('PerPage', 'Categories per page'),
            ]);
        });

        return parent::getCMSFields();
    }

    /**
     * @return mixed
     */
    public function getFeaturedList()
    {
        return $this->FeaturedCategories()->sort('SortOrder');
    }
}