Dynamic\Products\Page\Product

Complexity

Total Complexity

12

Size/Duplication

Total Lines	175
Duplicated Lines	0 %

Importance

Changes	4
Bugs	1	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setHasImages()	0	4	1
A	setImage()	0	6	2
A	getHasImages()	0	6	2
A	getThumbnail()	0	9	3
A	getCMSFields()	0	43	2
A	getImage()	0	6	2

<?php

namespace Dynamic\Products\Page;

use Bummzack\SortableFile\Forms\SortableUploadField;
use Dynamic\Products\Model\Brochure;
use SilverStripe\Assets\File;
use SilverStripe\Assets\Image;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\Forms\GridField\GridFieldAddExistingAutocompleter;
use SilverStripe\Forms\GridField\GridFieldConfig_RecordEditor;
use SilverStripe\Forms\TextField;
use Symbiote\GridFieldExtensions\GridFieldAddExistingSearchButton;
use Symbiote\GridFieldExtensions\GridFieldOrderableRows;

class Product extends \Page
{
    /**
     * @var
     */
    private $image;

    /**
     * @var
     */
    private $has_images;

    /**
     * @var string
     */
    private static $table_name = 'Product';

The private property $table_name is not used, and could be removed.

    /**
     * @var array
     */
    private static $db = [

The private property $db is not used, and could be removed.

        'SKU' => 'Varchar(100)',
    ];

    /**
     * @var array
     */
    private static $many_many = [

The private property $many_many is not used, and could be removed.

        'Images' => File::class,
        'Brochures' => Brochure::class,
    ];

    /**
     * @var array
     */
    private static $many_many_extraFields = [

The private property $many_many_extraFields is not used, and could be removed.

        'Images' => [
            'SortOrder' => 'Int',
        ],
        'Brochures' => [
            'SortOrder' => 'Int',
        ],
    ];

    /**
     *
     */
    private static $owns = [

The private property $owns is not used, and could be removed.

        'Images',
    ];

    /**
     * The relation name was established before requests for videos.
     * The relation has subsequently been updated from Image::class to File::class
     * to allow for additional file types such as mp4
     *
     * @var array
     */
    private static $allowed_images_extensions = [

The private property $allowed_images_extensions is not used, and could be removed.

        'gif',
        'jpeg',
        'jpg',
        'png',
        'bmp',
        'ico',
        'mp4',
    ];

    /**
     * @var array
     */
    private static $allowed_children = [];

The private property $allowed_children is not used, and could be removed.

    /**
     * @return \SilverStripe\Forms\FieldList
     */
    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function (FieldList $fields) {
            $fields->insertBefore(
                'Content',
                TextField::create('SKU', 'Product SKU')
            );

            // Images tab
            $images = SortableUploadField::create('Images')
                ->setSortColumn('SortOrder')
                ->setIsMultiUpload(true)
                ->setAllowedExtensions($this->config()->get('allowed_images_extensions'))
                ->setFolderName('Uploads/Products/Images');

            $fields->addFieldsToTab('Root.Images', [
                $images,
            ]);

            if ($this->ID) {
                // Brochures
                $config = GridFieldConfig_RecordEditor::create();
                $config->addComponents([
                    new GridFieldOrderableRows('SortOrder'),
                    new GridFieldAddExistingSearchButton(),
                ])
                    ->removeComponentsByType([
                        GridFieldAddExistingAutocompleter::class,
                    ]);

                $brochures = GridField::create(
                    'Brochures',
                    'Brochures',
                    $this->Brochures()->sort('SortOrder'),

The method Brochures() does not exist on Dynamic\Products\Page\Product. Since you implemented __call, consider adding a @method annotation.

                    $config
                );
                $fields->addFieldsToTab('Root.Files.Brochures', [
                    $brochures,
                ]);
            }
        });

        return parent::getCMSFields();
    }

    /**
     * @return bool
     */
    public function setImage()
    {
        if ($this->getHasImages()) {
            $this->image = $this->Images()->sort('SortOrder')->first();

The method Images() does not exist on Dynamic\Products\Page\Product. Since you implemented __call, consider adding a @method annotation.

        }
        return $this;

The expression return $this returns the type Dynamic\Products\Page\Product which is incompatible with the documented return type boolean.

    }

    /**
     * @return mixed
     */
    public function getImage()
    {
        if (!$this->image) {
            $this->setImage();
        }
        return $this->image;
    }

    /**
     * @return mixed
     */
    public function getThumbnail()
    {
        if ($image = $this->getImage()) {
            if ($thumb = Image::get()->byID($image->ID)) {
                return $thumb->CMSThumbnail();
            }
        }

        return false;
    }

    /**
     * @return $this
     */
    public function setHasImages()
    {
        $this->has_images = $this->Images()->exists();
        return $this;
    }

    /**
     * @return mixed
     */
    public function getHasImages()
    {
        if (!$this->has_images) {
            $this->setHasImages();
        }
        return $this->has_images;
    }
}