ProductWishListControllerExtension

Complexity

Total Complexity

12

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

48.39%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	ProductWishListForm()	0	24	5
A	getController()	0	5	2
A	doProcessWishList()	0	9	3
A	update()	0	12	2

<?php

/**
 * Class ProductWishListControllerExtension
 */
class ProductWishListControllerExtension extends Extension
{

    /**
     * @var array
     */
    private static $allowed_actions = [
        'ProductWishListForm',
        'update',
    ];

    /**
     * @param null $wishList
     *
     * @return Form
     */
    public function ProductWishListForm($wishList = null)
    {
        $wishList = ($wishList !== null && $wishList instanceof ProductWishList && $wishList->exists()) ? $wishList : Injector::inst()->get('ProductWishList');

        $fields = $wishList->getFrontEndFields();

        if ($wishList->getIsEditing()) {
            $fields->push(HiddenField::create('ID')->setValue($wishList->ID));
        }

        $actions = $wishList->getFrontEndActions();

        $required = $wishList->getFrontEndRequiredFields();

        $controller = $this->getController();

        $form = Form::create($controller, 'ProductWishListForm', $fields, $actions, $required);

        $form->loadDataFrom($wishList);

        $this->owner->extend('updateProductWishListForm', $form);

        return $form;
    }

    /**
     * @return Object
     */
    protected function getController(){
        return ($this->owner->hasMethod('getCurrentPage'))
            ? $this->owner->getCurrentPage()
            : $this->owner;
    }

    /**
     * @param $data
     * @param Form $form
     */
    public function doProcessWishList($data, Form $form)
    {
        $wishList = (isset($data['ID'])) ? ProductWishList::get()->byID($data['ID']) : ProductWishList::create();
        $form->saveInto($wishList);
        if($wishList->write()){
            return $this->getController()->redirect($this->getController()->Link($wishList->getUpdateLink()));

The method getUpdateLink() does not exist on DataObject. Did you maybe mean update()?

        }
        return $this->getController()->redirect($this->getController()->Link('error'));
    }

    public function update(SS_HTTPRequest $request = null)
    {
        if ($request === null) {
            $request = Controller::curr()->getRequest();
        }

        $wishList = ProductWishList::get()->byID($request->param('ID'));

        return $this->owner->customise([
            'ProductWishListForm' => $this->ProductWishListForm($wishList),

It seems like $wishList defined by \ProductWishList::get()->byID($request->param('ID')) on line 76 can also be of type object<DataObject>; however, ProductWishListControllerExtension::ProductWishListForm() does only seem to accept null, maybe add an additional type check?

        ]);
    }

}