Dynamic\Wishlist\Extensions\ProductControllerExtension

Complexity

Total Complexity

2

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	addToWishList()	0	9	1
A	WishListForm()	0	3	1

<?php

namespace Dynamic\Wishlist\Extensions;

use Dynamic\Wishlist\Form\AddToWishListForm;
use Dynamic\Wishlist\Model\ProductWishList;
use SilverStripe\Core\Extension;
use SilverStripe\Forms\Form;

/**
 * Class ProductExtension
 * @package Dynamic\Wishlist\Extensions
 *
 * @property-read \SilverStripe\Control\Controller $owner
 */
class ProductControllerExtension extends Extension
{
    /**
     * @var array
     */
    private static $allowed_actions = [

The private property $allowed_actions is not used, and could be removed.

        'AddToWishListForm',
    ];

    /**
     * @return \Dynamic\Wishlist\Form\AddToWishListForm
     */
    public function WishListForm()
    {
        return AddToWishListForm::create($this->owner, 'WishListForm');
    }

    /**
     * @param $data
     * @param \SilverStripe\Forms\Form $form
     * @return \SilverStripe\Control\HTTPResponse
     * @throws \Exception
     */
    public function addToWishList($data, Form $form)

The parameter $form is not used and could be removed.

    {
        /** @var ProductWishList|\Dynamic\Nucu\Extension\WishListExtension $list */
        $list = ProductWishList::get()->filter([
            'ID' => $data['List'],
        ])->first();
        $list->Products()->add($data['ProductID']);

The method Products() does not exist on Dynamic\Wishlist\Model\ProductWishList. Since you implemented __call, consider adding a @method annotation.

        return $this->owner->redirectBack();
    }
}