Dynamic\Wishlist\Extensions\ProductWishListControllerExtension

Complexity

Total Complexity

7

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Test Coverage

Coverage

42.86%

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	updateCollectionItems()	0	7	2
A	view()	0	25	4
A	getController()	0	3	1

<?php

namespace Dynamic\Wishlist\Extensions;

use Dynamic\Wishlist\Model\ProductWishList;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Core\Extension;
use SilverStripe\Security\Security;

/**
 * Class ProductWishListControllerExtension
 */
class ProductWishListControllerExtension extends Extension
{

    /**
     * @var array
     */
    private static $allowed_actions = [

The private property $allowed_actions is not used, and could be removed.

        'view',
    ];

    /**
     * @return \SilverStripe\CMS\Controllers\ContentController|Object
     */
    protected function getController()
    {
        return $this->owner;
    }

    /**
     * @param HTTPRequest|null $request
     *
     * @return \SilverStripe\View\ViewableData_Customised|\SilverStripe\Control\HTTPResponse
     * @throws \SilverStripe\Control\HTTPResponse_Exception
     */
    public function view(HTTPRequest $request = null)
    {
        if ($request === null) {
            $request = $this->getController()->getRequest();
        }
        $id = $request->param('ID');

        /** @var ProductWishList $record */
        $record = ProductWishList::get()->filter([
            'URLSegment' => $id,
        ])->first();
        
        if ($record) {

$record is of type Dynamic\Wishlist\Model\ProductWishList, thus it always evaluated to true.

            if ($record->canView(Security::getCurrentUser())) {
                return $this->getController()->customise([
                    'WishList' => $record,
                    'Breadcrumbs' => $record->Breadcrumbs(),

The method Breadcrumbs() does not exist on Dynamic\Wishlist\Model\ProductWishList. Since you implemented __call, consider adding a @method annotation.

                    'ProductWishListForm' => false,
                ]);
            }

            return Security::permissionFailure($this->owner, "You don't have permission to view this record.");
        }

        return $this->getController()->httpError(404);
    }

    /**
     * @param \SilverStripe\ORM\ArrayList $collection
     * @param $searchCriteria
     */
    public function updateCollectionItems(&$collection, $searchCriteria)

The parameter $searchCriteria is not used and could be removed.

    {
        $memberID = 0;
        if ($member = Security::getCurrentUser()) {
            $memberID = $member->ID;
        }
        $collection = $collection->filter(['MemberID' => $memberID]);
    }
}