Dynamic\Wishlist\Extensions\ProductExtension

Complexity

Total Complexity

6

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	canRemoveFromWishList()	0	18	3
A	getRemoveLink()	0	18	3

<?php

namespace Dynamic\Wishlist\Extensions;


use Dynamic\Wishlist\Model\ProductWishList;
use SilverStripe\Control\Controller;
use SilverStripe\Core\Config\Config;
use SilverStripe\Core\Extension;
use SilverStripe\Security\Security;

/**
 * Class ProductExtension
 * @package Dynamic\Wishlist\Extensions
 */
class ProductExtension extends Extension
{

    /**
     * @return bool|String
     */
    public function getRemoveLink()
    {
        $wishListPage = Config::inst()->get(ProductWishList::class, 'listing_page_class');
        /** @var \SilverStripe\CMS\Model\SiteTree $page */
        $page = $page = $wishListPage::get()->first();

The assignment to $page is dead and can be removed.

        if (!$page) {

$page is of type SilverStripe\CMS\Model\SiteTree, thus it always evaluated to true.

            return false;
        }

        if (!$this->canRemoveFromWishList()) {
            return false;
        }

        return Controller::join_links(
            $page->Link('remove'),
            Controller::curr()->getRequest()->param('ID'),
            $this->owner->ID
        );
    }

    /**
     * @return bool
     */
    protected function canRemoveFromWishList()
    {
        $request = Controller::curr()->getRequest();
        $list = ProductWishList::get()->filter([
            'URLSegment' => $request->param('ID'),
        ])->first();

        if (!$list) {

$list is of type SilverStripe\ORM\DataObject, thus it always evaluated to true.

            $list = ProductWishList::get()->filter([
                'MemberID' => Security::getCurrentUser()->ID,
            ])->first();
        }

        if (!$list) {

$list is of type SilverStripe\ORM\DataObject, thus it always evaluated to true.

            return false;
        }

        return $list->canEdit(Security::getCurrentUser());
    }
}