ProductDocCollectionDataExtension::updateCollectionItems() - Code Metrics - Inspection of "SilverStripe 4.0 stable updates" - dynamic/silverstripe-product-catalog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by Jason

created 2017-12-01 03:50 UTC

updateCollectionItems() B

↳ Parent: ProductDocCollectionDataExtension

Complexity

Conditions	5
Paths	4

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	10
nc	4
nop	2
dl	0
loc	17
rs	8.8571
c	1
b	0
f	0

<?php

namespace Dynamic\ProductCatalog\ORM;

use Dynamic\ProductCatalog\Page\CatalogCategory;
use SilverStripe\Forms\DropdownField;
use SilverStripe\ORM\ArrayList;
use SilverStripe\ORM\DataExtension;

class ProductDocCollectionDataExtension extends DataExtension
{
    /**
     * @param $object
     */
    public function updateCollectionObject(&$object)
    {
        if ($class = $this->owner->data()->ManagedClass) {
            $object = (string) $class;
        }
    }

    /**
     * @param $form
     */
    public function updateCollectionForm(&$form)
    {
        $fields = $form->Fields();

        $fields->insertAfter(
            DropdownField::create('CategoryID', 'Category', CatalogCategory::get()->map())
            DropdownField::create(/** @scrutinizer ignore-type */ 'CategoryID', 'Category', CatalogCategory::get()->map())
                ->setEmptyString('All categories'),
            'Title'
        );

        $fields->insertAfter(
            DropdownField::create('Products__ID', 'Product', CatalogProduct::get()->map())
            DropdownField::create('Products__ID', 'Product', /** @scrutinizer ignore-type */ CatalogProduct::get()->map())
                ->setEmptyString('All products'),
            'CategoryID'
        );

        $fields->removeByName([
            'Name',
            'Title',
        ]);
    }

    /**
     * @param $collection
     * @param $searchCriteria
     */
    public function updateCollectionItems(&$collection, &$searchCriteria)
    {
        $class = $this->owner->data()->ManagedClass;

        if (isset($searchCriteria['CategoryID']) && $searchCriteria['CategoryID'] != '') {
            $category = CatalogCategory::get()->byID($searchCriteria['CategoryID']);
            $products = $category->Products();
            $docs = new ArrayList();

            foreach ($products as $product) {
                $records = $class::get()->filter(['Products.ID' => $product->ID]);
                $records = $class::/** @scrutinizer ignore-call */ get()->filter(['Products.ID' => $product->ID]);
                foreach ($records as $record) {
                    $docs->push($record);
                }
            }

            $collection = $docs;
        }
    }
}


dynamic / silverstripe-product-catalog

Pull Request — master (#30)

updateCollectionItems() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like