ProductDocCollectionDataExtension::updateCollectionItems() - Code Metrics - Inspection of "SilverStripe 4 upgrade" - dynamic/silverstripe-product-catalog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#24)

by Jason

created 2017-07-13 00:16 UTC

updateCollectionItems() B

↳ Parent: ProductDocCollectionDataExtension

Complexity

Conditions	5
Paths	4

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	0
cts	15
cp	0
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	11
nc	4
nop	2
crap	30

<?php

namespace Dynamic\ProductCatalog\ORM;

use Dynamic\ProductCatalog\Page\CatalogCategory;
use SilverStripe\Forms\DropdownField;
use SilverStripe\ORM\ArrayList;
use SilverStripe\ORM\DataExtension;

class ProductDocCollectionDataExtension extends DataExtension
{
    /**
     * @param $object
     */
    public function updateCollectionObject(&$object)
    {
        if ($class = $this->owner->data()->ManagedClass) {
            $object = (string) $class;
        }
    }

    /**
     * @param $form
     */
    public function updateCollectionForm(&$form)
    {
        $fields = $form->Fields();

        $fields->insertAfter(
            DropdownField::create('CategoryID', 'Category', CatalogCategory::get()->map())
                ->setEmptyString('All categories'),
            'Title'
        );

        $fields->insertAfter(
            DropdownField::create('Products__ID', 'Product', CatalogProduct::get()->map())
                ->setEmptyString('All products'),
            'CategoryID'
        );

        $fields->removeByName([
            'Name',
            'Title',
        ]);
    }

    /**
     * @param $collection
     * @param $searchCriteria
     */
    public function updateCollectionItems(&$collection, &$searchCriteria)
    {
        $class = $this->owner->data()->ManagedClass;

        if (isset($searchCriteria['CategoryID']) && $searchCriteria['CategoryID'] != '') {
            $category = CatalogCategory::get()->byID($searchCriteria['CategoryID']);
            $products = $category->Products();
            $docs = new ArrayList();

            foreach($products as $product) {
                $records = $class::get()->filter(['Products.ID' => $product->ID]);
                foreach ($records as $record) {
                    $docs->push($record);
                }
            }

            $collection = $docs;
        }
    }
}

1		<?php
2
3		namespace Dynamic\ProductCatalog\ORM;
4
5		use Dynamic\ProductCatalog\Page\CatalogCategory;
6		use SilverStripe\Forms\DropdownField;
7		use SilverStripe\ORM\ArrayList;
8	2	use SilverStripe\ORM\DataExtension;
9
10	2	class ProductDocCollectionDataExtension extends DataExtension
11	2	{
12	2	/**
13	2	* @param $object
14		*/
15		public function updateCollectionObject(&$object)
16		{
17		if ($class = $this->owner->data()->ManagedClass) {
18	1	$object = (string) $class;
19		}
20	1	}
21	1
22	1	/**
23	1	* @param $form
24		*/
25	1	public function updateCollectionForm(&$form)
26		{
27	1	$fields = $form->Fields();
28	1
29	1	$fields->insertAfter(
30	1	DropdownField::create('CategoryID', 'Category', CatalogCategory::get()->map())
31	1	->setEmptyString('All categories'),
32	1	'Title'
33		);
34
35		$fields->insertAfter(
36		DropdownField::create('Products__ID', 'Product', CatalogProduct::get()->map())
37		->setEmptyString('All products'),
38		'CategoryID'
39		);
40
41		$fields->removeByName([
42		'Name',
43		'Title',
44		]);
45		}
46
47		/**
48		* @param $collection
49		* @param $searchCriteria
50		*/
51		public function updateCollectionItems(&$collection, &$searchCriteria)
52		{
53		$class = $this->owner->data()->ManagedClass;
54
55		if (isset($searchCriteria['CategoryID']) && $searchCriteria['CategoryID'] != '') {
56		$category = CatalogCategory::get()->byID($searchCriteria['CategoryID']);
57		$products = $category->Products();
58		$docs = new ArrayList();
59
60		foreach($products as $product) {
61		$records = $class::get()->filter(['Products.ID' => $product->ID]);
62		foreach ($records as $record) {
63		$docs->push($record);
64		}
65		}
66
67		$collection = $docs;
68		}
69		}
70		}

dynamic / silverstripe-product-catalog

Pull Request — master (#24)

updateCollectionItems() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like