CareCleaningDocTest - Code Metrics - Inspection of "Merge pull request #17 from jsirish/feature/produc..." - dynamic/silverstripe-product-catalog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 868e11...05a781 )

by Jason

created 2017-06-06 16:30 UTC

CareCleaningDocTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	78
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	3
dl	78
loc	78
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetCMSFields()	12	12	1
A	testCanView()	10	10	1
A	testCanEdit()	10	10	1
A	testCanDelete()	10	10	1
A	testCanCreate()	10	10	1
A	testProvidePermissions()	10	10	1

How to fix Duplicated Code

<?php

class CareCleaningDocTest extends SapphireTest

{
    /**
     * @var string
     */
    protected static $fixture_file = 'product-catalog/tests/fixtures.yml';

    /**
     *
     */
    public function testGetCMSFields()
    {
        $object = new CareCleaningDoc();
        $fields = $object->getCMSFields();
        $this->assertInstanceOf('FieldList', $fields);
        $this->assertNull($fields->dataFieldByName('Products'));


        $object = $this->objFromFixture('CareCleaningDoc', 'one');
        $fields = $object->getCMSFields();
        $this->assertInstanceOf('FieldList', $fields);
        $this->assertNotNull($fields->dataFieldByName('Products'));

    }

    public function testCanView()
    {
        $object = $this->objFromFixture('CareCleaningDoc', 'one');

        $admin = $this->objFromFixture('Member', 'admin');
        $this->assertTrue($object->canView($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $member = $this->objFromFixture('Member', 'default');
        $this->assertTrue($object->canView($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanEdit()
    {
        $object = $this->objFromFixture('CareCleaningDoc', 'one');

        $admin = $this->objFromFixture('Member', 'admin');
        $this->assertTrue($object->canEdit($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $member = $this->objFromFixture('Member', 'default');
        $this->assertFalse($object->canEdit($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanDelete()
    {
        $object = $this->objFromFixture('CareCleaningDoc', 'one');

        $admin = $this->objFromFixture('Member', 'admin');
        $this->assertTrue($object->canDelete($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $member = $this->objFromFixture('Member', 'default');
        $this->assertFalse($object->canDelete($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanCreate()
    {
        $object = $this->objFromFixture('CareCleaningDoc', 'one');

        $admin = $this->objFromFixture('Member', 'admin');
        $this->assertTrue($object->canCreate($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $member = $this->objFromFixture('Member', 'default');
        $this->assertFalse($object->canCreate($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testProvidePermissions()
    {
        $object = $this->objFromFixture('CareCleaningDoc', 'one');
        $expected = array(
            'Care_EDIT' => 'Edit Care and Cleaning Docs',
            'Care_DELETE' => 'Delete Care and Cleaning Docs',
            'Care_CREATE' => 'Create Care and Cleaning Docs',
        );
        $this->assertEquals($expected, $object->providePermissions());

    }
}


1		<?php
2
3	View Code Duplication	class CareCleaningDocTest extends SapphireTest
		0 ignored issues – show Duplication introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
4		{
5		/**
6		* @var string
7		*/
8		protected static $fixture_file = 'product-catalog/tests/fixtures.yml';
9
10		/**
11		*
12		*/
13		public function testGetCMSFields()
14		{
15		$object = new CareCleaningDoc();
16		$fields = $object->getCMSFields();
17		$this->assertInstanceOf('FieldList', $fields);
18		$this->assertNull($fields->dataFieldByName('Products'));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertNull()` does not seem to exist on `object<CareCleaningDocTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
19
20		$object = $this->objFromFixture('CareCleaningDoc', 'one');
21		$fields = $object->getCMSFields();
22		$this->assertInstanceOf('FieldList', $fields);
23		$this->assertNotNull($fields->dataFieldByName('Products'));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertNotNull()` does not seem to exist on `object<CareCleaningDocTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
24		}
25
26		public function testCanView()
27		{
28		$object = $this->objFromFixture('CareCleaningDoc', 'one');
29
30		$admin = $this->objFromFixture('Member', 'admin');
31		$this->assertTrue($object->canView($admin));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'admin')` on line `30` can also be of type `object<DataObject>`; however, `DataObject::canView()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-06-06 16:10 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<CareCleaningDocTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
32
33		$member = $this->objFromFixture('Member', 'default');
34		$this->assertTrue($object->canView($member));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture('Member', 'default')` on line `33` can also be of type `object<DataObject>`; however, `DataObject::canView()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-06-06 16:10 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<CareCleaningDocTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
35		}
36
37		public function testCanEdit()
38		{
39		$object = $this->objFromFixture('CareCleaningDoc', 'one');
40
41		$admin = $this->objFromFixture('Member', 'admin');
42		$this->assertTrue($object->canEdit($admin));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'admin')` on line `41` can also be of type `object<DataObject>`; however, `DataObject::canEdit()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-06-06 16:10 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<CareCleaningDocTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
43
44		$member = $this->objFromFixture('Member', 'default');
45		$this->assertFalse($object->canEdit($member));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture('Member', 'default')` on line `44` can also be of type `object<DataObject>`; however, `DataObject::canEdit()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-06-06 16:10 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<CareCleaningDocTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
46		}
47
48		public function testCanDelete()
49		{
50		$object = $this->objFromFixture('CareCleaningDoc', 'one');
51
52		$admin = $this->objFromFixture('Member', 'admin');
53		$this->assertTrue($object->canDelete($admin));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'admin')` on line `52` can also be of type `object<DataObject>`; however, `DataObject::canDelete()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-06-06 16:10 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<CareCleaningDocTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
54
55		$member = $this->objFromFixture('Member', 'default');
56		$this->assertFalse($object->canDelete($member));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture('Member', 'default')` on line `55` can also be of type `object<DataObject>`; however, `DataObject::canDelete()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-06-06 16:10 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<CareCleaningDocTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
57		}
58
59		public function testCanCreate()
60		{
61		$object = $this->objFromFixture('CareCleaningDoc', 'one');
62
63		$admin = $this->objFromFixture('Member', 'admin');
64		$this->assertTrue($object->canCreate($admin));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'admin')` on line `63` can also be of type `object<DataObject>`; however, `DataObject::canCreate()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-06-06 16:10 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<CareCleaningDocTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
65
66		$member = $this->objFromFixture('Member', 'default');
67		$this->assertFalse($object->canCreate($member));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture('Member', 'default')` on line `66` can also be of type `object<DataObject>`; however, `DataObject::canCreate()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-06-06 16:10 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<CareCleaningDocTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
68		}
69
70		public function testProvidePermissions()
71		{
72		$object = $this->objFromFixture('CareCleaningDoc', 'one');
73		$expected = array(
74		'Care_EDIT' => 'Edit Care and Cleaning Docs',
75		'Care_DELETE' => 'Delete Care and Cleaning Docs',
76		'Care_CREATE' => 'Create Care and Cleaning Docs',
77		);
78		$this->assertEquals($expected, $object->providePermissions());
		0 ignored issues – show Bug introduced 2017-06-06 16:10 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CareCleaningDocTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
79		}
80		}
81

dynamic / silverstripe-product-catalog

Push — master ( 868e11...05a781 )

CareCleaningDocTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like