CatalogProduct - Code Metrics - Inspection of "Merge pull request #13 from jsirish/bugfix/product..." - dynamic/silverstripe-product-catalog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1ddc48...2a2bbb )

by Jason

created 2017-03-16 16:36 UTC

CatalogProduct A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	330
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	12

Test Coverage

Coverage

90.6%

Importance

Changes

Metric	Value
wmc	22
lcom	1
cbo	12
dl	0
loc	330
ccs	106
cts	117
cp	0.906
rs	10
c	0
b	0
f	0

15 Methods

Rating	Name	Size	Complexity
A	fieldLabels()	9	1
A	CategoryList()	15	4
A	getImage()	6	2
A	Image()	4	1
A	ProductThumbnail()	6	1
B	getCMSFields()	86	3
A	getPrimaryCategory()	9	2
A	getParentPage()	4	1
A	getViewAction()	4	1
A	getAncestors()	4	1
A	providePermissions()	8	1
A	canEdit()	4	1
A	canDelete()	4	1
A	canCreate()	4	1
A	canView()	4	1

<?php

class CatalogProduct extends DataObject implements PermissionProvider, Dynamic\ViewableDataObject\VDOInterfaces\ViewableDataObjectInterface
{
    /**
     * @var string
     */
    private static $singular_name = 'Product';

    /**
     * @var string
     */
    private static $plural_name = 'Products';

    /**
     * @var array
     */
    private static $db = array(
        'Title' => 'Varchar(255)',
        'Content' => 'HTMLText',
        'QuickFeatures' => 'HTMLText',
        'Dimensions' => 'Varchar(255)',
        'SKU' => 'Varchar(50)',
    );

    /**
     * @var array
     */
    private static $many_many = array(
        'Categories' => 'CatalogCategory',
        'CareCleaningDocs' => 'CareCleaningDoc',
        'OperationManuals' => 'OperationManual',
        'SpecSheets' => 'SpecSheet',
        'Warranties' => 'Warranty',
    );

    /**
     * @var array
     */
    private static $many_many_extraFields = array(
        'Categories' => array(
            'SortOrder' => 'Int',
        ),
        'CareCleaningDocs' => array(
            'Sort' => 'Int',
        ),
        'OperationManuals' => array(
            'Sort' => 'Int',
        ),
        'SpecSheets' => array(
            'Sort' => 'Int',
        ),
        'Warranties' => array(
            'Sort' => 'Int',
        ),
    );

    /**
     * @var array
     */
    private static $summary_fields = array(
        'ProductThumbnail' => 'Image',
        'Title' => 'Title',
        'Type' => 'Type',
        'CategoryList' => 'Categories',
    );

    /**
     * @var array
     */
    private static $searchable_fields = array(
        'Title' => array(
            'title' => 'Product Name',
        ),
        'Categories.ID' => array(
            'title' => 'Category',
        ),
    );

    /**
     * @var array
     */
    private static $extensions = [
        'VersionedDataObject',
    ];

    /**
     * @param bool $includerelations
     * @return array|string
     */
    public function fieldLabels($includerelations = true)
    {
        $labels = parent::fieldLabels($includerelations);

        $labels['Title'] = 'Product Name';
        $labels['Categories.ID'] = 'Category';

        return $labels;
    }

    /**
     * @return string
     */
    public function CategoryList()
    {
        $list = '';

        if ($this->Categories()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $i = 0;
            foreach ($this->Categories()->sort('SortOrder') as $category) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                $list .= $category->Title;
                if(++$i !== $this->Categories()->Count()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    $list .= ", ";
                }
            }
        }
        return $list;
    }

    /**
     * @return mixed
     */
    public function getImage()
    {
        if ($this->Slides()->exists()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return $this->Slides()->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
    }

    /**
     * @return mixed
     */
    public function Image()
    {
        return $this->getImage();
    }

    /**
     * @return mixed
     */
    public function ProductThumbnail()
    {
        $image = $this->getImage();
        $thumb = Image::get()->byID($image->ID);
        return $thumb->CMSThumbnail();
    }

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $remove = [
            'Categories',
            'CareCleaningDocs',
            'OperationManuals',
            'SpecSheets',
            'Warranties',
            'DisabledBlocks',
        ];

        if (!$this->ID) {
            $remove[] = 'Blocks';
        }

        $fields->removeByName($remove);

        $fields->insertBefore(
            $fields->dataFieldByName('SKU'),
            'Content'
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $fields->addFieldsToTab('Root.Info', array(
            TextField::create('Dimensions'),
            HTMLEditorField::create('QuickFeatures'),
        ));

        if ($this->ID) {
            // Categories
            $config = GridFieldConfig_RelationEditor::create();
            $config->addComponent(new GridFieldOrderableRows('SortOrder'));
            $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
            $config->addComponent(new GridFieldAddExistingSearchButton());
            $config->removeComponentsByType('GridFieldAddNewButton');
            $categories = $this->Categories()->sort('SortOrder');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $categoryField = GridField::create('Categories', 'Categories', $categories, $config);

            $fields->addFieldsToTab('Root.Categories.Categories', array(
                $categoryField,
            ));

            // Care and Cleaning
            $config = GridFieldConfig_RecordEditor::create();
            $config->addComponent(new GridFieldOrderableRows('Sort'));
            $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
            $config->addComponent(new GridFieldAddExistingSearchButton());
            $operation = GridField::create('CareCleaningDocs', 'Care and Cleaning', $this->CareCleaningDocs()->sort('Sort'), $config);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $fields->addFieldsToTab('Root.Files.Care', array(
                $operation,
            ));

            // Operation Manuals
            $config = GridFieldConfig_RecordEditor::create();
            $config->addComponent(new GridFieldOrderableRows('Sort'));
            $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
            $config->addComponent(new GridFieldAddExistingSearchButton());
            $operation = GridField::create('OperationManuals', 'Operation Manuals', $this->OperationManuals()->sort('Sort'), $config);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $fields->addFieldsToTab('Root.Files.Operation', array(
                $operation,
            ));

            // Spec Sheets
            $config = GridFieldConfig_RecordEditor::create();
            $config->addComponent(new GridFieldOrderableRows('Sort'));
            $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
            $config->addComponent(new GridFieldAddExistingSearchButton());
            $specsheets = GridField::create('SpecSheets', 'Spec Sheets', $this->SpecSheets()->sort('Sort'), $config);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $fields->addFieldsToTab('Root.Files.SpecSheets', array(
                $specsheets,
            ));

            // Warranties
            $config = GridFieldConfig_RecordEditor::create();
            $config->addComponent(new GridFieldOrderableRows('Sort'));
            $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
            $config->addComponent(new GridFieldAddExistingSearchButton());
            $warranties = GridField::create('Warranties', 'Warranties', $this->Warranties()->sort('Sort'), $config);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $fields->addFieldsToTab('Root.Files.Warranty', array(
                $warranties,
            ));
        }

        return $fields;
    }

    /**
     * @return CatalogCategory
     */
    public function getPrimaryCategory()
    {
        if ($this->Categories()->exists()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $category = $this->Categories()->sort('SortOrder')->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        } else {
            $category = CatalogCategory::get()->first();
        }
        return $category;
    }

    /**
     * set ParentPage for ViewableDataobject
     *
     * @return string
     */
    public function getParentPage()
    {
        return $this->getPrimaryCategory();
    }

    /**
     * set ViewAction for ViewableDataobject
     *
     * @return string
     */
    public function getViewAction()
    {
        return 'view';
    }

    /**
     * set Ancestors, needed for Blocks on Dataobjects
     *
     * @return DataList
     */
    public function getAncestors()
    {
        return CatalogCategory::get();
    }

    /**
     * @return array
     */
    public function providePermissions()
    {
        return array(
            'Product_EDIT' => 'Edit a Product',
            'Product_DELETE' => 'Delete a Product',
            'Product_CREATE' => 'Create a Product',
        );
    }

    /**
     * @param null $member
     *
     * @return bool|int
     */
    public function canEdit($member = null)
    {
        return Permission::check('Product_EDIT', 'any', $member);
    }

    /**
     * @param null $member
     *
     * @return bool|int
     */
    public function canDelete($member = null)
    {
        return Permission::check('Product_DELETE', 'any', $member);
    }

    /**
     * @param null $member
     *
     * @return bool|int
     */
    public function canCreate($member = null)
    {
        return Permission::check('Product_CREATE', 'any', $member);
    }

    /**
     * @param null $member
     *
     * @return bool
     */
    public function canView($member = null)
    {
        return true;
    }
}

1		<?php
2
3		class CatalogProduct extends DataObject implements PermissionProvider, Dynamic\ViewableDataObject\VDOInterfaces\ViewableDataObjectInterface
4		{
5		/**
6		* @var string
7		*/
8		private static $singular_name = 'Product';
9
10		/**
11		* @var string
12		*/
13		private static $plural_name = 'Products';
14
15		/**
16		* @var array
17		*/
18		private static $db = array(
19		'Title' => 'Varchar(255)',
20		'Content' => 'HTMLText',
21		'QuickFeatures' => 'HTMLText',
22		'Dimensions' => 'Varchar(255)',
23		'SKU' => 'Varchar(50)',
24		);
25
26		/**
27		* @var array
28		*/
29		private static $many_many = array(
30		'Categories' => 'CatalogCategory',
31		'CareCleaningDocs' => 'CareCleaningDoc',
32		'OperationManuals' => 'OperationManual',
33		'SpecSheets' => 'SpecSheet',
34		'Warranties' => 'Warranty',
35		);
36
37		/**
38		* @var array
39		*/
40		private static $many_many_extraFields = array(
41		'Categories' => array(
42		'SortOrder' => 'Int',
43		),
44		'CareCleaningDocs' => array(
45		'Sort' => 'Int',
46		),
47		'OperationManuals' => array(
48		'Sort' => 'Int',
49		),
50		'SpecSheets' => array(
51		'Sort' => 'Int',
52		),
53		'Warranties' => array(
54		'Sort' => 'Int',
55		),
56		);
57
58		/**
59		* @var array
60		*/
61		private static $summary_fields = array(
62		'ProductThumbnail' => 'Image',
63		'Title' => 'Title',
64		'Type' => 'Type',
65		'CategoryList' => 'Categories',
66		);
67
68		/**
69		* @var array
70		*/
71		private static $searchable_fields = array(
72		'Title' => array(
73		'title' => 'Product Name',
74		),
75		'Categories.ID' => array(
76		'title' => 'Category',
77		),
78		);
79
80		/**
81		* @var array
82		*/
83		private static $extensions = [
84		'VersionedDataObject',
85		];
86
87		/**
88		* @param bool $includerelations
89		* @return array\|string
90		*/
91	2	public function fieldLabels($includerelations = true)
92		{
93	2	$labels = parent::fieldLabels($includerelations);
94
95	2	$labels['Title'] = 'Product Name';
96	2	$labels['Categories.ID'] = 'Category';
97
98	2	return $labels;
99		}
100
101		/**
102		* @return string
103		*/
104	1	public function CategoryList()
105		{
106	1	$list = '';
107
108	1	if ($this->Categories()) {
		0 ignored issues – show Documentation Bug introduced 2017-02-19 05:05 UTC by Report Bug Copy Issue Report The method `Categories` does not exist on `object<CatalogProduct>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
109	1	$i = 0;
110	1	foreach ($this->Categories()->sort('SortOrder') as $category) {
		0 ignored issues – show Documentation Bug introduced 2017-02-19 05:05 UTC by Report Bug Copy Issue Report The method `Categories` does not exist on `object<CatalogProduct>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
111	1	$list .= $category->Title;
112	1	if(++$i !== $this->Categories()->Count()) {
		0 ignored issues – show Documentation Bug introduced 2017-02-19 05:05 UTC by Report Bug Copy Issue Report The method `Categories` does not exist on `object<CatalogProduct>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
113		$list .= ", ";
114		}
115	1	}
116	1	}
117	1	return $list;
118		}
119
120		/**
121		* @return mixed
122		*/
123	1	public function getImage()
124		{
125	1	if ($this->Slides()->exists()) {
		0 ignored issues – show Documentation Bug introduced 2017-02-19 05:05 UTC by Report Bug Copy Issue Report The method `Slides` does not exist on `object<CatalogProduct>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
126		return $this->Slides()->first();
		0 ignored issues – show Documentation Bug introduced 2017-02-19 05:05 UTC by Report Bug Copy Issue Report The method `Slides` does not exist on `object<CatalogProduct>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
127		}
128	1	}
129
130		/**
131		* @return mixed
132		*/
133		public function Image()
134		{
135		return $this->getImage();
136		}
137
138		/**
139		* @return mixed
140		*/
141		public function ProductThumbnail()
142		{
143		$image = $this->getImage();
144		$thumb = Image::get()->byID($image->ID);
145		return $thumb->CMSThumbnail();
146		}
147
148		/**
149		* @return FieldList
150		*/
151	1	public function getCMSFields()
152		{
153	1	$fields = parent::getCMSFields();
154
155		$remove = [
156	1	'Categories',
157	1	'CareCleaningDocs',
158	1	'OperationManuals',
159	1	'SpecSheets',
160	1	'Warranties',
161	1	'DisabledBlocks',
162	1	];
163
164	1	if (!$this->ID) {
165	1	$remove[] = 'Blocks';
166	1	}
167
168	1	$fields->removeByName($remove);
169
170	1	$fields->insertBefore(
171	1	$fields->dataFieldByName('SKU'),
172		'Content'
		0 ignored issues – show Documentation introduced 2017-03-02 05:04 UTC by Report Bug Copy Issue Report `'Content'` is of type `string`, but the function expects a `object<FormField>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
173	1	);
174
175	1	$fields->addFieldsToTab('Root.Info', array(
176	1	TextField::create('Dimensions'),
177	1	HTMLEditorField::create('QuickFeatures'),
178	1	));
179
180	1	if ($this->ID) {
181		// Categories
182	1	$config = GridFieldConfig_RelationEditor::create();
183	1	$config->addComponent(new GridFieldOrderableRows('SortOrder'));
184	1	$config->removeComponentsByType('GridFieldAddExistingAutocompleter');
185	1	$config->addComponent(new GridFieldAddExistingSearchButton());
186	1	$config->removeComponentsByType('GridFieldAddNewButton');
187	1	$categories = $this->Categories()->sort('SortOrder');
		0 ignored issues – show Documentation Bug introduced 2017-02-19 05:05 UTC by Report Bug Copy Issue Report The method `Categories` does not exist on `object<CatalogProduct>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
188	1	$categoryField = GridField::create('Categories', 'Categories', $categories, $config);
189
190	1	$fields->addFieldsToTab('Root.Categories.Categories', array(
191	1	$categoryField,
192	1	));
193
194		// Care and Cleaning
195	1	$config = GridFieldConfig_RecordEditor::create();
196	1	$config->addComponent(new GridFieldOrderableRows('Sort'));
197	1	$config->removeComponentsByType('GridFieldAddExistingAutocompleter');
198	1	$config->addComponent(new GridFieldAddExistingSearchButton());
199	1	$operation = GridField::create('CareCleaningDocs', 'Care and Cleaning', $this->CareCleaningDocs()->sort('Sort'), $config);
		0 ignored issues – show Documentation Bug introduced 2017-02-19 05:05 UTC by Report Bug Copy Issue Report The method `CareCleaningDocs` does not exist on `object<CatalogProduct>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
200	1	$fields->addFieldsToTab('Root.Files.Care', array(
201	1	$operation,
202	1	));
203
204		// Operation Manuals
205	1	$config = GridFieldConfig_RecordEditor::create();
206	1	$config->addComponent(new GridFieldOrderableRows('Sort'));
207	1	$config->removeComponentsByType('GridFieldAddExistingAutocompleter');
208	1	$config->addComponent(new GridFieldAddExistingSearchButton());
209	1	$operation = GridField::create('OperationManuals', 'Operation Manuals', $this->OperationManuals()->sort('Sort'), $config);
		0 ignored issues – show Documentation Bug introduced 2017-02-19 05:05 UTC by Report Bug Copy Issue Report The method `OperationManuals` does not exist on `object<CatalogProduct>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
210	1	$fields->addFieldsToTab('Root.Files.Operation', array(
211	1	$operation,
212	1	));
213
214		// Spec Sheets
215	1	$config = GridFieldConfig_RecordEditor::create();
216	1	$config->addComponent(new GridFieldOrderableRows('Sort'));
217	1	$config->removeComponentsByType('GridFieldAddExistingAutocompleter');
218	1	$config->addComponent(new GridFieldAddExistingSearchButton());
219	1	$specsheets = GridField::create('SpecSheets', 'Spec Sheets', $this->SpecSheets()->sort('Sort'), $config);
		0 ignored issues – show Documentation Bug introduced 2017-02-19 05:05 UTC by Report Bug Copy Issue Report The method `SpecSheets` does not exist on `object<CatalogProduct>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
220	1	$fields->addFieldsToTab('Root.Files.SpecSheets', array(
221	1	$specsheets,
222	1	));
223
224		// Warranties
225	1	$config = GridFieldConfig_RecordEditor::create();
226	1	$config->addComponent(new GridFieldOrderableRows('Sort'));
227	1	$config->removeComponentsByType('GridFieldAddExistingAutocompleter');
228	1	$config->addComponent(new GridFieldAddExistingSearchButton());
229	1	$warranties = GridField::create('Warranties', 'Warranties', $this->Warranties()->sort('Sort'), $config);
		0 ignored issues – show Documentation Bug introduced 2017-02-19 05:05 UTC by Report Bug Copy Issue Report The method `Warranties` does not exist on `object<CatalogProduct>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
230	1	$fields->addFieldsToTab('Root.Files.Warranty', array(
231	1	$warranties,
232	1	));
233	1	}
234
235	1	return $fields;
236		}
237
238		/**
239		* @return CatalogCategory
240		*/
241	2	public function getPrimaryCategory()
242		{
243	2	if ($this->Categories()->exists()) {
		0 ignored issues – show Documentation Bug introduced 2017-02-19 05:05 UTC by Report Bug Copy Issue Report The method `Categories` does not exist on `object<CatalogProduct>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
244	2	$category = $this->Categories()->sort('SortOrder')->first();
		0 ignored issues – show Documentation Bug introduced 2017-02-19 05:05 UTC by Report Bug Copy Issue Report The method `Categories` does not exist on `object<CatalogProduct>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
245	2	} else {
246	1	$category = CatalogCategory::get()->first();
247		}
248	2	return $category;
249		}
250
251		/**
252		* set ParentPage for ViewableDataobject
253		*
254		* @return string
255		*/
256	1	public function getParentPage()
257		{
258	1	return $this->getPrimaryCategory();
259		}
260
261		/**
262		* set ViewAction for ViewableDataobject
263		*
264		* @return string
265		*/
266	1	public function getViewAction()
267		{
268	1	return 'view';
269		}
270
271		/**
272		* set Ancestors, needed for Blocks on Dataobjects
273		*
274		* @return DataList
275		*/
276		public function getAncestors()
277		{
278		return CatalogCategory::get();
279		}
280
281		/**
282		* @return array
283		*/
284	1	public function providePermissions()
285		{
286		return array(
287	1	'Product_EDIT' => 'Edit a Product',
288	1	'Product_DELETE' => 'Delete a Product',
289	1	'Product_CREATE' => 'Create a Product',
290	1	);
291		}
292
293		/**
294		* @param null $member
295		*
296		* @return bool\|int
297		*/
298	1	public function canEdit($member = null)
299		{
300	1	return Permission::check('Product_EDIT', 'any', $member);
301		}
302
303		/**
304		* @param null $member
305		*
306		* @return bool\|int
307		*/
308	1	public function canDelete($member = null)
309		{
310	1	return Permission::check('Product_DELETE', 'any', $member);
311		}
312
313		/**
314		* @param null $member
315		*
316		* @return bool\|int
317		*/
318	1	public function canCreate($member = null)
319		{
320	1	return Permission::check('Product_CREATE', 'any', $member);
321		}
322
323		/**
324		* @param null $member
325		*
326		* @return bool
327		*/
328	1	public function canView($member = null)
329		{
330	1	return true;
331		}
332		}

dynamic / silverstripe-product-catalog

Push — master ( 1ddc48...2a2bbb )

CatalogProduct A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

15 Methods

Duplication Side-by-Side

Filter issues like