SpecSheetTest::testCanEdit() - Code Metrics - Inspection of "Merge pull request #24 from jsirish/refactor/ss4" - dynamic/silverstripe-product-catalog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b7abe3...4d4cc4 )

by Jason

created 2017-12-01 02:50 UTC

SpecSheetTest::testCanEdit() A

↳ Parent: SpecSheetTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
dl	10
loc	10
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	6
nc	1
nop	0

<?php

namespace Dynamic\ProductCatalog\Test;

use Dynamic\ProductCatalog\Docs\SpecSheet;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Forms\FieldList;
use SilverStripe\Security\Member;

class SpecSheetTest extends SapphireTest

{
    /**
     * @var string
     */
    protected static $fixture_file = 'product-catalog/tests/fixtures.yml';

    public function testGetCMSFields()
    {
        $object = new SpecSheet();
        $fields = $object->getCMSFields();
        $this->assertInstanceOf(FieldList::class, $fields);

        $object = $this->objFromFixture(SpecSheet::class, 'one');
        $fields = $object->getCMSFields();
        $this->assertInstanceOf(FieldList::class, $fields);
    }

    public function testCanView()
    {
        $object = $this->objFromFixture(SpecSheet::class, 'one');

        $admin = $this->objFromFixture(Member::class, 'admin');
        $this->assertTrue($object->canView($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $member = $this->objFromFixture(Member::class, 'default');
        $this->assertTrue($object->canView($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanEdit()
    {
        $object = $this->objFromFixture(SpecSheet::class, 'one');

        $admin = $this->objFromFixture(Member::class, 'admin');
        $this->assertTrue($object->canEdit($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $member = $this->objFromFixture(Member::class, 'default');
        $this->assertFalse($object->canEdit($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanDelete()
    {
        $object = $this->objFromFixture(SpecSheet::class, 'one');

        $admin = $this->objFromFixture(Member::class, 'admin');
        $this->assertTrue($object->canDelete($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $member = $this->objFromFixture(Member::class, 'default');
        $this->assertFalse($object->canDelete($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanCreate()
    {
        $object = $this->objFromFixture(SpecSheet::class, 'one');

        $admin = $this->objFromFixture(Member::class, 'admin');
        $this->assertTrue($object->canCreate($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $member = $this->objFromFixture(Member::class, 'default');
        $this->assertFalse($object->canCreate($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testProvidePermissions()
    {
        $object = $this->objFromFixture(SpecSheet::class, 'one');
        $expected = array(
            'Spec_EDIT' => 'Edit Spec Sheets',
            'Spec_DELETE' => 'Delete Spec Sheets',
            'Spec_CREATE' => 'Create Spec Sheets',
        );
        $this->assertEquals($expected, $object->providePermissions());
    }
}


1		<?php
2
3		namespace Dynamic\ProductCatalog\Test;
4
5		use Dynamic\ProductCatalog\Docs\SpecSheet;
6		use SilverStripe\Dev\SapphireTest;
7		use SilverStripe\Forms\FieldList;
8		use SilverStripe\Security\Member;
9
10	View Code Duplication	class SpecSheetTest extends SapphireTest
		0 ignored issues – show Duplication introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		/**
13		* @var string
14		*/
15		protected static $fixture_file = 'product-catalog/tests/fixtures.yml';
16
17		public function testGetCMSFields()
18		{
19		$object = new SpecSheet();
20		$fields = $object->getCMSFields();
21		$this->assertInstanceOf(FieldList::class, $fields);
22
23		$object = $this->objFromFixture(SpecSheet::class, 'one');
24		$fields = $object->getCMSFields();
25		$this->assertInstanceOf(FieldList::class, $fields);
26		}
27
28		public function testCanView()
29		{
30		$object = $this->objFromFixture(SpecSheet::class, 'one');
31
32		$admin = $this->objFromFixture(Member::class, 'admin');
33		$this->assertTrue($object->canView($admin));
		0 ignored issues – show Bug introduced 2017-07-12 21:22 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture(\S...Member::class, 'admin')` on line `32` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canView()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
34
35		$member = $this->objFromFixture(Member::class, 'default');
36		$this->assertTrue($object->canView($member));
		0 ignored issues – show Bug introduced 2017-07-12 21:22 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture(\S...mber::class, 'default')` on line `35` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canView()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
37		}
38
39		public function testCanEdit()
40		{
41		$object = $this->objFromFixture(SpecSheet::class, 'one');
42
43		$admin = $this->objFromFixture(Member::class, 'admin');
44		$this->assertTrue($object->canEdit($admin));
		0 ignored issues – show Bug introduced 2017-07-12 21:22 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture(\S...Member::class, 'admin')` on line `43` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canEdit()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
45
46		$member = $this->objFromFixture(Member::class, 'default');
47		$this->assertFalse($object->canEdit($member));
		0 ignored issues – show Bug introduced 2017-07-12 21:22 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture(\S...mber::class, 'default')` on line `46` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canEdit()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
48		}
49
50		public function testCanDelete()
51		{
52		$object = $this->objFromFixture(SpecSheet::class, 'one');
53
54		$admin = $this->objFromFixture(Member::class, 'admin');
55		$this->assertTrue($object->canDelete($admin));
		0 ignored issues – show Bug introduced 2017-07-12 21:22 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture(\S...Member::class, 'admin')` on line `54` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canDelete()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
56
57		$member = $this->objFromFixture(Member::class, 'default');
58		$this->assertFalse($object->canDelete($member));
		0 ignored issues – show Bug introduced 2017-07-12 21:22 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture(\S...mber::class, 'default')` on line `57` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canDelete()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
59		}
60
61		public function testCanCreate()
62		{
63		$object = $this->objFromFixture(SpecSheet::class, 'one');
64
65		$admin = $this->objFromFixture(Member::class, 'admin');
66		$this->assertTrue($object->canCreate($admin));
		0 ignored issues – show Bug introduced 2017-07-12 21:22 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture(\S...Member::class, 'admin')` on line `65` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canCreate()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
67
68		$member = $this->objFromFixture(Member::class, 'default');
69		$this->assertFalse($object->canCreate($member));
		0 ignored issues – show Bug introduced 2017-07-12 21:22 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture(\S...mber::class, 'default')` on line `68` can also be of type `object<SilverStripe\ORM\DataObject>`; however, `SilverStripe\ORM\DataObject::canCreate()` does only seem to accept `object<SilverStripe\Security\Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
70		}
71
72		public function testProvidePermissions()
73		{
74		$object = $this->objFromFixture(SpecSheet::class, 'one');
75		$expected = array(
76		'Spec_EDIT' => 'Edit Spec Sheets',
77		'Spec_DELETE' => 'Delete Spec Sheets',
78		'Spec_CREATE' => 'Create Spec Sheets',
79		);
80		$this->assertEquals($expected, $object->providePermissions());
81		}
82		}
83

dynamic / silverstripe-product-catalog

Push — master ( b7abe3...4d4cc4 )

SpecSheetTest::testCanEdit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like