ProductDocDataExtension

Complexity

Total Complexity

11

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

94.23%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getProductsCt()	0	7	2
A	getProductsList()	0	15	4
B	updateCMSFields()	0	40	3
A	Link()	0	4	1
A	getIsProductDoc()	0	3	1

<?php

class ProductDocDataExtension extends DataExtension
{
    /**
     * @var array
     */
    private static $belongs_many_many = array(
        'Products' => 'CatalogProduct',
    );

    /**
     * @var array
     */
    private static $summary_fields = array(
        'Name' => 'Name',
        'Title' => 'Title',
        'ProductsCt' => 'Products',
    );

    /**
     * @var array
     */
    private static $searchable_fields = array(
        'Name',
        'Title',
        'Products.ID',
    );

    /**
     * @return int
     */
    public function getProductsCt()
    {
        if ($this->owner->Products()->exists()) {
            return $this->owner->Products()->count();
        }
        return 0;
    }

    /**
     * @return string
     */
    public function getProductsList()
    {
        $list = '';

        if ($this->owner->Products()->exists()) {
            $i = 0;
            foreach($this->owner->Products() as $product) {
                $list .= $product->Title;
                if(++$i !== $this->owner->Products()->Count()) {
                    $list .= ", ";
                }
            }
        }
        return $list;
    }

    /**
     * @param FieldList $fields
     */
    public function updateCMSFields(FieldList $fields)
    {
        $fields->removeByName(array(
            'Link',
            'SortOrder',
            'Products',
        ));

        $classes = ClassInfo::subclassesFor('ProductDoc');
        unset($classes['ProductDoc']);

        $result = array();
        foreach ($classes as $class) {

The expression $classes of type null|array is not guaranteed to be traversable. How about adding an additional type check?

            $instance = singleton($class);
            $pageTypeName = $instance->i18n_singular_name();
            $result[$class] = $pageTypeName;
        }

        $fields->addFieldToTab(
            'Root.Main',
            DropdownField::create('SetClass', 'File type', $result, $this->owner->Classname)
                ->setEmptyString(''),
            'Content'
        );

        $fields->dataFieldByName('Image')
            ->setFolderName('Uploads/ProductDocs/Images');

        if ($this->owner->ID) {
            // products
            $config = GridFieldConfig_RelationEditor::create();
            $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
            $config->addComponent(new GridFieldAddExistingSearchButton());
            $config->removeComponentsByType('GridFieldAddNewButton');
            $products = $this->owner->Products();
            $productsField = GridField::create('Products', 'Products', $products, $config);

            $fields->addFieldToTab('Root.Products', $productsField);
        }
    }

    /**
     * Link for searchable result set
     *
     * @return mixed
     */
    public function Link()
    {
        return $this->owner->Download()->URL;
    }

    /**
     * @return bool
     */
    public function getIsProductDoc() {
        return true;
    }
}