CatalogProductInquiryFormTest - Code Metrics - Inspection of "ENHANCEMENT ProductInquiry" - dynamic/silverstripe-product-catalog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 1.0 (#29)

by Nic

created 2017-11-08 21:47 UTC

CatalogProductInquiryFormTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	50 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	4
lcom	0
cbo	2
dl	24
loc	48
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testCatalogProductInquiryFormFields()	12	12	2
A	testCatalogProductInquiryFormActions()	12	12	2

How to fix Duplicated Code

<?php

/**
 * Class CatalogProductInquiryFormTest
 */
class CatalogProductInquiryFormTest extends SapphireTest
{

    /**
     * @var string
     */
    protected static $fixture_file = 'product-catalog/tests/fixtures.yml';

    /**
     * @var array
     */
    protected $extraDataObjects = [
        'TestCatalogCategory',
    ];

    /**
     *
     */
    public function testCatalogProductInquiryFormFields()

    {
        $form = CatalogProductInquiryForm::create(CatalogCategory_Controller::create($this->objFromFixture('CatalogCategory',
            'default')), 'ProductInquiryForm');
        $fields = $form->Fields();

        $this->assertInstanceOf('FieldList', $fields);

        foreach ($fields as $field) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $this->assertInstanceOf('FormField', $field, "field {$field->getName()} isn't a FormField instance");
        }
    }

    /**
     *
     */
    public function testCatalogProductInquiryFormActions()

    {
        $form = CatalogProductInquiryForm::create(CatalogCategory_Controller::create($this->objFromFixture('CatalogCategory',
            'default')), 'ProductInquiryForm');
        $actions = $form->Actions();

        $this->assertInstanceOf('FieldList', $actions);

        foreach ($actions as $action) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $this->assertInstanceOf('FormAction', $action, "action {$action->getName()} isn't a FormAction instance");
        }
    }

}

1		<?php
2
3		/**
4		* Class CatalogProductInquiryFormTest
5		*/
6		class CatalogProductInquiryFormTest extends SapphireTest
7		{
8
9		/**
10		* @var string
11		*/
12		protected static $fixture_file = 'product-catalog/tests/fixtures.yml';
13
14		/**
15		* @var array
16		*/
17		protected $extraDataObjects = [
18		'TestCatalogCategory',
19		];
20
21		/**
22		*
23		*/
24	View Code Duplication	public function testCatalogProductInquiryFormFields()
		0 ignored issues – show Duplication introduced 2017-11-08 22:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		{
26		$form = CatalogProductInquiryForm::create(CatalogCategory_Controller::create($this->objFromFixture('CatalogCategory',
27		'default')), 'ProductInquiryForm');
28		$fields = $form->Fields();
29
30		$this->assertInstanceOf('FieldList', $fields);
31
32		foreach ($fields as $field) {
		0 ignored issues – show Bug introduced 2017-11-08 22:01 UTC by Report Bug Copy Issue Report The expression `$fields` of type `object<FieldList>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
33		$this->assertInstanceOf('FormField', $field, "field {$field->getName()} isn't a FormField instance");
34		}
35		}
36
37		/**
38		*
39		*/
40	View Code Duplication	public function testCatalogProductInquiryFormActions()
		0 ignored issues – show Duplication introduced 2017-11-08 22:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41		{
42		$form = CatalogProductInquiryForm::create(CatalogCategory_Controller::create($this->objFromFixture('CatalogCategory',
43		'default')), 'ProductInquiryForm');
44		$actions = $form->Actions();
45
46		$this->assertInstanceOf('FieldList', $actions);
47
48		foreach ($actions as $action) {
		0 ignored issues – show Bug introduced 2017-11-08 22:01 UTC by Report Bug Copy Issue Report The expression `$actions` of type `object<FieldList>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
49		$this->assertInstanceOf('FormAction', $action, "action {$action->getName()} isn't a FormAction instance");
50		}
51		}
52
53		}

dynamic / silverstripe-product-catalog

Pull Request — 1.0 (#29)

CatalogProductInquiryFormTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like