CatalogProductTest - Code Metrics - Inspection of "initial tests" - dynamic/silverstripe-product-catalog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Jason

created 2017-02-19 05:19 UTC

CatalogProductTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	105
Duplicated Lines	38.1 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	10
lcom	1
cbo	2
dl	40
loc	105
rs	10
c	0
b	0
f	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	testCategoryList()	0	6	1
A	testGetImage()	0	5	1
A	testGetCMSFields()	0	11	1
A	testGetPrimaryCategory()	0	5	1
A	testGetDefaultSearchContext()	0	5	1
A	testCanView()	10	10	1
A	testCanEdit()	10	10	1
A	testCanDelete()	10	10	1
A	testCanCreate()	10	10	1
A	testProvidePermissions()	0	10	1

How to fix Duplicated Code

<?php

class CatalogProductTest extends SapphireTest
{
    /**
     * @var string
     */
    protected static $fixture_file = 'product-catalog/tests/fixtures.yml';

    /**
     *
     */
    public function testCategoryList()
    {
        $object = $this->objFromFixture('CatalogProduct', 'one');
        $expected = $this->objFromFixture('CatalogCategory', 'default')->Title;
        $this->assertEquals($expected, $object->CategoryList());

    }

    /**
     *
     */
    public function testGetImage()
    {
        $object = $this->objFromFixture('CatalogProduct', 'one');
        $this->assertEquals($object->getImage(), $object->Slides()->first());

    }

    public function testGetCMSFields()
    {
        $object = new CatalogProduct();
        $fieldset = $object->getCMSFields();
        $this->assertTrue(is_a($fieldset, 'FieldList'));

        //$this->assertNull($fieldset->dataFieldByName('TechDocs'));


        $object = $this->objFromFixture('CatalogProduct', 'one');
        $fieldset = $object->getCMSFields();
        $this->assertTrue(is_a($fieldset, 'FieldList'));

    }

    public function testGetPrimaryCategory()
    {
        $object = $this->objFromFixture('CatalogProduct', 'one');
        $this->assertEquals($object->getPrimaryCategory(), $object->Categories()->sort('SortOrder')->first());

    }

    public function testGetDefaultSearchContext()
    {
        $object = $this->objFromFixture('CatalogProduct', 'one');
        $this->assertInstanceOf('SearchContext', $object->getDefaultSearchContext());
    }

    public function testCanView()

    {
        $object = $this->objFromFixture('CatalogProduct', 'one');

        $admin = $this->objFromFixture('Member', 'admin');
        $this->assertTrue($object->canView($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $member = $this->objFromFixture('Member', 'default');
        $this->assertTrue($object->canView($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanEdit()

    {
        $object = $this->objFromFixture('CatalogProduct', 'one');

        $admin = $this->objFromFixture('Member', 'admin');
        $this->assertTrue($object->canEdit($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $member = $this->objFromFixture('Member', 'default');
        $this->assertFalse($object->canEdit($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanDelete()

    {
        $object = $this->objFromFixture('CatalogProduct', 'one');

        $admin = $this->objFromFixture('Member', 'admin');
        $this->assertTrue($object->canDelete($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $member = $this->objFromFixture('Member', 'default');
        $this->assertFalse($object->canDelete($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testCanCreate()

    {
        $object = $this->objFromFixture('CatalogProduct', 'one');

        $admin = $this->objFromFixture('Member', 'admin');
        $this->assertTrue($object->canCreate($admin));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $member = $this->objFromFixture('Member', 'default');
        $this->assertFalse($object->canCreate($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testProvidePermissions()
    {
        $object = $this->objFromFixture('CatalogProduct', 'one');
        $expected = array(
            'Product_EDIT' => 'Edit a Product',
            'Product_DELETE' => 'Delete a Product',
            'Product_CREATE' => 'Create a Product',
        );
        $this->assertEquals($expected, $object->providePermissions());

    }
}

1		<?php
2
3		class CatalogProductTest extends SapphireTest
4		{
5		/**
6		* @var string
7		*/
8		protected static $fixture_file = 'product-catalog/tests/fixtures.yml';
9
10		/**
11		*
12		*/
13		public function testCategoryList()
14		{
15		$object = $this->objFromFixture('CatalogProduct', 'one');
16		$expected = $this->objFromFixture('CatalogCategory', 'default')->Title;
17		$this->assertEquals($expected, $object->CategoryList());
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
18		}
19
20		/**
21		*
22		*/
23		public function testGetImage()
24		{
25		$object = $this->objFromFixture('CatalogProduct', 'one');
26		$this->assertEquals($object->getImage(), $object->Slides()->first());
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
27		}
28
29		public function testGetCMSFields()
30		{
31		$object = new CatalogProduct();
32		$fieldset = $object->getCMSFields();
33		$this->assertTrue(is_a($fieldset, 'FieldList'));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
34		//$this->assertNull($fieldset->dataFieldByName('TechDocs'));
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report `84%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
35
36		$object = $this->objFromFixture('CatalogProduct', 'one');
37		$fieldset = $object->getCMSFields();
38		$this->assertTrue(is_a($fieldset, 'FieldList'));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
39		}
40
41		public function testGetPrimaryCategory()
42		{
43		$object = $this->objFromFixture('CatalogProduct', 'one');
44		$this->assertEquals($object->getPrimaryCategory(), $object->Categories()->sort('SortOrder')->first());
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
45		}
46
47		public function testGetDefaultSearchContext()
48		{
49		$object = $this->objFromFixture('CatalogProduct', 'one');
50		$this->assertInstanceOf('SearchContext', $object->getDefaultSearchContext());
51		}
52
53	View Code Duplication	public function testCanView()
		0 ignored issues – show Duplication introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
54		{
55		$object = $this->objFromFixture('CatalogProduct', 'one');
56
57		$admin = $this->objFromFixture('Member', 'admin');
58		$this->assertTrue($object->canView($admin));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'admin')` on line `57` can also be of type `object<DataObject>`; however, `DataObject::canView()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
59
60		$member = $this->objFromFixture('Member', 'default');
61		$this->assertTrue($object->canView($member));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture('Member', 'default')` on line `60` can also be of type `object<DataObject>`; however, `DataObject::canView()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
62		}
63
64	View Code Duplication	public function testCanEdit()
		0 ignored issues – show Duplication introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		{
66		$object = $this->objFromFixture('CatalogProduct', 'one');
67
68		$admin = $this->objFromFixture('Member', 'admin');
69		$this->assertTrue($object->canEdit($admin));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'admin')` on line `68` can also be of type `object<DataObject>`; however, `DataObject::canEdit()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
70
71		$member = $this->objFromFixture('Member', 'default');
72		$this->assertFalse($object->canEdit($member));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture('Member', 'default')` on line `71` can also be of type `object<DataObject>`; however, `DataObject::canEdit()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
73		}
74
75	View Code Duplication	public function testCanDelete()
		0 ignored issues – show Duplication introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
76		{
77		$object = $this->objFromFixture('CatalogProduct', 'one');
78
79		$admin = $this->objFromFixture('Member', 'admin');
80		$this->assertTrue($object->canDelete($admin));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'admin')` on line `79` can also be of type `object<DataObject>`; however, `DataObject::canDelete()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
81
82		$member = $this->objFromFixture('Member', 'default');
83		$this->assertFalse($object->canDelete($member));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture('Member', 'default')` on line `82` can also be of type `object<DataObject>`; however, `DataObject::canDelete()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
84		}
85
86	View Code Duplication	public function testCanCreate()
		0 ignored issues – show Duplication introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
87		{
88		$object = $this->objFromFixture('CatalogProduct', 'one');
89
90		$admin = $this->objFromFixture('Member', 'admin');
91		$this->assertTrue($object->canCreate($admin));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$admin` defined by `$this->objFromFixture('Member', 'admin')` on line `90` can also be of type `object<DataObject>`; however, `DataObject::canCreate()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
92
93		$member = $this->objFromFixture('Member', 'default');
94		$this->assertFalse($object->canCreate($member));
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `$this->objFromFixture('Member', 'default')` on line `93` can also be of type `object<DataObject>`; however, `DataObject::canCreate()` does only seem to accept `object<Member>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
95		}
96
97		public function testProvidePermissions()
98		{
99		$object = $this->objFromFixture('CatalogProduct', 'one');
100		$expected = array(
101		'Product_EDIT' => 'Edit a Product',
102		'Product_DELETE' => 'Delete a Product',
103		'Product_CREATE' => 'Create a Product',
104		);
105		$this->assertEquals($expected, $object->providePermissions());
		0 ignored issues – show Bug introduced 2017-02-19 05:06 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<CatalogProductTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
106		}
107		}

dynamic / silverstripe-product-catalog

Pull Request — master (#1)

CatalogProductTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like