Dynamic\ProductCatalog\Page\CatalogCategoryController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	view()	0	13	2
A	getProductFromRequest()	0	14	3
A	getProduct()	0	7	2
A	setProduct()	0	5	1

<?php

namespace Dynamic\ProductCatalog\Page;

use Dynamic\ProductCatalog\ORM\CatalogProduct;
use SilverStripe\Control\HTTPRequest;

class CatalogCategoryController extends \PageController
{
    /**
     * @var array
     */
    private static $allowed_actions = array(

The private property $allowed_actions is not used, and could be removed.

        'view',
    );

    /**
     * @var
     */
    private $product;

    /**
     * @param HTTPRequest|null $request
     *
     * @return mixed
     */
    public function getProduct(HTTPRequest $request = null)
    {
        if (!$this->product) {
            $this->setProduct($this->getProductFromRequest($request));

It seems like $request can also be of type SilverStripe\Control\HTTPRequest; however, parameter $request of Dynamic\ProductCatalog\Page\CatalogCategoryController::getProductFromRequest() does only seem to accept null, maybe add an additional type check?

        }

        return $this->product;
    }

    /**
     * @param null $request

Are you sure the doc-type for parameter $request is correct as it would always require null to be passed?

     *
     * @return bool|\SilverStripe\ORM\DataObject
     */
    public function getProductFromRequest($request = null)
    {
        if (!$request) {

$request is of type null, thus it always evaluated to false.

            $request = $this->getRequest();
        }

        $productID = $request->param('ID');
        if ($productID) {
            $product = CatalogProduct::get()->filter('URLSegment', $productID)->first();

            return $product;
        }

        return false;
    }

    /**
     * @param $product
     *
     * @return $this
     */
    public function setProduct($product)
    {
        $this->product = $product;

        return $this;
    }

    /**
     * @param HTTPRequest $request
     *
     * @return \SilverStripe\ORM\FieldType\DBHTMLText
     */
    public function view(HTTPRequest $request)

The parameter $request is not used and could be removed.

    {
        $product = $this->getProduct();
        if (!$product) {
            return $this->httpError(404, 'The product you\'re looking for isn\'t available.');
        }

        return $this->customise(array(
            'Title' => $product->getTitle(),
            'Product' => $product,
            'MetaTags' => $product->MetaTags(),
            'Breadcrumbs' => $product->Breadcrumbs(),
        ))->renderWith(array('Dynamic\ProductCatalog\Page\Product', 'Page'));
    }
}