Dynamic\ProductCatalog\Page\CatalogCategory

Complexity

Total Complexity

3

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getProductList()	0	3	1
A	getCMSFields()	0	22	2

<?php

namespace Dynamic\ProductCatalog\Page;

use Dynamic\ProductCatalog\ORM\CatalogProduct;
use SilverStripe\Forms\GridField\GridField;
use SilverStripe\Forms\GridField\GridFieldAddExistingAutocompleter;
use SilverStripe\Forms\GridField\GridFieldConfig_RelationEditor;
use SilverStripe\Forms\GridField\GridFieldPageCount;
use SilverStripe\Forms\GridField\GridFieldPaginator;
use Symbiote\GridFieldExtensions\GridFieldAddExistingSearchButton;
use Symbiote\GridFieldExtensions\GridFieldOrderableRows;

class CatalogCategory extends \Page
{
    /**
     * @var array
     */
    private static $belongs_many_many = array(

The private property $belongs_many_many is not used, and could be removed.

        'Products' => CatalogProduct::class,
    );

    /**
     * @var string
     */
    private static $table_name = 'CatalogCategory';

The private property $table_name is not used, and could be removed.

    /**
     * @return \SilverStripe\Forms\FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        if ($this->ID) {
            // Products
            $config = GridFieldConfig_RelationEditor::create();
            $config->addComponent(new GridFieldOrderableRows('SortOrder'));
            $config->removeComponentsByType(GridFieldAddExistingAutocompleter::class);
            $config->addComponent(new GridFieldAddExistingSearchButton());
            $config->removeComponentsByType(GridFieldPaginator::class);
            $config->removeComponentsByType(GridFieldPageCount::class);

            $products = $this->Products()->sort('SortOrder');

The method Products() does not exist on Dynamic\ProductCatalog\Page\CatalogCategory. Since you implemented __call, consider adding a @method annotation.

            $productsField = GridField::create('Products', 'Products', $products, $config);

            $fields->addFieldsToTab('Root.Products', array(
                $productsField,
            ));
        }

        return $fields;
    }

    /**
     * @return DataList

The type Dynamic\ProductCatalog\Page\DataList was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function getProductList()
    {
        return $this->Products()->sort('SortOrder');
    }
}