Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
6 | class ManageableObjectDataExtension extends DataExtension |
||
7 | { |
||
8 | |||
9 | /** |
||
10 | * Get the listing page to view this Event on (used in Link functions below) |
||
11 | * |
||
12 | * @return mixed |
||
13 | */ |
||
14 | 4 | public function getListingPage() |
|
25 | |||
26 | /** |
||
27 | * @return bool |
||
28 | */ |
||
29 | 1 | public function getAddLink() |
|
37 | |||
38 | /** |
||
39 | * @return bool|String |
||
40 | */ |
||
41 | 1 | View Code Duplication | public function getEditLink() |
53 | |||
54 | /** |
||
55 | * @return bool|String |
||
56 | */ |
||
57 | 1 | View Code Duplication | public function getDeleteLink() |
69 | |||
70 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.