Completed
Pull Request — master (#12)
by Matthew
20:58 queued 05:58
created
src/Extensions/ManageableDataObjectExtension.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -39,14 +39,14 @@  discard block
 block discarded – undo
39 39
         if ($object->canCreate(Security::getCurrentUser())) {
40 40
 
41 41
             $form = $this->ManageableDataObjectForm();
42
-            if($object->config()->get('add_form_cancel_button')){
42
+            if ($object->config()->get('add_form_cancel_button')) {
43 43
                 $form->Actions()->push(new CancelFormAction($this->owner->Link(), 'Cancel'));
44 44
             }
45 45
 
46 46
             return $this->owner->customise([
47 47
                 'Title' => ($this->owner->config()->get('add_item_title'))
48 48
                     ? $this->owner->config()->get('add_item_title')
49
-                    : 'Add new ' . $object->singular_name(),
49
+                    : 'Add new '.$object->singular_name(),
50 50
                 'ManageableDataObjectForm' => $form,
51 51
             ]);
52 52
         }
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
                 $form = $this->ManageableDataObjectForm($item);
72 72
 
73 73
                 return $this->owner->customise([
74
-                    'Title' => 'Edit ' . $item->singular_name(),
74
+                    'Title' => 'Edit '.$item->singular_name(),
75 75
                     'ManageableDataObjectForm' => $form,
76 76
                     'Item' => $item,
77 77
                 ]);
Please login to merge, or discard this patch.
tests/Extensions/ManageableDataObjectExtensionTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -66,11 +66,11 @@  discard block
 block discarded – undo
66 66
     {
67 67
         $this->logInWithPermission('MDO_Edit');
68 68
         $object = $this->objFromFixture(SampleManageableDataObject::class, 'one');
69
-        $response = $this->get('/SampleManageableObjectPageController/edit/' . $object->ID);
69
+        $response = $this->get('/SampleManageableObjectPageController/edit/'.$object->ID);
70 70
         $this->assertEquals(200, $response->getStatusCode());
71 71
         $this->logOut();
72 72
 
73
-        $response2 = $this->get('/SampleManageableObjectPageController/edit/' . 0);
73
+        $response2 = $this->get('/SampleManageableObjectPageController/edit/'.0);
74 74
         $this->assertEquals(404, $response2->getStatusCode());
75 75
     }
76 76
 
@@ -87,10 +87,10 @@  discard block
 block discarded – undo
87 87
 
88 88
         $this->logInWithPermission('MDO_Delete');
89 89
 
90
-        $response404 = $this->get('/SampleManageableObjectPageController/delete/' . 0);
90
+        $response404 = $this->get('/SampleManageableObjectPageController/delete/'.0);
91 91
         $this->assertEquals(404, $response404->getStatusCode());
92 92
 
93
-        $success = $this->get('/SampleManageableObjectPageController/delete/' . $id);
93
+        $success = $this->get('/SampleManageableObjectPageController/delete/'.$id);
94 94
         $this->assertEquals(200, $success->getStatusCode());
95 95
         $this->assertNull(SampleManageableDataObject::get()->byID($id));
96 96
 
Please login to merge, or discard this patch.