dynamic / silverstripe-locator

src/bulkloader/LocationCsvBulkLoader.php

<?php

namespace Dynamic\Locator\Bulkloader;

use Dynamic\Locator\Model\LocationCategory;
use phpDocumentor\Reflection\Location;
use SilverStripe\Dev\CsvBulkLoader;
use SilverStripe\Core\Convert;
use SilverStripe\i18n\Data\Intl\IntlLocales;

/**
 * Class LocationCsvBulkLoader
 * @package Dynamic\Locator
 */
class LocationCsvBulkLoader extends CsvBulkLoader
{

    /**
     * @var array
     */
    public $columnMap = array(
        'Name' => 'Title',
        'EmailAddress' => 'Email',
        'Categories' => '->getCategoryByName',
        'Import_ID' => 'Import_ID',
        'Country' => '->getCountryByName',
    );

    /**
     * @var array
     */
    public $duplicateChecks = array(
        'Import_ID' => 'Import_ID'
    );

    /**
     * @param $val
     * @return string|string[]|null
     */
    public function getEscape($val)
    {
        return preg_replace("/\r|\n/", "", $val);
    }

    /**
     * @param $obj
     * @param $val
     * @param $record
     * @throws \SilverStripe\ORM\ValidationException
     */
    public static function getCategoryByName(&$obj, $val, $record)

The parameter $record is not used and could be removed.

    {
        $val = Convert::raw2sql($val);
        $parts = explode(', ', $val);

It seems like $val can also be of type array and array; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

        foreach ($parts as $part) {
            $category = LocationCategory::get()->filter(array('Name' => $part))->first();
            if (!$category) {
                $category = LocationCategory::create();
                $category->Name = $part;
                $category->write();
            }
            $obj->Categories()->add($category);
        }
    }

    /**
     * @param $obj
     * @param $val
     * @param $record
     */
    public function getCountryByName(&$obj, $val, $record)

The parameter $record is not used and could be removed.

    {
        $val = $this->getEscape($val);
        $countries = IntlLocales::singleton()->getCountries();

        if (strlen((string)$val) == 2) {
            $val = strtolower($val);

It seems like $val can also be of type string[]; however, parameter $str of strtolower() does only seem to accept string, maybe add an additional type check?

            if (array_key_exists($val, $countries)) {
                $obj->Country = $val;
            }
        }

        if (in_array($val, $countries)) {
            $obj->Country = array_search($val, $countries);
        }
    }

    /**
     * @param array $record
     * @param array $columnMap
     * @param \SilverStripe\Dev\BulkLoader_Result $results
     * @param bool $preview
     * @return int|void
     */
    protected function processRecord($record, $columnMap, &$results, $preview = false)
    {
        $objID = parent::processRecord($record, $columnMap, $results, $preview = false);

        $location = Location::get()->byID($objID);

The method get() does not exist on phpDocumentor\Reflection\Location.

        $location->publishSingle();
    }
}